Transmission/transmission
1
0
Fork 0
mirror of https://github.com/transmission/transmission.git synced 2025-12-24 12:28:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: fix more sonarcloud warnings (#1508)

Browse Source 
* refactor: const correctness

* refactor: use getpwuid_r instead of getpwuid

* chore: simplify dict walking loop logic

* refactor: remove dead store assignment in announcer

* refactor: use std::make_shared
This commit is contained in:
Charles Kerr
2020-11-05 16:46:21 -06:00
committed by GitHub
parent e74b3bad8b
commit 7f147c65fb
62 changed files with 355 additions and 414 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
qt/PrefsDialog.h
View File

@@ -30,25 +30,6 @@ class PrefsDialog : public BaseDialog
public:
PrefsDialog(Session&, Prefs&, QWidget* parent = nullptr);
private:
using key2widget_t = QMap<int, QWidget*>;
private:
bool updateWidgetValue(QWidget* widget, int pref_key);
void linkWidgetToPref(QWidget* widget, int pref_key);
void updateBlocklistLabel();
void updateDownloadingWidgetsLocality();
void setPref(int key, QVariant const& v);
void initDownloadingTab();
void initSeedingTab();
void initSpeedTab();
void initPrivacyTab();
void initNetworkTab();
void initDesktopTab();
void initRemoteTab();
private slots:
void checkBoxToggled(bool checked);
void spinBoxEditingFinished();
@@ -70,6 +51,23 @@ private slots:
void onBlocklistUpdated(int n);
private:
using key2widget_t = QMap<int, QWidget*>;
bool updateWidgetValue(QWidget* widget, int pref_key);
void linkWidgetToPref(QWidget* widget, int pref_key);
void updateBlocklistLabel();
void updateDownloadingWidgetsLocality();
void setPref(int key, QVariant const& v);
void initDownloadingTab();
void initSeedingTab();
void initSpeedTab();
void initPrivacyTab();
void initNetworkTab();
void initDesktopTab();
void initRemoteTab();
Session& session_;
Prefs& prefs_;