Transmission/transmission
1
0
Fork 0
mirror of https://github.com/transmission/transmission.git synced 2025-12-25 04:45:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

perf: avoid extra heap alloc in block cache (#5522)

Browse Source
This commit is contained in:
Charles Kerr
2023-05-13 14:16:00 -05:00
committed by GitHub
parent 69fc149f07
commit 8a1a6dba49
5 changed files with 58 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
libtransmission/webseed.cc
View File

@@ -338,7 +338,7 @@ public:
tr_session* session,
tr_torrent_id_t tor_id,
tr_block_index_t block,
std::unique_ptr<std::vector<uint8_t>>& data,
std::unique_ptr<Cache::BlockData> data,
tr_webseed* webseed)
: session_{ session }
, tor_id_{ tor_id }
@@ -363,7 +363,7 @@ private:
tr_session* const session_;
tr_torrent_id_t const tor_id_;
tr_block_index_t const block_;
std::unique_ptr<std::vector<uint8_t>> data_;
std::unique_ptr<Cache::BlockData> data_;
tr_webseed* const webseed_;
};
@@ -394,10 +394,9 @@ void useFetchedBlocks(tr_webseed_task* task)
}
else
{
auto block_buf = std::make_unique<std::vector<uint8_t>>();
block_buf->resize(block_size);
auto block_buf = std::make_unique<Cache::BlockData>(block_size);
evbuffer_remove(task->content(), std::data(*block_buf), std::size(*block_buf));
auto* const data = new write_block_data{ session, tor->id(), task->loc.block, block_buf, webseed };
auto* const data = new write_block_data{ session, tor->id(), task->loc.block, std::move(block_buf), webseed };
session->runInSessionThread(&write_block_data::write_block_func, data);
}