Transmission/transmission
1
0
Fork 0
mirror of https://github.com/transmission/transmission.git synced 2025-12-24 20:35:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: sonarcloud (#2558)

Browse Source 
* fix: add const modifier for functions

* fix: many sonarcloud use-init-statement warnings
This commit is contained in:
Charles Kerr
2022-01-31 22:46:27 -06:00
committed by GitHub
parent cf2c32e1ce
commit 8b9483f7fb
58 changed files with 158 additions and 288 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
gtk/PrefsDialog.cc
View File

@@ -3,6 +3,7 @@
// or any future license endorsed by Mnemosyne LLC.
// License text can be found in the licenses/ folder.
#include <array>
#include <climits> /* USHRT_MAX, INT_MAX */
#include <sstream>
#include <string>
@@ -1097,7 +1098,7 @@ PrefsDialog::Impl::Impl(PrefsDialog& dialog, Glib::RefPtr<Session> const& core)
: dialog_(dialog)
, core_(core)
{
static tr_quark const prefs_quarks[] = { TR_KEY_peer_port, TR_KEY_download_dir };
auto constexpr PrefsQuarks = std::array<tr_quark, 2>{ TR_KEY_peer_port, TR_KEY_download_dir };
core_prefs_tag_ = core_->signal_prefs_changed().connect(sigc::mem_fun(*this, &Impl::on_core_prefs_changed));
@@ -1118,7 +1119,7 @@ PrefsDialog::Impl::Impl(PrefsDialog& dialog, Glib::RefPtr<Session> const& core)
n->append_page(*remotePage(), _("Remote"));
/* init from prefs keys */
for (auto const key : prefs_quarks)
for (auto const key : PrefsQuarks)
{
on_core_prefs_changed(key);
}