chore: re-enable qt clang tidy warnings (#3791)

This commit is contained in:
Charles Kerr
2022-09-08 18:26:18 -05:00
committed by GitHub
parent 99e750229c
commit 9280bf3475
25 changed files with 159 additions and 178 deletions
+5 -5
View File
@@ -283,23 +283,23 @@ void RpcClient::localRequestFinished(TrVariantPtr response)
promise.reportFinished(&result);
}
int64_t RpcClient::parseResponseTag(tr_variant& json) const
int64_t RpcClient::parseResponseTag(tr_variant& response) const
{
auto const tag = dictFind<int>(&json, TR_KEY_tag);
auto const tag = dictFind<int>(&response, TR_KEY_tag);
return tag ? *tag : -1;
}
RpcResponse RpcClient::parseResponseData(tr_variant& json) const
RpcResponse RpcClient::parseResponseData(tr_variant& response) const
{
RpcResponse ret;
if (auto const result = dictFind<QString>(&json, TR_KEY_result); result)
if (auto const result = dictFind<QString>(&response, TR_KEY_result); result)
{
ret.result = *result;
ret.success = *result == QStringLiteral("success");
}
if (tr_variant* args = nullptr; tr_variantDictFindDict(&json, TR_KEY_arguments, &args))
if (tr_variant* args = nullptr; tr_variantDictFindDict(&response, TR_KEY_arguments, &args))
{
ret.args = createVariant();
*ret.args = *args;