build: bump clang tools to 20 (#7573)

* build: bump to clang-format-20

* build: bump to clang-tidy-20

* chore: revert edc59ba5d8

tests/libtransmission/.clang-tidy

@@ -9,6 +9,7 @@ Checks: >
   -bugprone-narrowing-conversions,
   -bugprone-unchecked-optional-access,
   cert-*,
+  -cert-int09-c,
   clang-analyzer-optin*,
   cppcoreguidelines-*,
   -cppcoreguidelines-avoid-const-or-ref-data-members,
@@ -32,6 +33,7 @@ Checks: >
   -modernize-use-trailing-return-type,
   performance-*,
   readability-*,
+  -readability-enum-initial-value,
   -readability-function-cognitive-complexity,
   -readability-identifier-length,
   -readability-magic-numbers,

tests/libtransmission/announce-list-test.cc

@@ -402,11 +402,12 @@ TEST_F(AnnounceListTest, save)
     EXPECT_EQ(original_tm.piece_count(), modified_tm.piece_count());
 
     // test that the saved version has the updated announce list
-    EXPECT_TRUE(std::equal(
-        std::begin(announce_list),
-        std::end(announce_list),
-        std::begin(modified_tm.announce_list()),
-        std::end(modified_tm.announce_list())));
+    EXPECT_TRUE(
+        std::equal(
+            std::begin(announce_list),
+            std::end(announce_list),
+            std::begin(modified_tm.announce_list()),
+            std::end(modified_tm.announce_list())));
 
     // cleanup
     (void)std::remove(test_file.c_str());

tests/libtransmission/dht-test.cc

@@ -65,10 +65,7 @@ namespace
 
 bool waitFor(struct event_base* event_base, std::chrono::milliseconds msec)
 {
-    return libtransmission::test::waitFor( //
-        event_base,
-        []() { return false; },
-        msec);
+    return libtransmission::test::waitFor(event_base, []() { return false; }, msec);
 }
 
 auto constexpr IdLength = size_t{ 20U };
@@ -604,10 +601,7 @@ TEST_F(DhtTest, usesBootstrapFile)
     auto const expected = tr_socket_address{ tr_address::from_string(BootstrapNodeName).value_or(tr_address{}),
                                              BootstrapNodePort };
     auto& pinged = mediator.mock_dht_.pinged_;
-    waitFor( //
-        event_base_,
-        [&pinged]() { return !std::empty(pinged); },
-        5s);
+    waitFor(event_base_, [&pinged]() { return !std::empty(pinged); }, 5s);
     ASSERT_EQ(1U, std::size(pinged));
     auto const [actual_addrport, time] = pinged.front();
     EXPECT_EQ(expected.address(), actual_addrport.address());

tests/libtransmission/net-test.cc

@@ -82,10 +82,11 @@ TEST_F(NetTest, compact4)
     EXPECT_EQ(std::size(Compact4) - tr_port::CompactPortBytes, static_cast<size_t>(out - std::data(buf)));
     EXPECT_TRUE(
         std::equal(std::data(Compact4), std::data(Compact4) + std::size(Compact4) - tr_port::CompactPortBytes, std::data(buf)));
-    EXPECT_TRUE(std::all_of(
-        std::begin(buf) + std::size(Compact4) - tr_port::CompactPortBytes,
-        std::end(buf),
-        [](std::byte const& byte) { return static_cast<unsigned char>(byte) == 0U; }));
+    EXPECT_TRUE(
+        std::all_of(
+            std::begin(buf) + std::size(Compact4) - tr_port::CompactPortBytes,
+            std::end(buf),
+            [](std::byte const& byte) { return static_cast<unsigned char>(byte) == 0U; }));
 
     /// sockaddr --> compact
 
@@ -144,14 +145,16 @@ TEST_F(NetTest, compact6)
     out = std::data(compact6);
     out = addr.to_compact(out);
     EXPECT_EQ(std::size(Compact6) - tr_port::CompactPortBytes, static_cast<size_t>(out - std::data(compact6)));
-    EXPECT_TRUE(std::equal(
-        std::data(Compact6),
-        std::data(Compact6) + std::size(Compact6) - tr_port::CompactPortBytes,
-        std::data(compact6)));
-    EXPECT_TRUE(std::all_of(
-        std::begin(compact6) + std::size(Compact6) - tr_port::CompactPortBytes,
-        std::end(compact6),
-        [](std::byte const& byte) { return static_cast<unsigned char>(byte) == 0U; }));
+    EXPECT_TRUE(
+        std::equal(
+            std::data(Compact6),
+            std::data(Compact6) + std::size(Compact6) - tr_port::CompactPortBytes,
+            std::data(compact6)));
+    EXPECT_TRUE(
+        std::all_of(
+            std::begin(compact6) + std::size(Compact6) - tr_port::CompactPortBytes,
+            std::end(compact6),
+            [](std::byte const& byte) { return static_cast<unsigned char>(byte) == 0U; }));
 
     /// sockaddr --> compact
 

tests/libtransmission/timer-test.cc

@@ -42,10 +42,7 @@ protected:
 
     void sleepMsec(std::chrono::milliseconds msec)
     {
-        EXPECT_FALSE(waitFor( //
-            evbase_.get(),
-            []() { return false; },
-            msec));
+        EXPECT_FALSE(waitFor(evbase_.get(), []() { return false; }, msec));
     }
 
     static void expectTime(

tests/libtransmission/tr-peer-info-test.cc

@@ -149,14 +149,13 @@ TEST_F(PeerInfoTest, updateCanonicalPriority)
             continue;
         }
 
-        auto const info = tr_peer_info{ *peer_sockaddr,
-                                        0,
-                                        TR_PEER_FROM_PEX,
-                                        client_sockaddr->address(),
-                                        [&client_sockaddr]
-                                        {
-                                            return client_sockaddr->port();
-                                        } };
+        auto const info = tr_peer_info{
+            *peer_sockaddr,
+            0,
+            TR_PEER_FROM_PEX,
+            client_sockaddr->address(),
+            [&client_sockaddr] { return client_sockaddr->port(); },
+        };
         EXPECT_EQ(info.get_canonical_priority(), expected);
     }
 }