diff --git a/macosx/Controller.m b/macosx/Controller.m index 897d84265..f3dca2a8c 100644 --- a/macosx/Controller.m +++ b/macosx/Controller.m @@ -99,6 +99,13 @@ typedef enum SORT_ACTIVITY_TAG = 6 } sortTag; +typedef enum +{ + SORT_ASC_TAG = 0, + SORT_DESC_TAG = 1 +} sortOrderTag; + + #define FILTER_NONE @"None" #define FILTER_ACTIVE @"Active" #define FILTER_DOWNLOAD @"Download" @@ -2057,8 +2064,12 @@ static void sleepCallback(void * controller, io_service_t y, natural_t messageTy - (void) setSortReverse: (id) sender { - [fDefaults setBool: ![fDefaults boolForKey: @"SortReverse"] forKey: @"SortReverse"]; - [self sortTorrents]; + const BOOL setReverse = [sender tag] == SORT_DESC_TAG; + if (setReverse != [fDefaults boolForKey: @"SortReverse"]) + { + [fDefaults setBool: setReverse forKey: @"SortReverse"]; + [self sortTorrents]; + } } - (void) sortTorrents @@ -4021,7 +4032,8 @@ static void sleepCallback(void * controller, io_service_t y, natural_t messageTy //enable reverse sort item if (action == @selector(setSortReverse:)) { - [menuItem setState: [fDefaults boolForKey: @"SortReverse"] ? NSOnState : NSOffState]; + const BOOL isReverse = [menuItem tag] == SORT_DESC_TAG; + [menuItem setState: (isReverse == [fDefaults boolForKey: @"SortReverse"]) ? NSOnState : NSOffState]; return ![[fDefaults stringForKey: @"Sort"] isEqualToString: SORT_ORDER]; } diff --git a/macosx/en.lproj/MainMenu.xib b/macosx/en.lproj/MainMenu.xib index f8c278cb4..664973c0d 100644 --- a/macosx/en.lproj/MainMenu.xib +++ b/macosx/en.lproj/MainMenu.xib @@ -13,8 +13,8 @@ YES - + YES @@ -1325,13 +1325,23 @@ AAAAAAAAAAAAAAAAA - Reverse Sort Order + Ascending 1048576 2147483647 + + + Descending + + 1048576 + 2147483647 + + + 1 + @@ -2332,7 +2342,7 @@ AAAAAAAAAAAAAAAAA NSView - + 266 YES @@ -2341,7 +2351,6 @@ AAAAAAAAAAAAAAAAA 257 {{357, 4}, {95, 15}} - YES 343014976 @@ -2411,7 +2420,6 @@ AAAAAAAAAAAAAAAAA 268 {{42, 2}, {30, 17}} - YES 67239488 @@ -2436,7 +2444,6 @@ AAAAAAAAAAAAAAAAA 268 {{123, 2}, {89, 17}} - YES 67239488 @@ -2457,7 +2464,6 @@ AAAAAAAAAAAAAAAAA 268 {{213, 2}, {59, 17}} - YES 67239488 @@ -2478,7 +2484,6 @@ AAAAAAAAAAAAAAAAA 268 {{273, 2}, {55, 17}} - YES 67239488 @@ -2499,7 +2504,6 @@ AAAAAAAAAAAAAAAAA 268 {{34, 5}, {5, 12}} - {0, 0} 67239424 @@ -2522,7 +2526,6 @@ AAAAAAAAAAAAAAAAA 268 {{5, 4}, {26, 14}} - YES -2076049856 @@ -2593,7 +2596,6 @@ AAAAAAAAAAAAAAAAA 268 {{73, 2}, {49, 17}} - YES 67239488 @@ -2611,8 +2613,6 @@ AAAAAAAAAAAAAAAAA {457, 23} - - FilterBarView NSView @@ -2864,13 +2864,23 @@ AAAAAAAAAAAAAAAAA - Reverse Sort Order + Ascending 1048576 2147483647 + + + Descending + + 1048576 + 2147483647 + + + 1 + @@ -4998,6 +5008,22 @@ AAAAAAAAAAAAAAAAA 3402 + + + setSortReverse: + + + + 3404 + + + + setSortReverse: + + + + 3406 + @@ -5483,6 +5509,7 @@ AAAAAAAAAAAAAAAAA + @@ -6117,10 +6144,11 @@ AAAAAAAAAAAAAAAAA - + + @@ -7071,6 +7099,16 @@ AAAAAAAAAAAAAAAAA + + 3403 + + + + + 3405 + + + @@ -7636,6 +7674,10 @@ AAAAAAAAAAAAAAAAA 3321.IBPluginDependency 3322.IBPluginDependency 3400.IBPluginDependency + 3403.IBPluginDependency + 3403.ImportedFromIB2 + 3405.IBPluginDependency + 3405.ImportedFromIB2 418.IBPluginDependency 418.ImportedFromIB2 456.IBEditorWindowLastContentRect @@ -7846,7 +7888,7 @@ AAAAAAAAAAAAAAAAA com.apple.InterfaceBuilder.CocoaPlugin - {{481, 314}, {194, 173}} + {{481, 294}, {154, 193}} com.apple.InterfaceBuilder.CocoaPlugin {{286, 514}, {197, 173}} @@ -7953,7 +7995,7 @@ AAAAAAAAAAAAAAAAA com.apple.InterfaceBuilder.CocoaPlugin - {{820, 618}, {194, 173}} + {{820, 598}, {154, 193}} com.apple.InterfaceBuilder.CocoaPlugin {{449, 701}, {197, 173}} @@ -8254,6 +8296,10 @@ AAAAAAAAAAAAAAAAA com.apple.InterfaceBuilder.CocoaPlugin com.apple.InterfaceBuilder.CocoaPlugin + com.apple.InterfaceBuilder.CocoaPlugin + + com.apple.InterfaceBuilder.CocoaPlugin + {{586, 242}, {291, 313}} com.apple.InterfaceBuilder.CocoaPlugin @@ -8322,7 +8368,7 @@ AAAAAAAAAAAAAAAAA - 3402 + 3406