Transmission/transmission
1
0
Fork 0
mirror of https://github.com/transmission/transmission.git synced 2026-02-15 07:26:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: cppcoreguidelines-init-variables pt. 11 (#2012)

Browse Source 
* refactor: uninit vars in bandwidth.cc

* refactor: uninit vars in cache.cc

* refactor: uninit vars in fdlimit.cc

* refactor: uninit vars in inout.cc

* refactor: uninit vars in platform.cc

* refactor: uninit vars in log.cc

* refactor: uninit vars in tr-utp.cc

* refactor: uninit vars in stats.cc

* refactor: uninit vars in trevent.cc

* refactor: uninit vars in session-id.cc

* fixup! refactor: uninit vars in cache.cc

* refactor: uninit vars in upnp.cc

* refactor: uninit vars in file.cc

* refactor: uninit vars in tr-lpd.cc

* refactor: uninit vars in tr-udp.cc
This commit is contained in:
Charles Kerr
2021-10-23 10:43:15 -05:00
committed by GitHub
parent 4996f3356a
commit a127826d76
14 changed files with 120 additions and 180 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
libtransmission/file.cc
View File

@@ -21,14 +21,13 @@ bool tr_sys_file_read_line(tr_sys_file_t handle, char* buffer, size_t buffer_siz
TR_ASSERT(buffer != nullptr);
TR_ASSERT(buffer_size > 0);
bool ret = false;
size_t offset = 0;
uint64_t bytes_read;
auto ret = bool{};
auto offset = size_t{};
while (buffer_size > 0)
{
size_t const bytes_needed = std::min(buffer_size, size_t{ 1024 });
auto bytes_read = uint64_t{};
ret = tr_sys_file_read(handle, buffer + offset, bytes_needed, &bytes_read, error);
if (!ret || (offset == 0 && bytes_read == 0))
@@ -103,11 +102,10 @@ bool tr_sys_file_write_fmt(tr_sys_file_t handle, char const* format, tr_error**
TR_ASSERT(format != nullptr);
bool ret = false;
char* buffer;
va_list args;
va_start(args, error);
buffer = tr_strdup_vprintf(format, args);
char* const buffer = tr_strdup_vprintf(format, args);
va_end(args);
if (buffer != nullptr)