Transmission/transmission
1
0
Fork 0
mirror of https://github.com/transmission/transmission.git synced 2025-12-24 20:35:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: cppcoreguidelines-init-variables pt. 13 (#2043)

Browse Source 
* refactor: fix uninit var warnings in ptrarray

* refactor: fix uninit var warnings in bitfield

* refactor: fix uninit var warnings in handshake

* refactor: fix uninit var warnings in tr-dht

* refactor: fix uninit var warnings in natpmp

Co-authored-by: Mike Gelfand <mikedld@users.noreply.github.com>
This commit is contained in:
Charles Kerr
2021-10-26 13:02:07 -05:00
committed by GitHub
parent c42e05b42f
commit b797b4c94f
5 changed files with 37 additions and 88 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
libtransmission/bitfield.cc
View File

@@ -88,10 +88,9 @@ size_t tr_bitfield::countFlags(size_t begin, size_t end) const
if (first_byte == last_byte)
{
int i;
uint8_t val = flags_[first_byte];
i = begin - (first_byte * 8);
int i = begin - (first_byte * 8);
val <<= i;
val >>= i;
i = (last_byte + 1) * 8 - end;
@@ -102,12 +101,11 @@ size_t tr_bitfield::countFlags(size_t begin, size_t end) const
}
else
{
uint8_t val;
size_t const walk_end = std::min(std::size(flags_), last_byte);
/* first byte */
size_t const first_shift = begin - (first_byte * 8);
val = flags_[first_byte];
uint8_t val = flags_[first_byte];
val <<= first_shift;
val >>= first_shift;
ret += trueBitCount[val];