Transmission/transmission
1
0
Fork 0
mirror of https://github.com/transmission/transmission.git synced 2025-12-26 13:21:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: sonarcloud warnings (#2804)

Browse Source 
* fix: break will never be executed

* refactor: compile the name fallback string

* fix: replace redundant type with auto

* fix: use init-statement to reduce variable scope

* fix: implicit conversion loses precision

* fix: use in-class initializer

* fix: make variable a pointer-to-const

* fix: local variable name shadows class variable

* fix: implicit conversion may lose precision
This commit is contained in:
Charles Kerr
2022-03-24 00:18:41 -05:00
committed by GitHub
parent 6db3fbfe64
commit b8c3778cf4
9 changed files with 26 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
libtransmission/log.cc
View File

@@ -14,6 +14,8 @@
#include <event2/buffer.h>
#include <fmt/core.h>
#include <fmt/compile.h>
#include <fmt/format.h>
#include "transmission.h"
@@ -248,7 +250,7 @@ void tr_logAddMessage(char const* file, int line, tr_log_level level, std::strin
if (std::empty(name))
{
auto const base = tr_sys_path_basename(file);
name_fallback = fmt::format("{}:{}", !std::empty(base) ? base : "?", line);
name_fallback = fmt::format(FMT_COMPILE("{}:{}"), !std::empty(base) ? base : "?", line);
name = name_fallback;
}