Transmission/transmission
1
0
Fork 0
mirror of https://github.com/transmission/transmission.git synced 2025-12-24 12:28:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: sonarcloud "use if init" statements (#2587)

Browse Source
This commit is contained in:
Charles Kerr
2022-02-07 23:44:31 -06:00
committed by GitHub
parent 8afbfecadb
commit ba14ffa74c
26 changed files with 126 additions and 163 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
qt/FileTreeModel.cc
View File

@@ -332,14 +332,14 @@ void FileTreeModel::addFile(
while (filename_it.hasNext())
{
QString const& token = filename_it.next();
std::pair<int, int> const changed = item->update(token, wanted, priority, have, update_fields);
auto const& token = filename_it.next();
auto const& [first_col, last_col] = item->update(token, wanted, priority, have, update_fields);
if (changed.first >= 0)
if (first_col >= 0)
{
emit dataChanged(indexOf(item, changed.first), indexOf(item, changed.second));
emit dataChanged(indexOf(item, first_col), indexOf(item, last_col));
if (!index_with_changed_parents.isValid() && changed.first <= COL_PRIORITY && changed.second >= COL_SIZE)
if (!index_with_changed_parents.isValid() && first_col <= COL_PRIORITY && last_col >= COL_SIZE)
{
index_with_changed_parents = indexOf(item, 0);
}
@@ -398,11 +398,11 @@ void FileTreeModel::addFile(
index_cache_[file_index] = item;
std::pair<int, int> const changed = item->update(item->name(), wanted, priority, have, added || update_fields);
auto const [first_col, last_col] = item->update(item->name(), wanted, priority, have, added || update_fields);
if (changed.first >= 0)
if (first_col >= 0)
{
emit dataChanged(indexOf(item, changed.first), indexOf(item, changed.second));
emit dataChanged(indexOf(item, first_col), indexOf(item, last_col));
}
}
}