Transmission/transmission
1
0
Fork 0
mirror of https://github.com/transmission/transmission.git synced 2025-12-24 12:28:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix clang-tidy issues stemming from header files (GTK client) (#4623)

Browse Source 
* Fix `readability-avoid-const-params-in-decls` clang-tidy issues

* Fix `bugprone-macro-parentheses` clang-tidy issues

* Fix `modernize-use-using` clang-tidy issues

* Fix `readability-named-parameter` clang-tidy issues

* Fix `cppcoreguidelines-owning-memory` clang-tidy issues

* Fix `cppcoreguidelines-special-member-functions` clang-tidy issues

* Fix `cppcoreguidelines-macro-usage` clang-tidy issues

* Fix `modernize-use-nodiscard` clang-tidy issues

* Fix `cppcoreguidelines-macro-usage` clang-tidy issues

* Add headers filter for /gtk/ subdirectory
This commit is contained in:
Mike Gelfand
2023-01-21 15:06:20 +03:00
committed by GitHub
parent 8755207dcf
commit bd72b8c3fc
14 changed files with 59 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
gtk/SorterBase.h
View File

@@ -7,6 +7,8 @@
#include "GtkCompat.h"
#include <libtransmission/tr-macros.h>
#if GTKMM_CHECK_VERSION(4, 0, 0)
#include <gtkmm/sorter.h>
#else
@@ -27,8 +29,11 @@ public:
#endif
public:
SorterBase() = default;
~SorterBase() override = default;
TR_DISABLE_COPY_MOVE(SorterBase)
virtual int compare(T const& lhs, T const& rhs) const = 0;
#if !GTKMM_CHECK_VERSION(4, 0, 0)