Transmission/transmission
1
0
Fork 0
mirror of https://github.com/transmission/transmission.git synced 2025-12-24 20:35:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix clang-tidy issues stemming from header files (GTK client) (#4623)

Browse Source 
* Fix `readability-avoid-const-params-in-decls` clang-tidy issues

* Fix `bugprone-macro-parentheses` clang-tidy issues

* Fix `modernize-use-using` clang-tidy issues

* Fix `readability-named-parameter` clang-tidy issues

* Fix `cppcoreguidelines-owning-memory` clang-tidy issues

* Fix `cppcoreguidelines-special-member-functions` clang-tidy issues

* Fix `cppcoreguidelines-macro-usage` clang-tidy issues

* Fix `modernize-use-nodiscard` clang-tidy issues

* Fix `cppcoreguidelines-macro-usage` clang-tidy issues

* Add headers filter for /gtk/ subdirectory
This commit is contained in:
Mike Gelfand
2023-01-21 15:06:20 +03:00
committed by GitHub
parent 8755207dcf
commit bd72b8c3fc
14 changed files with 59 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
gtk/Utils.cc
View File

@@ -563,12 +563,12 @@ EnumComboModelColumns const enum_combo_cols;
} // namespace
void gtr_combo_box_set_active_enum(Gtk::ComboBox& combo_box, int value)
void gtr_combo_box_set_active_enum(Gtk::ComboBox& combo, int value)
{
auto const& column = enum_combo_cols.value;
/* do the value and current value match? */
if (auto const iter = combo_box.get_active(); iter)
if (auto const iter = combo.get_active(); iter)
{
if (iter->get_value(column) == value)
{
@@ -577,11 +577,11 @@ void gtr_combo_box_set_active_enum(Gtk::ComboBox& combo_box, int value)
}
/* find the one to select */
for (auto const& row : combo_box.get_model()->children())
for (auto const& row : combo.get_model()->children())
{
if (row.get_value(column) == value)
{
combo_box.set_active(TR_GTK_TREE_MODEL_CHILD_ITER(row));
combo.set_active(TR_GTK_TREE_MODEL_CHILD_ITER(row));
return;
}
}
@@ -606,11 +606,11 @@ void gtr_combo_box_set_enum(Gtk::ComboBox& combo, std::vector<std::pair<Glib::us
combo.add_attribute(r->property_text(), enum_combo_cols.label);
}
int gtr_combo_box_get_active_enum(Gtk::ComboBox const& combo_box)
int gtr_combo_box_get_active_enum(Gtk::ComboBox const& combo)
{
int value = 0;
if (auto const iter = combo_box.get_active(); iter)
if (auto const iter = combo.get_active(); iter)
{
iter->get_value(0, value);
}