diff --git a/libtransmission/cache.cc b/libtransmission/cache.cc index bc8d56ad8..a5b4352f6 100644 --- a/libtransmission/cache.cc +++ b/libtransmission/cache.cc @@ -29,7 +29,7 @@ Cache::Key Cache::make_key(tr_torrent const& tor, tr_block_info::Location const return std::make_pair(tor.id(), loc.block); } -Cache::CIter Cache::find_span_end(CIter span_begin, CIter end) noexcept +Cache::CIter Cache::find_span_end(CIter const& span_begin, CIter const& end) noexcept { static constexpr auto NotAdjacent = [](CacheBlock const& block1, CacheBlock const& block2) { @@ -39,7 +39,7 @@ Cache::CIter Cache::find_span_end(CIter span_begin, CIter end) noexcept return span_end == end ? end : std::next(span_end); } -std::pair Cache::find_biggest_span(CIter const begin, CIter const end) noexcept +std::pair Cache::find_biggest_span(CIter const& begin, CIter const& end) noexcept { auto biggest_begin = begin; auto biggest_end = begin; @@ -62,7 +62,7 @@ std::pair Cache::find_biggest_span(CIter const begin return { biggest_begin, biggest_end }; } -int Cache::write_contiguous(CIter const begin, CIter const end) const +int Cache::write_contiguous(CIter const& begin, CIter const& end) const { // The most common case without an extra data copy. auto const* out = std::data(*begin->buf); @@ -185,7 +185,7 @@ int Cache::read_block(tr_torrent const& tor, tr_block_info::Location const& loc, // --- -int Cache::flush_span(CIter const begin, CIter const end) +int Cache::flush_span(CIter const& begin, CIter const& end) { for (auto span_begin = begin; span_begin < end;) { diff --git a/libtransmission/cache.h b/libtransmission/cache.h index dcabfe27f..571c87b2e 100644 --- a/libtransmission/cache.h +++ b/libtransmission/cache.h @@ -56,15 +56,15 @@ private: [[nodiscard]] static Key make_key(tr_torrent const& tor, tr_block_info::Location loc) noexcept; - [[nodiscard]] static std::pair find_biggest_span(CIter begin, CIter end) noexcept; + [[nodiscard]] static std::pair find_biggest_span(CIter const& begin, CIter const& end) noexcept; - [[nodiscard]] static CIter find_span_end(CIter span_begin, CIter end) noexcept; + [[nodiscard]] static CIter find_span_end(CIter const& span_begin, CIter const& end) noexcept; // @return any error code from tr_ioWrite() - [[nodiscard]] int write_contiguous(CIter begin, CIter end) const; + [[nodiscard]] int write_contiguous(CIter const& begin, CIter const& end) const; // @return any error code from writeContiguous() - [[nodiscard]] int flush_span(CIter begin, CIter end); + [[nodiscard]] int flush_span(CIter const& begin, CIter const& end); // @return any error code from writeContiguous() [[nodiscard]] int flush_biggest(); diff --git a/libtransmission/peer-mgr-wishlist.cc b/libtransmission/peer-mgr-wishlist.cc index 3cc4f477a..bcb589efd 100644 --- a/libtransmission/peer-mgr-wishlist.cc +++ b/libtransmission/peer-mgr-wishlist.cc @@ -390,7 +390,7 @@ private: } } - TR_CONSTEXPR20 void resort_piece(CandidateVec::iterator const pos_old) + TR_CONSTEXPR20 void resort_piece(CandidateVec::iterator const& pos_old) { if (candidates_dirty_) {