Transmission/transmission
1
0
Fork 0
mirror of https://github.com/transmission/transmission.git synced 2026-02-15 07:26:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: remove tr_sys file_map_for_reading() (#3723)

Browse Source
This commit is contained in:
Charles Kerr
2022-08-27 14:05:21 -05:00
committed by GitHub
parent 6e44adabf1
commit db3467b553
10 changed files with 139 additions and 544 deletions
Download Patch File Download Diff File Expand all files Collapse all files

66
libtransmission/file.cc
View File

@@ -13,72 +13,6 @@
using namespace std::literals;
bool tr_sys_file_read_line(tr_sys_file_t handle, char* buffer, size_t buffer_size, tr_error** error)
{
TR_ASSERT(handle != TR_BAD_SYS_FILE);
TR_ASSERT(buffer != nullptr);
TR_ASSERT(buffer_size > 0);
auto ret = bool{};
auto offset = size_t{};
while (buffer_size > 0)
{
size_t const bytes_needed = std::min(buffer_size, size_t{ 1024 });
auto bytes_read = uint64_t{};
ret = tr_sys_file_read(handle, buffer + offset, bytes_needed, &bytes_read, error);
if (!ret || (offset == 0 && bytes_read == 0))
{
ret = false;
break;
}
TR_ASSERT(bytes_read <= bytes_needed);
TR_ASSERT(bytes_read <= buffer_size);
int64_t delta = 0;
for (size_t i = 0; i < bytes_read; ++i)
{
if (buffer[offset] == '\n')
{
delta = i - (int64_t)bytes_read + 1;
break;
}
++offset;
--buffer_size;
}
if (delta != 0 || buffer_size == 0 || bytes_read == 0)
{
if (delta != 0)
{
ret = tr_sys_file_seek(handle, delta, TR_SEEK_CUR, nullptr, error);
if (!ret)
{
break;
}
}
if (offset > 0 && buffer[offset - 1] == '\r')
{
buffer[offset - 1] = '\0';
}
else
{
buffer[offset] = '\0';
}
break;
}
}
return ret;
}
bool tr_sys_file_write_line(tr_sys_file_t handle, std::string_view buffer, tr_error** error)
{
TR_ASSERT(handle != TR_BAD_SYS_FILE);