Transmission/transmission
1
0
Fork 0
mirror of https://github.com/transmission/transmission.git synced 2025-12-20 02:18:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

perf: use iterator range insert in Wishlist::next (#7890)

Browse Source
This commit is contained in:
Yat Ho
2025-12-08 01:15:14 +08:00
committed by GitHub
parent 8dc5080dc7
commit e034799f6f
1 changed files with 6 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
libtransmission/peer-mgr-wishlist.cc
View File

@@ -489,8 +489,11 @@ std::vector<tr_block_span_t> Wishlist::Impl::next(
blocks.reserve(n_wanted_blocks); blocks.reserve(n_wanted_blocks);
for (auto const& candidate : candidates_) for (auto const& candidate : candidates_)
{ {
auto const n_added = std::size(blocks);
TR_ASSERT(n_added <= n_wanted_blocks);
// do we have enough? // do we have enough?
if (std::size(blocks) >= n_wanted_blocks) if (n_added >= n_wanted_blocks)
{ {
break; break;
} }
@@ -502,15 +505,8 @@ std::vector<tr_block_span_t> Wishlist::Impl::next(
} }
// walk the blocks in this piece that we don't have or not requested // walk the blocks in this piece that we don't have or not requested
for (auto it = std::rbegin(candidate.unrequested), end = std::rend(candidate.unrequested); it != end; ++it) auto const n_to_add = std::min(std::size(candidate.unrequested), n_wanted_blocks - n_added);
{ std::copy_n(std::rbegin(candidate.unrequested), n_to_add, std::back_inserter(blocks));
if (std::size(blocks) >= n_wanted_blocks)
{
break;
}
blocks.emplace_back(*it);
}
} }
// Ensure the list of blocks are sorted // Ensure the list of blocks are sorted