fix: silence some sonarcloud warnings (#1493)

* refactor: add null ptr check in initPeerRow()

* refactor: add a nullptr gurad in icon_cache_get_mime_type_icon

* chore: silence two "break notreached" warnings

* chore: silence sonarcloud html warnings

* chore: silence sonarcloud uninitialized var warning

* chore: silence sonarcloud nullptr warning
This commit is contained in:
Charles Kerr
2020-10-31 16:23:43 -05:00
committed by GitHub
parent 973e63d897
commit e59fe7daaf
19 changed files with 74 additions and 62 deletions

View File

@@ -1,4 +1,5 @@
<html>
<!DOCTYPE html>
<html lang="en">
<head>
<META http-equiv="Content-Type" content="text/html; charset=utf-8" />
@@ -37,15 +38,15 @@
<div class="pagetitle">
<h1>Transmission crashed, what should I do? </h1>
</div>
<p>Post the crash log on the <a href="https://forum.transmissionbt.com/viewforum.php?f=4">support forums</a> so that the issue can be fixed as quickly as possible. Crash logs are held in <i>~/Library/Logs/CrashReporter/</i>.
<p>Post the crash log on the <a href="https://forum.transmissionbt.com/viewforum.php?f=4">support forums</a> so that the issue can be fixed as quickly as possible. Crash logs are held in <em>~/Library/Logs/CrashReporter/</em>.
<p>If your torrents' progress are incorrect when you reopen Transmission (e.g. they are starting from 0%) then you should manually recheck them. <a href="check.html">Click here</a> for instructions.
<p>
<div class="pagetitle">
<h1>What do the colors mean in the pieces box? </h1>
</div>
<p><font color="blue">Blue</font>: we have this piece - lighter shades of blue (progress only) indicate incomplete pieces <br>
<font color="green">Green</font>: connected peers have this piece (available only) - the darker the green, the more there are <br>
<font color="gray">White</font>: no connected peers have this piece (available) or we do not have any of this piece (progress) <br>
<p><span style="color: blue">Blue</span>: we have this piece - lighter shades of blue (progress only) indicate incomplete pieces <br>
<span style="color: green">Green</span>: connected peers have this piece (available only) - the darker the green, the more there are <br>
<span style="color: gray">White</span>: no connected peers have this piece (available) or we do not have any of this piece (progress) <br>
<p>
<div class="pagetitle">
@@ -65,11 +66,11 @@
<div class="pagetitle">
<h1>What do the stats in the Activity tab of the Inspector mean? </h1>
</div>
<p> <i>Have</i> is the sum of verified and unverified data. The <i>Verified</i> amount, in brackets, is how much checksum-verified data you have downloaded.<br>
<i>Downloaded</i> is all the data you have downloaded. <br>
<i>Uploaded</i> is all of the data you have uploaded. <br>
<i>Failed DL</i> is data that failed our checksum test and needs to be downloaded again. <br>
<i>Ratio</i> is the ratio of download data to uploaded data.
<p> <em>Have</em> is the sum of verified and unverified data. The <em>Verified</em> amount, in brackets, is how much checksum-verified data you have downloaded.<br>
<em>Downloaded</em> is all the data you have downloaded. <br>
<em>Uploaded</em> is all of the data you have uploaded. <br>
<em>Failed DL</em> is data that failed our checksum test and needs to be downloaded again. <br>
<em>Ratio</em> is the ratio of download data to uploaded data.
<p>
<div class="pagetitle">
<h1>What does the 'Tracker' tab mean in the Inspector? </h1>