Transmission/transmission
1
0
Fork 0
mirror of https://github.com/transmission/transmission.git synced 2026-04-19 16:31:13 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: silence some sonarcloud warnings (#1493)

Browse Source 
* refactor: add null ptr check in initPeerRow()

* refactor: add a nullptr gurad in icon_cache_get_mime_type_icon

* chore: silence two "break notreached" warnings

* chore: silence sonarcloud html warnings

* chore: silence sonarcloud uninitialized var warning

* chore: silence sonarcloud nullptr warning
This commit is contained in:
Charles Kerr
2020-10-31 16:23:43 -05:00
committed by GitHub
parent 973e63d897
commit e59fe7daaf
19 changed files with 74 additions and 62 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
macosx/TransmissionHelp/html/Speed.html
View File

@@ -1,4 +1,5 @@
<html>
<!DOCTYPE html>
<html lang="en">
<head>
<META http-equiv="Content-Type" content="text/html; charset=utf-8" />
@@ -28,7 +29,7 @@
<li>Make sure you cap your upload speed, so that it isn't flooded. A good rule of thumb is about 60-70% of your maximum upload bandwidth. This can be adjusted in Preferences -> Bandwidth, or in real time using the Action menu.
<div summary="To do this" class="taskbox">
<p>eg. If your upload connection is 256 Kilobits/sec, then you should cap it at 21 KB/sec ((<b>256</b> / 8) * 0.66 = <b>21</b>).
<p>eg. If your upload connection is 256 Kilobits/sec, then you should cap it at 21 KB/sec ((<strong>256</strong> / 8) * 0.66 = <strong>21</strong>).
</div>
</li>
@@ -37,7 +38,7 @@
To avoid spreading your upload too thinly, a good rule of thumb is to have at least 128 KBit/sec of upload bandwidth for every torrent you wish to run simultaneously.
<div summary="To do this" class="taskbox">
<p>eg. If your upload bandwidth is 256 KBit/sec, then you should only have two (<b>256</b>/128 = <b>2</b>) downloading transfers in the queue.
<p>eg. If your upload bandwidth is 256 KBit/sec, then you should only have two (<strong>256</strong>/128 = <strong>2</strong>) downloading transfers in the queue.
</div>
</li>
</ol>
@@ -46,4 +47,4 @@
</div>
</body>
</html>
</html>