Transmission/transmission
1
0
Fork 0
mirror of https://github.com/transmission/transmission.git synced 2025-12-19 18:08:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix issues reported by clang-tidy misc checks (GTK client) (#4167)

Browse Source 
* Fix `misc-const-correctness` clang-tidy issues

* Fix `misc-no-recursion` clang-tidy issues

* Extend clang-tidy configuration
This commit is contained in:
Mike Gelfand
2022-11-14 17:22:38 +01:00
committed by GitHub
parent caefebd102
commit f8d981349e
6 changed files with 88 additions and 58 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
gtk/Session.cc
View File

@@ -942,7 +942,7 @@ bool is_torrent_active(tr_stat const* st)
void Session::add_torrent(tr_torrent* tor, bool do_notify)
{
ScopedModelSortBlocker disable_sort(*impl_->get_model().get());
ScopedModelSortBlocker const disable_sort(*impl_->get_model().get());
impl_->add_torrent(tor, do_notify);
}
@@ -1032,7 +1032,7 @@ int Session::Impl::add_ctor(tr_ctor* ctor, bool do_prompt, bool do_notify)
if (!do_prompt)
{
ScopedModelSortBlocker disable_sort(*sorted_model_.get());
ScopedModelSortBlocker const disable_sort(*sorted_model_.get());
add_torrent(create_new_torrent(ctor), do_notify);
tr_ctorFree(ctor);
return 0;
@@ -1260,7 +1260,7 @@ void Session::load(bool force_paused)
auto const n_torrents = tr_sessionLoadTorrents(session, ctor);
tr_ctorFree(ctor);
ScopedModelSortBlocker disable_sort(*impl_->get_model().get());
ScopedModelSortBlocker const disable_sort(*impl_->get_model().get());
auto torrents = std::vector<tr_torrent*>{};
torrents.resize(n_torrents);