Transmission/transmission
1
0
Fork 0
mirror of https://github.com/transmission/transmission.git synced 2025-12-24 12:28:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: remove unused vars, code simplify and minor optimize (#4172)

Browse Source
This commit is contained in:
Herman Semenov
2022-11-19 15:46:03 +00:00
committed by GitHub
parent 292b092f54
commit ffd5e6bf50
8 changed files with 8 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
libtransmission/bandwidth.cc
View File

@@ -144,10 +144,11 @@ void tr_bandwidth::allocateBandwidth(
tr_priority_t const priority = std::max(parent_priority, this->priority_); tr_priority_t const priority = std::max(parent_priority, this->priority_);
/* set the available bandwidth */ /* set the available bandwidth */
if (this->band_[dir].is_limited_) auto bandwidth = &this->band_[dir];
if (bandwidth->is_limited_)
{ {
uint64_t const next_pulse_speed = this->band_[dir].desired_speed_bps_; uint64_t const next_pulse_speed = bandwidth->desired_speed_bps_;
this->band_[dir].bytes_left_ = next_pulse_speed * period_msec / 1000U; bandwidth->bytes_left_ = next_pulse_speed * period_msec / 1000U;
} }
/* add this bandwidth's peer, if any, to the peer pool */ /* add this bandwidth's peer, if any, to the peer pool */

2
libtransmission/watchdir.cc
View File

@@ -111,8 +111,6 @@ void BaseWatchdir::processFile(std::string_view basename)
void BaseWatchdir::scan() void BaseWatchdir::scan()
{ {
auto new_dir_entries = std::set<std::string>{};
tr_error* error = nullptr; tr_error* error = nullptr;
auto const dir = tr_sys_dir_open(dirname_.c_str(), &error); auto const dir = tr_sys_dir_open(dirname_.c_str(), &error);
if (dir == TR_BAD_SYS_DIR) if (dir == TR_BAD_SYS_DIR)

2
qt/IconCache.cc
View File

@@ -65,7 +65,7 @@ QIcon IconCache::guessMimeIcon(QString const& filename, QIcon fallback) const
if (icon.isNull()) if (icon.isNull())
{ {
icon = fallback; icon = std::move(fallback);
} }
return icon; return icon;

1
qt/Prefs.cc
View File

@@ -197,7 +197,6 @@ bool isValidUtf8(QByteArray const& byteArray)
auto const* const codec = QTextCodec::codecForName("UTF-8"); auto const* const codec = QTextCodec::codecForName("UTF-8");
auto state = QTextCodec::ConverterState{}; auto state = QTextCodec::ConverterState{};
auto const text = codec->toUnicode(byteArray.constData(), byteArray.size(), &state);
return state.invalidChars == 0; return state.invalidChars == 0;
#endif #endif

2
qt/StyleHelper.cc
View File

@@ -5,7 +5,7 @@
#include "StyleHelper.h" #include "StyleHelper.h"
QIcon::Mode StyleHelper::getIconMode(QStyle::State state) QIcon::Mode StyleHelper::getIconMode(QStyle::State const& state)
{ {
if (!state.testFlag(QStyle::State_Enabled)) if (!state.testFlag(QStyle::State_Enabled))
{ {

2
qt/StyleHelper.h
View File

@@ -11,5 +11,5 @@
class StyleHelper class StyleHelper
{ {
public: public:
static QIcon::Mode getIconMode(QStyle::State state); static QIcon::Mode getIconMode(QStyle::State const& state);
}; };

4
qt/Torrent.h
View File

@@ -112,9 +112,7 @@ private:
tr_sha1_digest_t data_ = {}; tr_sha1_digest_t data_ = {};
public: public:
TorrentHash() TorrentHash() = default;
{
}
explicit TorrentHash(tr_sha1_digest_t const& data) explicit TorrentHash(tr_sha1_digest_t const& data)
: data_{ data } : data_{ data }

2
tests/libtransmission/magnet-metainfo-test.cc
View File

@@ -93,8 +93,6 @@ TEST(MagnetMetainfo, magnetParse)
TEST(WebUtilsTest, parseMagnetFuzzRegressions) TEST(WebUtilsTest, parseMagnetFuzzRegressions)
{ {
auto buf = std::vector<char>{};
static auto constexpr Tests = std::array<std::string_view, 1>{ static auto constexpr Tests = std::array<std::string_view, 1>{
"UICOl7RLjChs/QZZwNH4sSQwuH890UMHuoxoWBmMkr0=", "UICOl7RLjChs/QZZwNH4sSQwuH890UMHuoxoWBmMkr0=",
}; };