* fix: warning: declaration shadows a variable in the global namespace [clang-diagnostic-shadow]
* fix: warning: use 'contains' to check for membership [readability-container-contains]
* fix: warning: variable gl_confdir can be made static or moved into an anonymous namespace to enforce internal linkage [misc-use-internal-linkage]
* warning: function 'TorrentFilter::match_mode' has a definition with different parameter names [readability-inconsistent-declaration-parameter-name]
* build: add sigslot dependency
* refactor: use sigslot for tr::Blocklists
* refactor: use sigslot for torrent, peer-mgr, wishlist
* refactor: remove tr::SimpleObservable
* chore: make lint happy
warning: method 'make_wishlist' can be made static [readability-convert-member-functions-to-static]
warning: invalid case style for function 'make_wishlist' [readability-identifier-naming]
warning: do not declare C-style arrays, use std::array<> instead [cppcoreguidelines-avoid-c-arrays,hicpp-avoid-c-arrays,modernize-avoid-c-arrays]
* refactor: remove unused forward declaration of tr_peer
* chore: remove slop
* refactor: Blocklist::observe_changes() now returns a scoped connection
* build: use transmission/sigslot fork
* refactor: copyediting
* refactor: fix cyclical dependency loop between Wishlist and tr_peerMgr::WishlistMediator
* bumping small from 0.2.0 to 0.2.1
bumping libdeflate from 1.18 to 1.19
bumping utfcpp from 3.2.1 to 4.0.5
* rolling back `small` to allow building on NetBSD/amd64.
* keeping submodules on Transmission forks
* bumping `small` to allow building on NetBSD/amd64.
* refactor: add miniupnp 2.3.0 as a submodule
* refactor: remove miniupnpc submodule
* deps: specify the 2.3.0 branch
* build: point to miniupnp monorepo subdirectory miniupnpc
* Fix building miniupnp from Xcode
* fixed miniupnp updateminiupnpcstrings.sh usage
* updating to miniupnpc 2.2.6
* fix build for Windows
* code review: removing the header move
---------
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* Prefer `PROJECT_{SOURCE,BINARY}_DIR` to `CMAKE_` ones
* Extend use of 3rd-party dir vars to reduce duplication
* Fix typo in submodule repo name
* Remove `CURL::libcurl` target fallback
The target is always available since CMake 3.12, which is our current
minimum version.
* build: bump libdeflate snapshot to 1.17
* Link to static libdeflate
Disable shared library and gzip program (both unused)
* Use platform-specific libdeflate library name
Co-authored-by: Mike Gelfand <mikedld@users.noreply.github.com>
* Switch to a standalone ARC4 implementation
This frees us from expecting it being provided by one of the crypto
libraries we support, all of which deprecated and/or removed it at this
point.
Fixes: #1103Fixes: #1777
* Suppress lgtm warnings about RC4 being weak (we don't care)
