Commit Graph

4802 Commits

Author SHA1 Message Date
Mike Gelfand
bc380511db Modernize CMake code (ongoing refactoring) (#4507)
* Reformat CMake code

* Bump minimum CMake version to 3.12

* Add target sources separately via `target_source()`

* Make `tr_win32_app_info()` add target sources on its own

* Don't use `include_directories()`

* Don't use `add_definitions()`

* Limit use of `add_compile_options()`

* Move VDKQueue target declaration to a subdirectory

* Add `tr_disable_source_files_compile()` helper

* Add `tr_target_glib_resources()` helper

* Add `tr_gettext_msgfmt()` helper

* Enable AUTOUIC for Qt client

* Enable AUTORCC for Qt client

* Remove AUTO{MOC,RCC,UIC} source group overrides

* Add `tr_target_idl_files()` helper

* Move source group setup to `tr_qt_add_translation()`

* Add `tr_target_xib_files()` helper

* Prefer `target_sources()` to intermediate variables

* Use explicit visibility versions of `target_*()` commands

* Prefer genexes to conditions in `target_*()` commands

* Add `tr_allow_compile_if()` helper

* Leave only top-level `project()`, remove the rest

* Minor fixups

* Fixup Mac QL plugin install

* Fixup IDE target folders and source groups
2023-01-01 19:49:48 +00:00
Cœur
3777796ce2 fix: "Open Torrent Address" not remembering previous address (#4461) 2022-12-31 12:17:24 -06:00
Cœur
ecb04b4cb1 Fix BlockListDownloader unzipFrom (#4473) 2022-12-27 22:08:48 -06:00
SweetPPro
e40b3b05ba set selected torrentTableView backgroundstyle (#4458)
Fixes: #4375
2022-12-24 12:19:53 -06:00
SweetPPro
342ea650df refactor ActivityView (#4448)
Refactor based on suggestions from #4400.

Provides a fix which supercedes #4427.
2022-12-24 11:54:37 -06:00
SweetPPro
3d04dd6828 macOS - use autolayout in statistics view (#4460)
Fixes: #4459
2022-12-24 01:35:55 -06:00
Cœur
25cc7c0021 Add missing GroupTextCell.h (#4455) 2022-12-23 17:14:31 -06:00
Cœur
8a5260f24c Fixed DragOverlayWindow file icon and name (#4428)
* Fixed DragOverlayWindow file icon and name

* Fixed dragging for BitComet torrents
2022-12-22 20:07:45 -06:00
Cœur
1819e544b4 Addressed lockFocus is deprecated (#4441) 2022-12-22 16:37:10 -06:00
SweetPPro
d967de0c5b macOS remove defunct share code (#4440) 2022-12-22 15:44:46 -06:00
Cœur
e32cac98ce Add missing GroupPopUpButtonCell and PriorityPopUpButtonCell to CMakeLists.txt (#4417) 2022-12-21 20:01:52 -06:00
Cœur
db802afc4f Addressed various warnings (#4414) 2022-12-21 14:21:16 -06:00
Cœur
cc9bc748b0 Removed ToolbarSegmentedCell (#4418) 2022-12-21 11:13:12 -06:00
SweetPPro
5d5893036d fix: layout issues in macOS client torrent inspector window (#4366) 2022-12-16 12:27:37 -06:00
SweetPPro
078dc8bd08 removed redunant code from AddMagnetWindow (#4374) 2022-12-16 00:04:59 -06:00
Cœur
578099bf1c Replaced deprecated NSURLDownload with NSURLSessionDownloadTask. (#4308) 2022-12-15 18:19:27 -06:00
Cœur
30d3ce872f feat: move the filter bar's search field one pixel up (#4367) 2022-12-14 20:44:21 -06:00
Cœur
fe1ee80342 Sorting by size should be instead by sizeWhenDone (#4365) 2022-12-14 11:46:32 -06:00
Cœur
0b0f8704d6 build: move CMAKE_OSX_DEPLOYMENT_TARGET FATAL_ERROR next to its default setting (#4323) 2022-12-14 10:11:32 -06:00
Cœur
84c0001e2f Fixed archivedDataWithRootObject: is deprecated (#4310) 2022-12-14 00:42:49 -06:00
Cœur
ec1e679395 Fixed memory leak in BlocklistDownloader (#4309) 2022-12-12 15:12:04 +00:00
SweetPPro
9f2a981c8c fix: empty tableview rows on macOS (#4333) 2022-12-09 13:06:00 -06:00
Dmitry Antipov
bf6c80ae35 refactor, ci: switch clang-format to LLVM 15 (#4297)
Bump required clang-format version to 15
2022-12-02 09:57:50 -06:00
A Cœur
e4276a3018 Use NSIndexSet getIndexes:maxCount:inIndexRange: directly (#4179) 2022-11-27 23:10:03 -06:00
Daniil Subbotin
9a6fbc9ced Fix deleting previously selected torrent when trying to clear search field using Command + Delete (#4245)
* Fix deleting previously selected torrent when trying to clear search field using Command + Delete

Fixes #3599

* Fixes after code review

* Fixes after code review

* chore: make clang-format happy

Co-authored-by: Daniil Subbotin <d.subbotin@opends.tech>
2022-11-27 22:31:26 -06:00
Mike Gelfand
d381939267 Sync translations (#4247)
* Sync translations with code

* Sync translations with Transifex
2022-11-26 16:32:26 +00:00
A Cœur
ef2415293b we do not support LevelButtonLevelTrace (#4236) 2022-11-25 16:01:29 -06:00
A Cœur
6b861806a6 Fix building with cmake on macOS Mojave (#4234) 2022-11-24 11:20:48 -06:00
A Cœur
3ecf0dfccd Fix "NSFilenamesPboardType is deprecated" (#4221) 2022-11-23 17:09:32 -06:00
A Cœur
b612020576 Support UserNotifications framework (#3040) 2022-11-23 13:47:56 -06:00
A Cœur
191c6d1402 fix: SecKeychain is deprecated (#4190) 2022-11-21 23:14:10 -06:00
A Cœur
d26db72d7e Fix "Implicit conversion loses integer precision" (#4194) 2022-11-21 10:19:45 -06:00
A Cœur
292b092f54 Fix hang in CSBackupSetItemExcluded (#4208) 2022-11-19 08:50:13 -06:00
A Cœur
a152d0f6d8 Appropriate and improve VDKQueue (#4202) 2022-11-18 13:53:36 -06:00
A Cœur
6fcdb526c7 Fix crash on torrent filenames in non-UTF-8 encoding (#4144) 2022-11-18 10:03:25 -06:00
A Cœur
7a2d2ff0cf Fix cmake CFBundleVersion and LSMinimumSystemVersion (#4185)
* Fix cmake CFBundleVersion and LSMinimumSystemVersion

* code review: use CMAKE_OSX_DEPLOYMENT_TARGET
2022-11-16 13:40:19 +00:00
A Cœur
befeafbcfe hook action in the xib (#4135) 2022-11-15 10:50:16 -06:00
A Cœur
bde1359d5d Adopt localizedStringWithFormat for displayed quantities (#4109)
* Adopt localizedStringWithFormat for displayed quantities

* xib internationalization support is done
2022-11-14 18:30:03 +00:00
A Cœur
caefebd102 remove duplicate Portuguese (#4141) 2022-11-14 15:53:57 +00:00
Mike Gelfand
c9debcfd48 Sync translations (#4161)
* Sync translations with code

* Sync translations with Transifex
2022-11-14 09:48:42 +00:00
A Cœur
855b782604 Accessibility description for images (#4149) 2022-11-13 21:39:34 -06:00
A Cœur
b322971f6a Fix create torrent out-of-range piece size (#4145) 2022-11-13 13:53:25 -06:00
A Cœur
ff2e544a6b Fix "Block implicitly retains 'self'" (#4132) 2022-11-13 13:10:58 -06:00
A Cœur
d8e7664f2b Fix "terminating with uncaught exception of type std::out_of_range: vector" (#4138) 2022-11-13 12:00:04 -06:00
A Cœur
0ecf084e0f ignoring deprecation warning on NSUnarchiver (#4113) 2022-11-13 10:54:22 -06:00
Mike Gelfand
9e185a17f2 Fix default/minimum CMAKE_OSX_DEPLOYMENT_TARGET handling (#4156)
* Fix default/minimum `CMAKE_OSX_DEPLOYMENT_TARGET` handling

* Drop explicit `CMAKE_OSX_DEPLOYMENT_TARGET` in GHA CI

Rely on minimum set in top-level CMakeLists.txt instead.
2022-11-13 12:02:07 +00:00
Mike Gelfand
43acd7e3e4 Remove Xcode project in favor of CMake (#4147)
* Compile images into an assets catalog

* Optionally sign resulting Mac bundle

* Move 3rd-party/utility/test targets to their own folders

* Enable ARC via compile options unconditionally

* Install base and localized resources into correct directory

This seems like a Xcode quirk: if subdirectory containing the resource file
matches the destination directory name (and probably if there's more than one
resource file being installed there), the resulting folder structure then
contains an extra subdirectory, i.e. Resources/dirname/dirname/resname.

* Group source files for better structure in IDEs (Xcode, VS)

* Remove Xcode project

Using Xcode is still possible via "Xcode" CMake generator.

* Use ad-hoc signature if one is not specified

* Always use ad-hoc signature on link, leave proper signing to CPack

* Install localized resources into correct directory (QL plugin)

* Don't include CTest (we don't use additional targets it provides)

* Revert "Remove Xcode project"

This reverts commit dc069f654f.
2022-11-12 20:01:57 +00:00
A Cœur
48e42ac71e Fix NSURLConnection is deprecated - Use NSURLSession (#4112) 2022-11-11 21:29:48 -06:00
A Cœur
69fda72a8b refactor: remove superfluous interface declarations (#4110) 2022-11-08 23:36:53 -06:00
Gary Elshaw
c32161f7ca feat: place upload above download in macOS badge (#4055) 2022-11-07 13:21:49 -06:00