Commit Graph

985 Commits

Author SHA1 Message Date
Mike Gelfand
352fa985b2 Update pieces label on source change even if piece size doesn't change (#6516)
Label update is made when slider changes its value, and on source change
slider value is being set to a newly calculated, but not necessarily
different from the previous one, value. This means that the slider
change signal may not be emitted, in which case label continues to show
previous text, including "No source selected", which is misleading.
2024-01-14 11:12:42 -06:00
Charles Kerr
4b10f67ad1 fix: only append '.added' suffix to watchdir files (#5705) 2023-12-03 15:46:45 -06:00
Gary Elshaw
b8235ea317 fix: improve resolution of Qt app icon (#5570) 2023-08-21 13:32:40 -05:00
Dmitry Antipov
47a3a92a0e fix: Qt 6.5 deprecation warning (#5552) 2023-06-19 16:59:12 -05:00
Charles Kerr
3aabde310c chore: improve lossless compression of png files (#5586) 2023-06-10 19:02:37 -05:00
Charles Kerr
a7c98b3d5f fix: does not trash added torrent files when asked (#5505) 2023-05-08 16:22:11 -05:00
Charles Kerr
2184095871 fix: show magnet name in compact mode (#5491) 2023-05-07 13:05:00 -05:00
Mike Gelfand
411b66cf88 fix: use user-preferred locale (#5444)
* Use user-preferred locale

Previous fix adding `L` format specifier was correct but only fixed half
of the problem, as C++ locale is set up to be "C" by default. GTK client
used to call `setlocale(LC_ALL, "")` to set up user-preferred locale
which only affected C functions and `std::locale` (used by libfmt) was
unaware of those changes.

Apply the fix to all the binaries since they're all doing some sort of
output to the user and calling libtransmission helpers, as well as using
libfmt directly.

* Improve libtransmission's json-test

Set the locale C++ way to avoid any sort of inconsistencies, and also
restore it to the old one once finished testing.

* Improve transmission-show test runner script

Quote outputs to avoid CMake error about `message()` being called with
no arguments. Capture stderr to the same output file. Fallback to `git
diff` if `diff` wasn't found. A few other minor changes.
2023-04-27 09:11:06 -05:00
Charles Kerr
c37b297b25 fix: minor warnings (#5409)
* chore: fix readability-qualified-auto warnings

* chore: fix clang-analyzer-core.uninitialized.Branch warning

* fix: collision of key 'ERROR' in transmission-qt

* chore: silence -Wshadow warning

* chore: silence warning C4100: 'iter': unreferenced formal parameter

* chore: fix warning C4127: conditional expression is constant warning
2023-04-20 14:16:09 -05:00
Mike Gelfand
4c8037afee Sync translations (#5391) 2023-04-14 03:00:44 +01:00
Charles Kerr
25f38d5ff3 fix: wrong tier value in torrent get tracker stat response (#5274) 2023-03-21 20:23:08 -05:00
Charles Kerr
f5a24862db fix: FTBFS in Ubuntu 20.04 / Qt 5.13 (#5238) 2023-03-16 18:59:31 -05:00
Charles Kerr
be77226d6b fix: update Torrent::ratio() to match #2770 (#5193) 2023-03-10 14:32:12 -06:00
Mike Gelfand
8cdb6ec798 chore: sync translations (#5182) 2023-03-08 23:29:22 -06:00
Charles Kerr
8fc904617b fix: correctly handle batch-adding trackers to multiple torrents (#5122) 2023-03-02 00:33:49 -06:00
Charles Kerr
d21a3b622a fix: 4981 open folder should open selected folder (#5115) 2023-03-01 15:57:23 -06:00
Charles Kerr
6a185634b0 fix: open-folder does not work in qt client (#4963) 2023-02-20 14:41:47 -06:00
Charles Kerr
2b3578512c fix: display correct tracker port in qt torrent-details (#4846) 2023-02-11 21:46:57 -06:00
Julien
4b8cfa2e57 chore: update copyrights to 2023 (#4834) 2023-02-11 14:49:42 -06:00
Dmitry Antipov
7eecd87034 fix: Qt 6 deprecation warnings (#4710) 2023-02-10 11:58:43 -06:00
Mike Gelfand
6a6ce4c7c0 Sync translations (#4729)
* Sync translations with code

* Sync translations with Transifex
2023-02-07 20:42:19 +00:00
Charles Kerr
b641906b13 fix: make torrent speed limit order consistent in prefs, details dialogs (#4677)
Fixes #988.
2023-01-26 22:11:35 -06:00
Nick
b5339273d0 quick fix: changed order of some session prefs (#4676) 2023-01-26 14:38:39 -06:00
anarcat
331e1699bc add remote HTTPS support to Qt GUI (#4622) 2023-01-26 00:24:04 -06:00
Gary Elshaw
c7b9eaff12 Remove 'Message Log' item from sys tray (#4656)
Fixes: #3773
2023-01-24 18:52:52 -06:00
Charles Kerr
977a190646 fix: msvc warnings (#4651)
* fix: C4189 local variable is initialized but not referenced

* fix: C4706 assignment within conditional expression

* fix: C4018 signed/unsigned mismatch

* fix: warning C4996 High-DPI scaling is always enabled.

* fix: C4996: QApplication::fontMetrics() is deprecated

eed5514eaf
2023-01-23 19:24:52 -06:00
Mike Gelfand
240414f776 Sync translations (#4535)
* Sync translations with code

* Fix translations with Transifex
2023-01-04 16:32:21 -06:00
Mike Gelfand
57e6b06921 Modernize CMake code (ongoing refactoring) (#4515)
* Use imported CMake target for CURL

* Use imported CMake target for fmtlib

* Use imported CMake target for WideInteger

* Use imported CMake target for FastFloat

* Use imported CMake target for UtfCpp

* Use imported CMake target for Threads

* Use imported CMake target for Iconv

* Use imported CMake target for crypto backend

* Use imported CMake target for GTK

* Use imported CMake target for Qt

* Use imported CMake target for deflate

* Use imported CMake target for libevent

* Use imported CMake target for natpmp

* Use imported CMake target for miniupnpc

* Use imported CMake target for dht

* Use imported CMake target for psl

* Use imported CMake target for libutp

* Use imported CMake target for libb64

* Use include directories from libtransmission target
2023-01-02 16:23:51 +00:00
Mike Gelfand
bc380511db Modernize CMake code (ongoing refactoring) (#4507)
* Reformat CMake code

* Bump minimum CMake version to 3.12

* Add target sources separately via `target_source()`

* Make `tr_win32_app_info()` add target sources on its own

* Don't use `include_directories()`

* Don't use `add_definitions()`

* Limit use of `add_compile_options()`

* Move VDKQueue target declaration to a subdirectory

* Add `tr_disable_source_files_compile()` helper

* Add `tr_target_glib_resources()` helper

* Add `tr_gettext_msgfmt()` helper

* Enable AUTOUIC for Qt client

* Enable AUTORCC for Qt client

* Remove AUTO{MOC,RCC,UIC} source group overrides

* Add `tr_target_idl_files()` helper

* Move source group setup to `tr_qt_add_translation()`

* Add `tr_target_xib_files()` helper

* Prefer `target_sources()` to intermediate variables

* Use explicit visibility versions of `target_*()` commands

* Prefer genexes to conditions in `target_*()` commands

* Add `tr_allow_compile_if()` helper

* Leave only top-level `project()`, remove the rest

* Minor fixups

* Fixup Mac QL plugin install

* Fixup IDE target folders and source groups
2023-01-01 19:49:48 +00:00
Mike Gelfand
3510439c78 Fix progress bars positioning in Qt client on Mac (#4489)
This is a workaround for QTBUG-67830, where progress bars seem to be drawn
regardless of style option's rect top-left coordinates.
2022-12-28 14:46:23 +00:00
Charles Kerr
1402cb2949 refactor: add TR_CONSTEXPR20 to make future C++20 migration easier (#4457) 2022-12-23 15:21:40 -06:00
Mike Gelfand
e694c3e3a0 Use C++ (not C) warning flags for GTK client (#4395)
Use the opportunity to reduce duplication.
2022-12-18 01:02:03 +00:00
Charles Kerr
59335eac03 fix: sonarcloud cpp:S6004 (#4270)
reduce scope of variables by using if-based initializer
2022-11-28 21:03:28 -06:00
Charles Kerr
4adda4dc1e fix: sonarcloud cpp:S6005 (#4268) 2022-11-28 18:26:03 -06:00
Charles Kerr
e0a44a1e5d refactor: remove references to FD_SETSIZE (#4263) 2022-11-28 14:36:39 -06:00
Charles Kerr
49393daf01 refactor: use std::optional.value_or() (#4255) 2022-11-27 14:56:34 -06:00
Mike Gelfand
d381939267 Sync translations (#4247)
* Sync translations with code

* Sync translations with Transifex
2022-11-26 16:32:26 +00:00
Charles Kerr
554ba06ae2 fix: coverity warnings, sonarcloud code smells (#4232) 2022-11-24 10:17:02 -06:00
Charles Kerr
29090d6590 fixup! refactor: remove unused vars, code simplify and minor optimize (#4172) (#4230)
set the converter state in isValidUtf8()
2022-11-24 01:12:01 -06:00
Herman Semenov
ffd5e6bf50 refactor: remove unused vars, code simplify and minor optimize (#4172) 2022-11-19 09:46:03 -06:00
Charles Kerr
22c14c9266 fix: sonarcloud warnings (#4180) 2022-11-15 10:25:12 -06:00
Mike Gelfand
c9debcfd48 Sync translations (#4161)
* Sync translations with code

* Sync translations with Transifex
2022-11-14 09:48:42 +00:00
Mike Gelfand
43acd7e3e4 Remove Xcode project in favor of CMake (#4147)
* Compile images into an assets catalog

* Optionally sign resulting Mac bundle

* Move 3rd-party/utility/test targets to their own folders

* Enable ARC via compile options unconditionally

* Install base and localized resources into correct directory

This seems like a Xcode quirk: if subdirectory containing the resource file
matches the destination directory name (and probably if there's more than one
resource file being installed there), the resulting folder structure then
contains an extra subdirectory, i.e. Resources/dirname/dirname/resname.

* Group source files for better structure in IDEs (Xcode, VS)

* Remove Xcode project

Using Xcode is still possible via "Xcode" CMake generator.

* Use ad-hoc signature if one is not specified

* Always use ad-hoc signature on link, leave proper signing to CPack

* Install localized resources into correct directory (QL plugin)

* Don't include CTest (we don't use additional targets it provides)

* Revert "Remove Xcode project"

This reverts commit dc069f654f.
2022-11-12 20:01:57 +00:00
Charles Kerr
250e055c1d fix: warnings from clang tidy sonarcloud coverity (#4143) 2022-11-12 09:53:09 -06:00
Charles Kerr
450f1dcadc refactor: extract tr_buffer class from tr_peerIo (#3986) 2022-10-19 11:42:08 -05:00
Mike Gelfand
9dd4454729 Sync translations (#3968)
* Sync translations with code

* Migrate to Go-based Transifex client version

* Sync translations with Transifex
2022-10-15 21:21:13 +03:00
Mike Gelfand
f1f55cc3df Sync translations (#3939)
* Sync translations with code

* Sync translations with Transifex

* Remove Mac menu title that isn't displayed and shouldn't be translated

* Add context to logging level strings in GTK client

* Use "µTP" consistently in code

* Use ellipsis instead of three docs in Qt client strings

* Close HTML tags in blocklist-related strings

* Remove trailing space from a translatable string in Qt client

* Add missing plural forms for English strings in Qt client

* Fix spelling: metaInfo -> metainfo
2022-10-11 18:39:41 +03:00
Mike Gelfand
b0de4b7a89 Add build job based on Fedora 37 (#3921)
This allows to test against GTK 4 and Qt 6.

Changes to CMakeLists.txt files are non-functional and are meant to
trigger the components rebuild, nothing more.
2022-10-09 12:13:02 +03:00
Mike Gelfand
1b641b660e Sync translations (#3845)
* Sync translations with code

* Sync translations with Transifex
2022-09-24 17:19:25 +01:00
Charles Kerr
dd12fd010a chore: iwyu headers (#3833) 2022-09-21 18:34:18 -05:00