1
0
mirror of https://github.com/home-assistant/core.git synced 2026-04-02 00:20:30 +01:00

Fix Huum exception translations (#166778)

Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This commit is contained in:
mettolen
2026-03-30 15:55:45 +03:00
committed by GitHub
parent 49c3376c95
commit 20b284d0e9
5 changed files with 17 additions and 9 deletions

View File

@@ -2,7 +2,6 @@
from __future__ import annotations
import logging
from typing import Any
from huum.const import SaunaStatus
@@ -18,12 +17,10 @@ from homeassistant.core import HomeAssistant
from homeassistant.exceptions import HomeAssistantError
from homeassistant.helpers.entity_platform import AddConfigEntryEntitiesCallback
from .const import CONFIG_DEFAULT_MAX_TEMP, CONFIG_DEFAULT_MIN_TEMP
from .const import CONFIG_DEFAULT_MAX_TEMP, CONFIG_DEFAULT_MIN_TEMP, DOMAIN
from .coordinator import HuumConfigEntry, HuumDataUpdateCoordinator
from .entity import HuumBaseEntity
_LOGGER = logging.getLogger(__name__)
PARALLEL_UPDATES = 1
@@ -113,5 +110,7 @@ class HuumDevice(HuumBaseEntity, ClimateEntity):
try:
await self.coordinator.huum.turn_on(temperature)
except (ValueError, SafetyException) as err:
_LOGGER.error(str(err))
raise HomeAssistantError(f"Unable to turn on sauna: {err}") from err
raise HomeAssistantError(
translation_domain=DOMAIN,
translation_key="unable_to_turn_on",
) from err

View File

@@ -56,5 +56,6 @@ class HuumDataUpdateCoordinator(DataUpdateCoordinator[HuumStatusResponse]):
return await self.huum.status()
except (Forbidden, NotAuthenticated) as err:
raise ConfigEntryAuthFailed(
"Could not log in to Huum with given credentials"
translation_domain=DOMAIN,
translation_key="auth_failed",
) from err

View File

@@ -62,7 +62,7 @@ rules:
status: exempt
comment: All entities are core functionality.
entity-translations: done
exception-translations: todo
exception-translations: done
icon-translations: done
reconfiguration-flow: todo
repair-issues:

View File

@@ -45,5 +45,13 @@
"name": "[%key:component::sensor::entity_component::humidity::name%]"
}
}
},
"exceptions": {
"auth_failed": {
"message": "Could not log in to Huum with the given credentials."
},
"unable_to_turn_on": {
"message": "Unable to turn on the sauna."
}
}
}

View File

@@ -132,7 +132,7 @@ async def test_turn_on_safety_exception(
mock_huum_client.turn_on.side_effect = SafetyException("Door is open")
mock_huum_client.status.return_value.status = SaunaStatus.ONLINE_HEATING
with pytest.raises(HomeAssistantError, match="Unable to turn on sauna"):
with pytest.raises(HomeAssistantError, match="Unable to turn on the sauna"):
await hass.services.async_call(
CLIMATE_DOMAIN,
SERVICE_SET_TEMPERATURE,