Home-Assistant/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2026-04-01 16:09:02 +01:00
Code Activity

Fix ToDo List Intents item casing (#160177)

Browse Source 
Co-authored-by: Erik Montnemery <erik@montnemery.com>
Co-authored-by: Artur Pragacz <49985303+arturpragacz@users.noreply.github.com>
This commit is contained in:
Daniel Jolly
2026-04-01 10:28:59 -04:00
committed by GitHub
parent 8fe09e1837
commit 524c2129eb
2 changed files with 14 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
homeassistant/components/todo/intent.py
View File

@@ -91,7 +91,7 @@ class ListAddItemIntentHandler(ListBaseIntentHandler):
# Add to list
await target_list.async_create_todo_item(
TodoItem(summary=item, status=TodoItemStatus.NEEDS_ACTION)
TodoItem(summary=item.capitalize(), status=TodoItemStatus.NEEDS_ACTION)
)
@@ -108,9 +108,9 @@ class ListCompleteItemIntentHandler(ListBaseIntentHandler):
matching_item = None
for todo_item in target_list.todo_items or ():
if (
item in (todo_item.uid, todo_item.summary)
and todo_item.status == TodoItemStatus.NEEDS_ACTION
):
item == todo_item.uid
or item.casefold() == (todo_item.summary or "").casefold()
) and todo_item.status == TodoItemStatus.NEEDS_ACTION:
matching_item = todo_item
break
if not matching_item or not matching_item.uid:
@@ -140,7 +140,10 @@ class ListRemoveItemIntentHandler(ListBaseIntentHandler):
# Find item in list
matching_item = None
for todo_item in target_list.todo_items or ():
if item in (todo_item.uid, todo_item.summary):
if (
item == todo_item.uid
or item.casefold() == (todo_item.summary or "").casefold()
):
matching_item = todo_item
break
if not matching_item or not matching_item.uid:

12
tests/components/todo/test_intent.py
View File

@@ -66,7 +66,7 @@ async def test_add_item_intent(
assert len(entity1.items) == 1
assert len(entity2.items) == 0
assert entity1.items[0].summary == "beer" # summary is trimmed
assert entity1.items[0].summary == "Beer" # summary is trimmed and capitalized
assert entity1.items[0].status == TodoItemStatus.NEEDS_ACTION
entity1.items.clear()
@@ -82,7 +82,7 @@ async def test_add_item_intent(
assert len(entity1.items) == 0
assert len(entity2.items) == 1
assert entity2.items[0].summary == "cheese"
assert entity2.items[0].summary == "Cheese"
assert entity2.items[0].status == TodoItemStatus.NEEDS_ACTION
# List name is case insensitive
@@ -97,7 +97,7 @@ async def test_add_item_intent(
assert len(entity1.items) == 0
assert len(entity2.items) == 2
assert entity2.items[1].summary == "wine"
assert entity2.items[1].summary == "Wine"
assert entity2.items[1].status == TodoItemStatus.NEEDS_ACTION
# Should fail if lists are not exposed
@@ -187,8 +187,8 @@ async def test_complete_item_intent(
"""Test the complete item intent."""
entity1 = MockTodoListEntity(
[
TodoItem(summary="beer", uid="1", status=TodoItemStatus.NEEDS_ACTION),
TodoItem(summary="wine", uid="2", status=TodoItemStatus.NEEDS_ACTION),
TodoItem(summary="Beer", uid="1", status=TodoItemStatus.NEEDS_ACTION),
TodoItem(summary="Wine", uid="2", status=TodoItemStatus.NEEDS_ACTION),
]
)
entity1._attr_name = "List 1"
@@ -298,7 +298,7 @@ async def test_remove_item_intent(
"""Test the remove item intent."""
entity1 = MockTodoListEntity(
[
TodoItem(summary="beer", uid="1", status=TodoItemStatus.NEEDS_ACTION),
TodoItem(summary="Beer", uid="1", status=TodoItemStatus.NEEDS_ACTION),
TodoItem(summary="wine", uid="2", status=TodoItemStatus.NEEDS_ACTION),
TodoItem(summary="beer", uid="3", status=TodoItemStatus.COMPLETED),
]