1
0
mirror of https://github.com/home-assistant/core.git synced 2026-05-08 17:49:37 +01:00

Use runtime_data in rova integration (#167661)

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
epenet
2026-04-08 12:15:59 +02:00
committed by GitHub
parent 8994f501f1
commit 5be48affcf
4 changed files with 13 additions and 17 deletions
+5 -10
View File
@@ -5,19 +5,18 @@ from __future__ import annotations
from requests.exceptions import ConnectTimeout, HTTPError
from rova.rova import Rova
from homeassistant.config_entries import ConfigEntry
from homeassistant.const import Platform
from homeassistant.core import HomeAssistant
from homeassistant.exceptions import ConfigEntryError, ConfigEntryNotReady
from homeassistant.helpers.issue_registry import IssueSeverity, async_create_issue
from .const import CONF_HOUSE_NUMBER, CONF_HOUSE_NUMBER_SUFFIX, CONF_ZIP_CODE, DOMAIN
from .coordinator import RovaCoordinator
from .coordinator import RovaConfigEntry, RovaCoordinator
PLATFORMS: list[Platform] = [Platform.SENSOR]
async def async_setup_entry(hass: HomeAssistant, entry: ConfigEntry) -> bool:
async def async_setup_entry(hass: HomeAssistant, entry: RovaConfigEntry) -> bool:
"""Set up ROVA from a config entry."""
api = Rova(
@@ -50,15 +49,11 @@ async def async_setup_entry(hass: HomeAssistant, entry: ConfigEntry) -> bool:
await coordinator.async_config_entry_first_refresh()
hass.data.setdefault(DOMAIN, {})[entry.entry_id] = coordinator
entry.runtime_data = coordinator
await hass.config_entries.async_forward_entry_setups(entry, PLATFORMS)
return True
async def async_unload_entry(hass: HomeAssistant, entry: ConfigEntry) -> bool:
async def async_unload_entry(hass: HomeAssistant, entry: RovaConfigEntry) -> bool:
"""Unload ROVA config entry."""
if unload_ok := await hass.config_entries.async_unload_platforms(entry, PLATFORMS):
hass.data[DOMAIN].pop(entry.entry_id)
return unload_ok
return await hass.config_entries.async_unload_platforms(entry, PLATFORMS)
+4 -2
View File
@@ -11,16 +11,18 @@ from homeassistant.util.dt import get_time_zone
from .const import DOMAIN, LOGGER
type RovaConfigEntry = ConfigEntry[RovaCoordinator]
EUROPE_AMSTERDAM_ZONE_INFO = get_time_zone("Europe/Amsterdam")
class RovaCoordinator(DataUpdateCoordinator[dict[str, datetime]]):
"""Class to manage fetching Rova data."""
config_entry: ConfigEntry
config_entry: RovaConfigEntry
def __init__(
self, hass: HomeAssistant, config_entry: ConfigEntry, api: Rova
self, hass: HomeAssistant, config_entry: RovaConfigEntry, api: Rova
) -> None:
"""Initialize."""
super().__init__(
+3 -4
View File
@@ -9,14 +9,13 @@ from homeassistant.components.sensor import (
SensorEntity,
SensorEntityDescription,
)
from homeassistant.config_entries import ConfigEntry
from homeassistant.core import HomeAssistant
from homeassistant.helpers.device_registry import DeviceEntryType, DeviceInfo
from homeassistant.helpers.entity_platform import AddConfigEntryEntitiesCallback
from homeassistant.helpers.update_coordinator import CoordinatorEntity
from .const import DOMAIN
from .coordinator import RovaCoordinator
from .coordinator import RovaConfigEntry, RovaCoordinator
ISSUE_PLACEHOLDER = {"url": "/config/integrations/dashboard/add?domain=rova"}
@@ -42,11 +41,11 @@ SENSOR_TYPES: tuple[SensorEntityDescription, ...] = (
async def async_setup_entry(
hass: HomeAssistant,
entry: ConfigEntry,
entry: RovaConfigEntry,
async_add_entities: AddConfigEntryEntitiesCallback,
) -> None:
"""Add Rova entry."""
coordinator: RovaCoordinator = hass.data[DOMAIN][entry.entry_id]
coordinator = entry.runtime_data
assert entry.unique_id
unique_id = entry.unique_id
+1 -1
View File
@@ -6,7 +6,7 @@ import pytest
from requests import ConnectTimeout
from syrupy.assertion import SnapshotAssertion
from homeassistant.components.rova import DOMAIN
from homeassistant.components.rova.const import DOMAIN
from homeassistant.config_entries import ConfigEntryState
from homeassistant.const import Platform
from homeassistant.core import HomeAssistant