Home-Assistant/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2026-04-02 00:20:30 +01:00
Code Activity

Remove targets from intent response (#165434)

Browse Source 
Co-authored-by: Abílio Costa <abmantis@users.noreply.github.com>
This commit is contained in:
Artur Pragacz
2026-03-18 19:35:30 +01:00
committed by GitHub
parent b56e6d1ff7
commit 6ea9e9a161
20 changed files with 11 additions and 102 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
homeassistant/helpers/intent.py
View File

@@ -1371,7 +1371,6 @@ class IntentResponse:
self.reprompt: dict[str, dict[str, Any]] = {}
self.card: dict[str, dict[str, str]] = {}
self.error_code: IntentResponseErrorCode | None = None
self.intent_targets: list[IntentResponseTarget] = []
self.success_results: list[IntentResponseTarget] = []
self.failed_results: list[IntentResponseTarget] = []
self.matched_states: list[State] = []
@@ -1421,14 +1420,6 @@ class IntentResponse:
# Speak error message
self.async_set_speech(message)
@callback
def async_set_targets(
self,
intent_targets: list[IntentResponseTarget],
) -> None:
"""Set response targets."""
self.intent_targets = intent_targets
@callback
def async_set_results(
self,
@@ -1474,11 +1465,6 @@ class IntentResponse:
response_data["code"] = self.error_code.value
else:
# action done or query answer
response_data["targets"] = [
dataclasses.asdict(target) for target in self.intent_targets
]
# Add success/failed targets
response_data["success"] = [
dataclasses.asdict(target) for target in self.success_results
]

2
tests/components/anthropic/snapshots/test_conversation.ambr
View File

@@ -1245,8 +1245,6 @@
failed_results=list([
]),
intent=None,
intent_targets=list([
]),
language='en',
matched_states=list([
]),

12
tests/components/assist_pipeline/snapshots/test_pipeline.ambr
View File

@@ -112,8 +112,6 @@
]),
'success': list([
]),
'targets': list([
]),
}),
'language': 'en',
'response_type': 'action_done',
@@ -347,8 +345,6 @@
]),
'success': list([
]),
'targets': list([
]),
}),
'language': 'en',
'response_type': 'action_done',
@@ -579,8 +575,6 @@
]),
'success': list([
]),
'targets': list([
]),
}),
'language': 'en',
'response_type': 'action_done',
@@ -658,8 +652,6 @@
]),
'success': list([
]),
'targets': list([
]),
}),
'language': 'en',
'response_type': 'action_done',
@@ -712,8 +704,6 @@
]),
'success': list([
]),
'targets': list([
]),
}),
'language': 'en',
'response_type': 'action_done',
@@ -766,8 +756,6 @@
]),
'success': list([
]),
'targets': list([
]),
}),
'language': 'en',
'response_type': 'action_done',

2
tests/components/assist_pipeline/snapshots/test_websocket.ambr
View File

@@ -661,8 +661,6 @@
]),
'success': list([
]),
'targets': list([
]),
}),
'language': 'en',
'response_type': 'action_done',

3
tests/components/assist_satellite/test_intent.py
View File

@@ -65,7 +65,6 @@ async def test_broadcast_intent(
"type": intent.IntentResponseTargetType.ENTITY,
},
],
"targets": [],
},
"language": "en",
"response_type": "action_done",
@@ -98,7 +97,6 @@ async def test_broadcast_intent(
"type": intent.IntentResponseTargetType.ENTITY,
},
],
"targets": [],
},
"language": "en",
"response_type": "action_done",
@@ -130,7 +128,6 @@ async def test_broadcast_intent_excluded_domains(
"data": {
"failed": [],
"success": [], # no satellites
"targets": [],
},
"language": "en",
"response_type": "action_done",

2
tests/components/cloud/test_entity.py
View File

@@ -250,7 +250,7 @@ async def test_prepare_chat_for_generation_passes_messages_through(
"speech": {"plain": {"speech": "12:00 PM", "extra_data": None}},
"response_type": "action_done",
"speech_slots": {"time": datetime.time(12, 0)},
"data": {"targets": [], "success": [], "failed": []},
"data": {"success": [], "failed": []},
},
)
)

26
tests/components/conversation/snapshots/test_default_agent.ambr
View File

@@ -11,8 +11,6 @@
]),
'success': list([
]),
'targets': list([
]),
}),
'language': 'en-us',
'response_type': 'action_done',
@@ -37,8 +35,6 @@
]),
'success': list([
]),
'targets': list([
]),
}),
'language': 'en-us',
'response_type': 'action_done',
@@ -63,8 +59,6 @@
]),
'success': list([
]),
'targets': list([
]),
}),
'language': 'en',
'response_type': 'action_done',
@@ -94,8 +88,6 @@
'type': <IntentResponseTargetType.ENTITY: 'entity'>,
}),
]),
'targets': list([
]),
}),
'language': 'en',
'response_type': 'action_done',
@@ -125,8 +117,6 @@
'type': <IntentResponseTargetType.ENTITY: 'entity'>,
}),
]),
'targets': list([
]),
}),
'language': 'en',
'response_type': 'action_done',
@@ -198,8 +188,6 @@
'type': <IntentResponseTargetType.ENTITY: 'entity'>,
}),
]),
'targets': list([
]),
}),
'language': 'en',
'response_type': 'action_done',
@@ -229,8 +217,6 @@
'type': <IntentResponseTargetType.ENTITY: 'entity'>,
}),
]),
'targets': list([
]),
}),
'language': 'en',
'response_type': 'action_done',
@@ -260,8 +246,6 @@
'type': <IntentResponseTargetType.ENTITY: 'entity'>,
}),
]),
'targets': list([
]),
}),
'language': 'en',
'response_type': 'action_done',
@@ -291,8 +275,6 @@
'type': <IntentResponseTargetType.ENTITY: 'entity'>,
}),
]),
'targets': list([
]),
}),
'language': 'en',
'response_type': 'action_done',
@@ -343,8 +325,6 @@
'type': <IntentResponseTargetType.ENTITY: 'entity'>,
}),
]),
'targets': list([
]),
}),
'language': 'en',
'response_type': 'action_done',
@@ -416,8 +396,6 @@
'type': <IntentResponseTargetType.ENTITY: 'entity'>,
}),
]),
'targets': list([
]),
}),
'language': 'en',
'response_type': 'action_done',
@@ -468,8 +446,6 @@
'type': <IntentResponseTargetType.ENTITY: 'entity'>,
}),
]),
'targets': list([
]),
}),
'language': 'en',
'response_type': 'action_done',
@@ -499,8 +475,6 @@
'type': <IntentResponseTargetType.ENTITY: 'entity'>,
}),
]),
'targets': list([
]),
}),
'language': 'en',
'response_type': 'action_done',

4
tests/components/conversation/snapshots/test_http.ambr
View File

@@ -283,8 +283,6 @@
'type': 'entity',
}),
]),
'targets': list([
]),
}),
'language': 'en',
'response_type': 'action_done',
@@ -314,8 +312,6 @@
'type': 'entity',
}),
]),
'targets': list([
]),
}),
'language': 'en',
'response_type': 'action_done',

18
tests/components/conversation/snapshots/test_init.ambr
View File

@@ -11,8 +11,6 @@
]),
'success': list([
]),
'targets': list([
]),
}),
'language': 'test-language',
'response_type': 'action_done',
@@ -63,8 +61,6 @@
'type': <IntentResponseTargetType.ENTITY: 'entity'>,
}),
]),
'targets': list([
]),
}),
'language': 'en',
'response_type': 'action_done',
@@ -94,8 +90,6 @@
'type': <IntentResponseTargetType.ENTITY: 'entity'>,
}),
]),
'targets': list([
]),
}),
'language': 'en',
'response_type': 'action_done',
@@ -125,8 +119,6 @@
'type': <IntentResponseTargetType.ENTITY: 'entity'>,
}),
]),
'targets': list([
]),
}),
'language': 'en',
'response_type': 'action_done',
@@ -156,8 +148,6 @@
'type': <IntentResponseTargetType.ENTITY: 'entity'>,
}),
]),
'targets': list([
]),
}),
'language': 'en',
'response_type': 'action_done',
@@ -187,8 +177,6 @@
'type': <IntentResponseTargetType.ENTITY: 'entity'>,
}),
]),
'targets': list([
]),
}),
'language': 'en',
'response_type': 'action_done',
@@ -218,8 +206,6 @@
'type': <IntentResponseTargetType.ENTITY: 'entity'>,
}),
]),
'targets': list([
]),
}),
'language': 'en',
'response_type': 'action_done',
@@ -249,8 +235,6 @@
'type': <IntentResponseTargetType.ENTITY: 'entity'>,
}),
]),
'targets': list([
]),
}),
'language': 'en',
'response_type': 'action_done',
@@ -280,8 +264,6 @@
'type': <IntentResponseTargetType.ENTITY: 'entity'>,
}),
]),
'targets': list([
]),
}),
'language': 'en',
'response_type': 'action_done',

3
tests/components/google_generative_ai_conversation/snapshots/test_conversation.ambr
View File

@@ -28,8 +28,7 @@
response={
'data': {
'failed': [],
'success': [],
'targets': []
'success': []
},
'response_type': 'action_done',
'speech': {

2
tests/components/google_generative_ai_conversation/test_conversation.py
View File

@@ -117,7 +117,7 @@ async def test_function_call(
"speech": {"plain": {"speech": "4:24 PM", "extra_data": None}},
"response_type": "action_done",
"speech_slots": {"time": datetime.time(16, 24, 17, 813343)},
"data": {"targets": [], "success": [], "failed": []},
"data": {"success": [], "failed": []},
},
)
)

4
tests/components/intent/test_init.py
View File

@@ -85,7 +85,7 @@ async def test_http_handle_intent(
},
"language": hass.config.language,
"response_type": intent.IntentResponseType.ACTION_DONE.value,
"data": {"targets": [], "success": [], "failed": []},
"data": {"success": [], "failed": []},
}
@@ -149,7 +149,7 @@ async def test_http_language_device_satellite_id(
},
"language": language,
"response_type": "action_done",
"data": {"targets": [], "success": [], "failed": []},
"data": {"success": [], "failed": []},
}

1
tests/components/mobile_app/test_webhook.py
View File

@@ -1142,7 +1142,6 @@ async def test_webhook_handle_conversation_process(
},
"language": hass.config.language,
"data": {
"targets": [],
"success": [],
"failed": [],
},

2
tests/components/ollama/snapshots/test_conversation.ambr
View File

@@ -10,8 +10,6 @@
failed_results=list([
]),
intent=None,
intent_targets=list([
]),
language='en',
matched_states=list([
]),

4
tests/components/ollama/test_conversation.py
View File

@@ -499,7 +499,7 @@ async def test_history_conversion(
"speech": {"plain": {"speech": "4:24 PM", "extra_data": None}},
"response_type": "action_done",
"speech_slots": {"time": datetime.time(16, 24, 17, 813343)},
"data": {"targets": [], "success": [], "failed": []},
"data": {"success": [], "failed": []},
},
)
)
@@ -547,7 +547,7 @@ async def test_history_conversion(
),
Message(
role="tool",
content='{"speech":{"plain":{"speech":"4:24 PM","extra_data":null}},"response_type":"action_done","speech_slots":{"time":"16:24:17.813343"},"data":{"targets":[],"success":[],"failed":[]}}',
content='{"speech":{"plain":{"speech":"4:24 PM","extra_data":null}},"response_type":"action_done","speech_slots":{"time":"16:24:17.813343"},"data":{"success":[],"failed":[]}}',
),
Message(role="assistant", content="4:24 PM"),
Message(role="user", content="test message"),

4
tests/components/open_router/snapshots/test_conversation.ambr
View File

@@ -163,8 +163,6 @@
]),
'success': list([
]),
'targets': list([
]),
}),
'response_type': 'action_done',
'speech': dict({
@@ -258,7 +256,7 @@
]),
}),
dict({
'content': '{"speech":{"plain":{"speech":"12:00 PM","extra_data":null}},"response_type":"action_done","speech_slots":{"time":"12:00:00"},"data":{"targets":[],"success":[],"failed":[]}}',
'content': '{"speech":{"plain":{"speech":"12:00 PM","extra_data":null}},"response_type":"action_done","speech_slots":{"time":"12:00:00"},"data":{"success":[],"failed":[]}}',
'role': 'tool',
'tool_call_id': 'mock_tool_call_id',
}),

2
tests/components/open_router/test_conversation.py
View File

@@ -116,7 +116,7 @@ async def test_function_call(
"speech": {"plain": {"speech": "12:00 PM", "extra_data": None}},
"response_type": "action_done",
"speech_slots": {"time": datetime.time(12, 0)},
"data": {"targets": [], "success": [], "failed": []},
"data": {"success": [], "failed": []},
},
)
)

4
tests/components/openai_conversation/snapshots/test_conversation.ambr
View File

@@ -71,8 +71,6 @@
]),
'success': list([
]),
'targets': list([
]),
}),
'response_type': 'action_done',
'speech': dict({
@@ -197,7 +195,7 @@
}),
dict({
'call_id': 'mock-tool-call-id',
'output': '{"speech":{"plain":{"speech":"12:00 PM","extra_data":null}},"response_type":"action_done","speech_slots":{"time":"12:00:00"},"data":{"targets":[],"success":[],"failed":[]}}',
'output': '{"speech":{"plain":{"speech":"12:00 PM","extra_data":null}},"response_type":"action_done","speech_slots":{"time":"12:00:00"},"data":{"success":[],"failed":[]}}',
'type': 'function_call_output',
}),
dict({

2
tests/components/openai_conversation/test_conversation.py
View File

@@ -279,7 +279,7 @@ async def test_function_call(
"speech": {"plain": {"speech": "12:00 PM", "extra_data": None}},
"response_type": "action_done",
"speech_slots": {"time": datetime.time(12, 0, 0, 0)},
"data": {"targets": [], "success": [], "failed": []},
"data": {"success": [], "failed": []},
},
)
)

2
tests/helpers/test_llm.py
View File

@@ -249,7 +249,6 @@ async def test_assist_api(
"data": {
"failed": [],
"success": [],
"targets": [],
},
"reprompt": {
"plain": {
@@ -308,7 +307,6 @@ async def test_assist_api(
"data": {
"failed": [],
"success": [],
"targets": [],
},
"response_type": "action_done",
"reprompt": {