Home-Assistant/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-12-24 21:06:19 +00:00
Code Activity

Change style for critical number entities in ViCare integration (#153634)

Browse Source
This commit is contained in:
Christopher Fenner
2025-10-05 16:36:42 +02:00
committed by GitHub
parent 98f8f15e90
commit 9209e419ec
2 changed files with 38 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
homeassistant/components/vicare/number.py
View File

@@ -24,6 +24,7 @@ from homeassistant.components.number import (
NumberDeviceClass,
NumberEntity,
NumberEntityDescription,
NumberMode,
)
from homeassistant.const import EntityCategory, UnitOfTemperature
from homeassistant.core import HomeAssistant
@@ -59,6 +60,7 @@ DEVICE_ENTITY_DESCRIPTIONS: tuple[ViCareNumberEntityDescription, ...] = (
entity_category=EntityCategory.CONFIG,
device_class=NumberDeviceClass.TEMPERATURE,
native_unit_of_measurement=UnitOfTemperature.CELSIUS,
mode=NumberMode.BOX,
value_getter=lambda api: api.getDomesticHotWaterConfiguredTemperature(),
value_setter=lambda api, value: api.setDomesticHotWaterTemperature(value),
min_value_getter=lambda api: api.getDomesticHotWaterMinTemperature(),
@@ -71,6 +73,7 @@ DEVICE_ENTITY_DESCRIPTIONS: tuple[ViCareNumberEntityDescription, ...] = (
entity_category=EntityCategory.CONFIG,
device_class=NumberDeviceClass.TEMPERATURE,
native_unit_of_measurement=UnitOfTemperature.CELSIUS,
mode=NumberMode.BOX,
value_getter=lambda api: api.getDomesticHotWaterConfiguredTemperature2(),
value_setter=lambda api, value: api.setDomesticHotWaterTemperature2(value),
# no getters for min, max, stepping exposed yet, using static values
@@ -84,6 +87,7 @@ DEVICE_ENTITY_DESCRIPTIONS: tuple[ViCareNumberEntityDescription, ...] = (
entity_category=EntityCategory.CONFIG,
device_class=NumberDeviceClass.TEMPERATURE,
native_unit_of_measurement=UnitOfTemperature.KELVIN,
mode=NumberMode.BOX,
value_getter=lambda api: api.getDomesticHotWaterHysteresisSwitchOn(),
value_setter=lambda api, value: api.setDomesticHotWaterHysteresisSwitchOn(
value
@@ -98,6 +102,7 @@ DEVICE_ENTITY_DESCRIPTIONS: tuple[ViCareNumberEntityDescription, ...] = (
entity_category=EntityCategory.CONFIG,
device_class=NumberDeviceClass.TEMPERATURE,
native_unit_of_measurement=UnitOfTemperature.KELVIN,
mode=NumberMode.BOX,
value_getter=lambda api: api.getDomesticHotWaterHysteresisSwitchOff(),
value_setter=lambda api, value: api.setDomesticHotWaterHysteresisSwitchOff(
value
@@ -116,6 +121,7 @@ CIRCUIT_ENTITY_DESCRIPTIONS: tuple[ViCareNumberEntityDescription, ...] = (
entity_category=EntityCategory.CONFIG,
device_class=NumberDeviceClass.TEMPERATURE,
native_unit_of_measurement=UnitOfTemperature.CELSIUS,
mode=NumberMode.BOX,
value_getter=lambda api: api.getHeatingCurveShift(),
value_setter=lambda api, shift: (
api.setHeatingCurve(shift, api.getHeatingCurveSlope())
@@ -131,6 +137,7 @@ CIRCUIT_ENTITY_DESCRIPTIONS: tuple[ViCareNumberEntityDescription, ...] = (
key="heating curve slope",
translation_key="heating_curve_slope",
entity_category=EntityCategory.CONFIG,
mode=NumberMode.BOX,
value_getter=lambda api: api.getHeatingCurveSlope(),
value_setter=lambda api, slope: (
api.setHeatingCurve(api.getHeatingCurveShift(), slope)
@@ -148,6 +155,7 @@ CIRCUIT_ENTITY_DESCRIPTIONS: tuple[ViCareNumberEntityDescription, ...] = (
entity_category=EntityCategory.CONFIG,
device_class=NumberDeviceClass.TEMPERATURE,
native_unit_of_measurement=UnitOfTemperature.CELSIUS,
mode=NumberMode.BOX,
value_getter=lambda api: api.getDesiredTemperatureForProgram(
HeatingProgram.NORMAL
),
@@ -168,6 +176,7 @@ CIRCUIT_ENTITY_DESCRIPTIONS: tuple[ViCareNumberEntityDescription, ...] = (
entity_category=EntityCategory.CONFIG,
device_class=NumberDeviceClass.TEMPERATURE,
native_unit_of_measurement=UnitOfTemperature.CELSIUS,
mode=NumberMode.BOX,
value_getter=lambda api: api.getDesiredTemperatureForProgram(
HeatingProgram.REDUCED
),
@@ -188,6 +197,7 @@ CIRCUIT_ENTITY_DESCRIPTIONS: tuple[ViCareNumberEntityDescription, ...] = (
entity_category=EntityCategory.CONFIG,
device_class=NumberDeviceClass.TEMPERATURE,
native_unit_of_measurement=UnitOfTemperature.CELSIUS,
mode=NumberMode.BOX,
value_getter=lambda api: api.getDesiredTemperatureForProgram(
HeatingProgram.COMFORT
),
@@ -208,6 +218,7 @@ CIRCUIT_ENTITY_DESCRIPTIONS: tuple[ViCareNumberEntityDescription, ...] = (
entity_category=EntityCategory.CONFIG,
device_class=NumberDeviceClass.TEMPERATURE,
native_unit_of_measurement=UnitOfTemperature.CELSIUS,
mode=NumberMode.BOX,
value_getter=lambda api: api.getDesiredTemperatureForProgram(
HeatingProgram.NORMAL_HEATING
),
@@ -230,6 +241,7 @@ CIRCUIT_ENTITY_DESCRIPTIONS: tuple[ViCareNumberEntityDescription, ...] = (
entity_category=EntityCategory.CONFIG,
device_class=NumberDeviceClass.TEMPERATURE,
native_unit_of_measurement=UnitOfTemperature.CELSIUS,
mode=NumberMode.BOX,
value_getter=lambda api: api.getDesiredTemperatureForProgram(
HeatingProgram.REDUCED_HEATING
),
@@ -252,6 +264,7 @@ CIRCUIT_ENTITY_DESCRIPTIONS: tuple[ViCareNumberEntityDescription, ...] = (
entity_category=EntityCategory.CONFIG,
device_class=NumberDeviceClass.TEMPERATURE,
native_unit_of_measurement=UnitOfTemperature.CELSIUS,
mode=NumberMode.BOX,
value_getter=lambda api: api.getDesiredTemperatureForProgram(
HeatingProgram.COMFORT_HEATING
),
@@ -274,6 +287,7 @@ CIRCUIT_ENTITY_DESCRIPTIONS: tuple[ViCareNumberEntityDescription, ...] = (
entity_category=EntityCategory.CONFIG,
device_class=NumberDeviceClass.TEMPERATURE,
native_unit_of_measurement=UnitOfTemperature.CELSIUS,
mode=NumberMode.BOX,
value_getter=lambda api: api.getDesiredTemperatureForProgram(
HeatingProgram.NORMAL_COOLING
),
@@ -296,6 +310,7 @@ CIRCUIT_ENTITY_DESCRIPTIONS: tuple[ViCareNumberEntityDescription, ...] = (
entity_category=EntityCategory.CONFIG,
device_class=NumberDeviceClass.TEMPERATURE,
native_unit_of_measurement=UnitOfTemperature.CELSIUS,
mode=NumberMode.BOX,
value_getter=lambda api: api.getDesiredTemperatureForProgram(
HeatingProgram.REDUCED_COOLING
),
@@ -318,6 +333,7 @@ CIRCUIT_ENTITY_DESCRIPTIONS: tuple[ViCareNumberEntityDescription, ...] = (
entity_category=EntityCategory.CONFIG,
device_class=NumberDeviceClass.TEMPERATURE,
native_unit_of_measurement=UnitOfTemperature.CELSIUS,
mode=NumberMode.BOX,
value_getter=lambda api: api.getDesiredTemperatureForProgram(
HeatingProgram.COMFORT_COOLING
),

44
tests/components/vicare/snapshots/test_number.ambr
View File

@@ -7,7 +7,7 @@
'capabilities': dict({
'max': 100.0,
'min': 0.0,
'mode': <NumberMode.AUTO: 'auto'>,
'mode': <NumberMode.BOX: 'box'>,
'step': 1.0,
}),
'config_entry_id': <ANY>,
@@ -46,7 +46,7 @@
'friendly_name': 'model0 Comfort temperature',
'max': 100.0,
'min': 0.0,
'mode': <NumberMode.AUTO: 'auto'>,
'mode': <NumberMode.BOX: 'box'>,
'step': 1.0,
'unit_of_measurement': <UnitOfTemperature.CELSIUS: '°C'>,
}),
@@ -66,7 +66,7 @@
'capabilities': dict({
'max': 100.0,
'min': 0.0,
'mode': <NumberMode.AUTO: 'auto'>,
'mode': <NumberMode.BOX: 'box'>,
'step': 1.0,
}),
'config_entry_id': <ANY>,
@@ -105,7 +105,7 @@
'friendly_name': 'model0 Comfort temperature',
'max': 100.0,
'min': 0.0,
'mode': <NumberMode.AUTO: 'auto'>,
'mode': <NumberMode.BOX: 'box'>,
'step': 1.0,
'unit_of_measurement': <UnitOfTemperature.CELSIUS: '°C'>,
}),
@@ -125,7 +125,7 @@
'capabilities': dict({
'max': 100.0,
'min': 0.0,
'mode': <NumberMode.AUTO: 'auto'>,
'mode': <NumberMode.BOX: 'box'>,
'step': 1,
}),
'config_entry_id': <ANY>,
@@ -164,7 +164,7 @@
'friendly_name': 'model0 DHW temperature',
'max': 100.0,
'min': 0.0,
'mode': <NumberMode.AUTO: 'auto'>,
'mode': <NumberMode.BOX: 'box'>,
'step': 1,
'unit_of_measurement': <UnitOfTemperature.CELSIUS: '°C'>,
}),
@@ -184,7 +184,7 @@
'capabilities': dict({
'max': 40,
'min': -13,
'mode': <NumberMode.AUTO: 'auto'>,
'mode': <NumberMode.BOX: 'box'>,
'step': 1,
}),
'config_entry_id': <ANY>,
@@ -223,7 +223,7 @@
'friendly_name': 'model0 Heating curve shift',
'max': 40,
'min': -13,
'mode': <NumberMode.AUTO: 'auto'>,
'mode': <NumberMode.BOX: 'box'>,
'step': 1,
'unit_of_measurement': <UnitOfTemperature.CELSIUS: '°C'>,
}),
@@ -243,7 +243,7 @@
'capabilities': dict({
'max': 40,
'min': -13,
'mode': <NumberMode.AUTO: 'auto'>,
'mode': <NumberMode.BOX: 'box'>,
'step': 1,
}),
'config_entry_id': <ANY>,
@@ -282,7 +282,7 @@
'friendly_name': 'model0 Heating curve shift',
'max': 40,
'min': -13,
'mode': <NumberMode.AUTO: 'auto'>,
'mode': <NumberMode.BOX: 'box'>,
'step': 1,
'unit_of_measurement': <UnitOfTemperature.CELSIUS: '°C'>,
}),
@@ -302,7 +302,7 @@
'capabilities': dict({
'max': 3.5,
'min': 0.2,
'mode': <NumberMode.AUTO: 'auto'>,
'mode': <NumberMode.BOX: 'box'>,
'step': 0.1,
}),
'config_entry_id': <ANY>,
@@ -340,7 +340,7 @@
'friendly_name': 'model0 Heating curve slope',
'max': 3.5,
'min': 0.2,
'mode': <NumberMode.AUTO: 'auto'>,
'mode': <NumberMode.BOX: 'box'>,
'step': 0.1,
}),
'context': <ANY>,
@@ -359,7 +359,7 @@
'capabilities': dict({
'max': 3.5,
'min': 0.2,
'mode': <NumberMode.AUTO: 'auto'>,
'mode': <NumberMode.BOX: 'box'>,
'step': 0.1,
}),
'config_entry_id': <ANY>,
@@ -397,7 +397,7 @@
'friendly_name': 'model0 Heating curve slope',
'max': 3.5,
'min': 0.2,
'mode': <NumberMode.AUTO: 'auto'>,
'mode': <NumberMode.BOX: 'box'>,
'step': 0.1,
}),
'context': <ANY>,
@@ -416,7 +416,7 @@
'capabilities': dict({
'max': 100.0,
'min': 0.0,
'mode': <NumberMode.AUTO: 'auto'>,
'mode': <NumberMode.BOX: 'box'>,
'step': 1.0,
}),
'config_entry_id': <ANY>,
@@ -455,7 +455,7 @@
'friendly_name': 'model0 Normal temperature',
'max': 100.0,
'min': 0.0,
'mode': <NumberMode.AUTO: 'auto'>,
'mode': <NumberMode.BOX: 'box'>,
'step': 1.0,
'unit_of_measurement': <UnitOfTemperature.CELSIUS: '°C'>,
}),
@@ -475,7 +475,7 @@
'capabilities': dict({
'max': 100.0,
'min': 0.0,
'mode': <NumberMode.AUTO: 'auto'>,
'mode': <NumberMode.BOX: 'box'>,
'step': 1.0,
}),
'config_entry_id': <ANY>,
@@ -514,7 +514,7 @@
'friendly_name': 'model0 Normal temperature',
'max': 100.0,
'min': 0.0,
'mode': <NumberMode.AUTO: 'auto'>,
'mode': <NumberMode.BOX: 'box'>,
'step': 1.0,
'unit_of_measurement': <UnitOfTemperature.CELSIUS: '°C'>,
}),
@@ -534,7 +534,7 @@
'capabilities': dict({
'max': 100.0,
'min': 0.0,
'mode': <NumberMode.AUTO: 'auto'>,
'mode': <NumberMode.BOX: 'box'>,
'step': 1.0,
}),
'config_entry_id': <ANY>,
@@ -573,7 +573,7 @@
'friendly_name': 'model0 Reduced temperature',
'max': 100.0,
'min': 0.0,
'mode': <NumberMode.AUTO: 'auto'>,
'mode': <NumberMode.BOX: 'box'>,
'step': 1.0,
'unit_of_measurement': <UnitOfTemperature.CELSIUS: '°C'>,
}),
@@ -593,7 +593,7 @@
'capabilities': dict({
'max': 100.0,
'min': 0.0,
'mode': <NumberMode.AUTO: 'auto'>,
'mode': <NumberMode.BOX: 'box'>,
'step': 1.0,
}),
'config_entry_id': <ANY>,
@@ -632,7 +632,7 @@
'friendly_name': 'model0 Reduced temperature',
'max': 100.0,
'min': 0.0,
'mode': <NumberMode.AUTO: 'auto'>,
'mode': <NumberMode.BOX: 'box'>,
'step': 1.0,
'unit_of_measurement': <UnitOfTemperature.CELSIUS: '°C'>,
}),