Home-Assistant/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2026-02-15 07:36:16 +00:00
Code Activity

Mark preset_mode type hints as compulsory in climate/fan platforms (#161043)

Browse Source
This commit is contained in:
epenet
2026-01-17 13:09:18 +01:00
committed by GitHub
parent 8503637a80
commit 9260394883
5 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
homeassistant/components/maxcube/climate.py
View File

@@ -192,7 +192,7 @@ class MaxCubeClimate(ClimateEntity):
self._set_target(None, temp)
@property
def preset_mode(self):
def preset_mode(self) -> str:
"""Return the current preset mode."""
if self._device.mode == MAX_DEVICE_MODE_MANUAL:
if self._device.target_temperature == self._device.comfort_temperature:

2
homeassistant/components/nexia/climate.py
View File

@@ -225,7 +225,7 @@ class NexiaZone(NexiaThermostatZoneEntity, ClimateEntity):
self._signal_thermostat_update()
@property
def preset_mode(self):
def preset_mode(self) -> str | None:
"""Preset that is active."""
return self._zone.get_preset()

2
homeassistant/components/nuheat/climate.py
View File

@@ -154,7 +154,7 @@ class NuHeatThermostat(CoordinatorEntity, ClimateEntity):
return nuheat_to_fahrenheit(self._target_temperature)
@property
def preset_mode(self):
def preset_mode(self) -> str:
"""Return current preset mode."""
return SCHEDULE_MODE_TO_PRESET_MODE_MAP.get(self._schedule_mode, PRESET_RUN)

4
homeassistant/components/vicare/climate.py
View File

@@ -282,8 +282,10 @@ class ViCareClimate(ViCareEntity, ClimateEntity):
self._attr_target_temperature = temp
@property
def preset_mode(self):
def preset_mode(self) -> str | None:
"""Return the current preset mode, e.g., home, away, temp."""
if self._current_program is None:
return None
return HeatingProgram.to_ha_preset(self._current_program)
def set_preset_mode(self, preset_mode: str) -> None:

2
pylint/plugins/hass_enforce_type_hints.py
View File

@@ -1225,6 +1225,7 @@ _INHERITANCE_MATCH: dict[str, list[ClassTypeHintMatch]] = {
TypeHintMatch(
function_name="preset_mode",
return_type=["str", None],
mandatory=True,
),
TypeHintMatch(
function_name="preset_modes",
@@ -1602,6 +1603,7 @@ _INHERITANCE_MATCH: dict[str, list[ClassTypeHintMatch]] = {
TypeHintMatch(
function_name="preset_mode",
return_type=["str", None],
mandatory=True,
),
TypeHintMatch(
function_name="preset_modes",