Upgrade Airobot integration to platinum (#161532)

Co-authored-by: Joostlek <joostlek@outlook.com>

.strict-typing

@@ -53,6 +53,7 @@ homeassistant.components.air_quality.*
 homeassistant.components.airgradient.*
 homeassistant.components.airly.*
 homeassistant.components.airnow.*
+homeassistant.components.airobot.*
 homeassistant.components.airos.*
 homeassistant.components.airq.*
 homeassistant.components.airthings.*

homeassistant/components/airobot/climate.py

@@ -29,6 +29,7 @@ from homeassistant.helpers.entity_platform import AddConfigEntryEntitiesCallback
 
 from . import AirobotConfigEntry
 from .const import DOMAIN
+from .coordinator import AirobotDataUpdateCoordinator
 from .entity import AirobotEntity
 
 PARALLEL_UPDATES = 1
@@ -63,7 +64,7 @@ class AirobotClimate(AirobotEntity, ClimateEntity):
     _attr_min_temp = SETPOINT_TEMP_MIN
     _attr_max_temp = SETPOINT_TEMP_MAX
 
-    def __init__(self, coordinator) -> None:
+    def __init__(self, coordinator: AirobotDataUpdateCoordinator) -> None:
         """Initialize the climate entity."""
         super().__init__(coordinator)
         self._attr_unique_id = coordinator.data.status.device_id

homeassistant/components/airobot/config_flow.py

@@ -2,6 +2,7 @@
 
 from __future__ import annotations
 
+import asyncio
 from collections.abc import Mapping
 from dataclasses import dataclass
 import logging
@@ -60,11 +61,17 @@ async def validate_input(hass: HomeAssistant, data: dict[str, Any]) -> DeviceInf
 
     try:
         # Try to fetch data to validate connection and authentication
-        status = await client.get_statuses()
-        settings = await client.get_settings()
+        status, settings = await asyncio.gather(
+            client.get_statuses(), client.get_settings()
+        )
     except AirobotAuthError as err:
         raise InvalidAuth from err
-    except (AirobotConnectionError, AirobotTimeoutError, AirobotError) as err:
+    except (
+        AirobotConnectionError,
+        AirobotTimeoutError,
+        AirobotError,
+        TimeoutError,
+    ) as err:
         raise CannotConnect from err
 
     # Use device name or device ID as title

homeassistant/components/airobot/coordinator.py

@@ -2,6 +2,7 @@
 
 from __future__ import annotations
 
+import asyncio
 from datetime import timedelta
 import logging
 
@@ -52,8 +53,10 @@ class AirobotDataUpdateCoordinator(DataUpdateCoordinator[AirobotData]):
     async def _async_update_data(self) -> AirobotData:
         """Fetch data from API endpoint."""
         try:
-            status = await self.client.get_statuses()
-            settings = await self.client.get_settings()
+            status, settings = await asyncio.gather(
+                self.client.get_statuses(),
+                self.client.get_settings(),
+            )
         except AirobotAuthError as err:
             raise ConfigEntryAuthFailed(
                 translation_domain=DOMAIN,

homeassistant/components/airobot/manifest.json

@@ -12,6 +12,6 @@
   "integration_type": "device",
   "iot_class": "local_polling",
   "loggers": ["pyairobotrest"],
-  "quality_scale": "gold",
+  "quality_scale": "platinum",
   "requirements": ["pyairobotrest==0.3.0"]
 }

homeassistant/components/airobot/quality_scale.yaml

@@ -69,4 +69,4 @@ rules:
   # Platinum
   async-dependency: done
   inject-websession: done
-  strict-typing: todo
+  strict-typing: done

homeassistant/components/airobot/sensor.py

@@ -28,6 +28,7 @@ from homeassistant.util.dt import utcnow
 from homeassistant.util.variance import ignore_variance
 
 from . import AirobotConfigEntry
+from .coordinator import AirobotDataUpdateCoordinator
 from .entity import AirobotEntity
 
 PARALLEL_UPDATES = 0
@@ -53,6 +54,7 @@ SENSOR_TYPES: tuple[AirobotSensorEntityDescription, ...] = (
         device_class=SensorDeviceClass.TEMPERATURE,
         native_unit_of_measurement=UnitOfTemperature.CELSIUS,
         state_class=SensorStateClass.MEASUREMENT,
+        suggested_display_precision=1,
         value_fn=lambda status: status.temp_air,
     ),
     AirobotSensorEntityDescription(
@@ -136,7 +138,7 @@ class AirobotSensor(AirobotEntity, SensorEntity):
 
     def __init__(
         self,
-        coordinator,
+        coordinator: AirobotDataUpdateCoordinator,
         description: AirobotSensorEntityDescription,
     ) -> None:
         """Initialize the sensor."""

mypy.ini

@@ -285,6 +285,16 @@ disallow_untyped_defs = true
 warn_return_any = true
 warn_unreachable = true
 
+[mypy-homeassistant.components.airobot.*]
+check_untyped_defs = true
+disallow_incomplete_defs = true
+disallow_subclassing_any = true
+disallow_untyped_calls = true
+disallow_untyped_decorators = true
+disallow_untyped_defs = true
+warn_return_any = true
+warn_unreachable = true
+
 [mypy-homeassistant.components.airos.*]
 check_untyped_defs = true
 disallow_incomplete_defs = true

tests/components/airobot/test_climate.py

@@ -22,7 +22,7 @@ from homeassistant.core import HomeAssistant
 from homeassistant.exceptions import ServiceValidationError
 import homeassistant.helpers.entity_registry as er
 
-from tests.common import MockConfigEntry, snapshot_platform
+from tests.common import MockConfigEntry, async_fire_time_changed, snapshot_platform
 
 
 @pytest.fixture
@@ -231,8 +231,9 @@ async def test_climate_unavailable_on_update_failure(
     )
 
     # Advance time to trigger coordinator update (30 second interval)
-    freezer.tick(timedelta(seconds=35))
-    await hass.async_block_till_done()
+    freezer.tick(timedelta(seconds=30))
+    async_fire_time_changed(hass)
+    await hass.async_block_till_done(wait_background_tasks=True)
 
     # Entity should now be unavailable
     state = hass.states.get("climate.test_thermostat")