Categorize all immich sensor entities as diagnostic (#162887)

homeassistant/components/immich/quality_scale.yaml

@@ -56,7 +56,7 @@ rules:
   dynamic-devices:
     status: exempt
     comment: Only one device entry per config entry
-  entity-category: todo
+  entity-category: done
   entity-device-class: done
   entity-disabled-by-default: done
   entity-translations: done

homeassistant/components/immich/sensor.py

@@ -11,7 +11,7 @@ from homeassistant.components.sensor import (
     SensorEntityDescription,
     SensorStateClass,
 )
-from homeassistant.const import PERCENTAGE, UnitOfInformation
+from homeassistant.const import PERCENTAGE, EntityCategory, UnitOfInformation
 from homeassistant.core import HomeAssistant
 from homeassistant.helpers.entity_platform import AddConfigEntryEntitiesCallback
 from homeassistant.helpers.typing import StateType
@@ -40,6 +40,7 @@ SENSOR_TYPES: tuple[ImmichSensorEntityDescription, ...] = (
         suggested_display_precision=1,
         device_class=SensorDeviceClass.DATA_SIZE,
         state_class=SensorStateClass.MEASUREMENT,
+        entity_category=EntityCategory.DIAGNOSTIC,
         value=lambda data: data.server_storage.disk_size_raw,
     ),
     ImmichSensorEntityDescription(
@@ -50,6 +51,7 @@ SENSOR_TYPES: tuple[ImmichSensorEntityDescription, ...] = (
         suggested_display_precision=1,
         device_class=SensorDeviceClass.DATA_SIZE,
         state_class=SensorStateClass.MEASUREMENT,
+        entity_category=EntityCategory.DIAGNOSTIC,
         value=lambda data: data.server_storage.disk_available_raw,
     ),
     ImmichSensorEntityDescription(
@@ -60,6 +62,7 @@ SENSOR_TYPES: tuple[ImmichSensorEntityDescription, ...] = (
         suggested_display_precision=1,
         device_class=SensorDeviceClass.DATA_SIZE,
         state_class=SensorStateClass.MEASUREMENT,
+        entity_category=EntityCategory.DIAGNOSTIC,
         value=lambda data: data.server_storage.disk_use_raw,
         entity_registry_enabled_default=False,
     ),
@@ -68,6 +71,7 @@ SENSOR_TYPES: tuple[ImmichSensorEntityDescription, ...] = (
         translation_key="disk_usage",
         native_unit_of_measurement=PERCENTAGE,
         state_class=SensorStateClass.MEASUREMENT,
+        entity_category=EntityCategory.DIAGNOSTIC,
         value=lambda data: data.server_storage.disk_usage_percentage,
         entity_registry_enabled_default=False,
     ),
@@ -75,6 +79,7 @@ SENSOR_TYPES: tuple[ImmichSensorEntityDescription, ...] = (
         key="photos_count",
         translation_key="photos_count",
         state_class=SensorStateClass.MEASUREMENT,
+        entity_category=EntityCategory.DIAGNOSTIC,
         value=lambda data: data.server_usage.photos if data.server_usage else None,
         is_suitable=lambda data: data.server_usage is not None,
     ),
@@ -82,6 +87,7 @@ SENSOR_TYPES: tuple[ImmichSensorEntityDescription, ...] = (
         key="videos_count",
         translation_key="videos_count",
         state_class=SensorStateClass.MEASUREMENT,
+        entity_category=EntityCategory.DIAGNOSTIC,
         value=lambda data: data.server_usage.videos if data.server_usage else None,
         is_suitable=lambda data: data.server_usage is not None,
     ),
@@ -93,6 +99,7 @@ SENSOR_TYPES: tuple[ImmichSensorEntityDescription, ...] = (
         suggested_display_precision=1,
         device_class=SensorDeviceClass.DATA_SIZE,
         state_class=SensorStateClass.MEASUREMENT,
+        entity_category=EntityCategory.DIAGNOSTIC,
         value=lambda d: d.server_usage.usage_photos if d.server_usage else None,
         is_suitable=lambda data: data.server_usage is not None,
         entity_registry_enabled_default=False,
@@ -105,6 +112,7 @@ SENSOR_TYPES: tuple[ImmichSensorEntityDescription, ...] = (
         suggested_display_precision=1,
         device_class=SensorDeviceClass.DATA_SIZE,
         state_class=SensorStateClass.MEASUREMENT,
+        entity_category=EntityCategory.DIAGNOSTIC,
         value=lambda d: d.server_usage.usage_videos if d.server_usage else None,
         is_suitable=lambda data: data.server_usage is not None,
         entity_registry_enabled_default=False,

tests/components/immich/snapshots/test_sensor.ambr

@@ -13,7 +13,7 @@
     'device_id': <ANY>,
     'disabled_by': None,
     'domain': 'sensor',
-    'entity_category': None,
+    'entity_category': <EntityCategory.DIAGNOSTIC: 'diagnostic'>,
     'entity_id': 'sensor.someone_disk_available',
     'has_entity_name': True,
     'hidden_by': None,
@@ -73,7 +73,7 @@
     'device_id': <ANY>,
     'disabled_by': None,
     'domain': 'sensor',
-    'entity_category': None,
+    'entity_category': <EntityCategory.DIAGNOSTIC: 'diagnostic'>,
     'entity_id': 'sensor.someone_disk_size',
     'has_entity_name': True,
     'hidden_by': None,
@@ -133,7 +133,7 @@
     'device_id': <ANY>,
     'disabled_by': None,
     'domain': 'sensor',
-    'entity_category': None,
+    'entity_category': <EntityCategory.DIAGNOSTIC: 'diagnostic'>,
     'entity_id': 'sensor.someone_disk_usage',
     'has_entity_name': True,
     'hidden_by': None,
@@ -186,7 +186,7 @@
     'device_id': <ANY>,
     'disabled_by': None,
     'domain': 'sensor',
-    'entity_category': None,
+    'entity_category': <EntityCategory.DIAGNOSTIC: 'diagnostic'>,
     'entity_id': 'sensor.someone_disk_used',
     'has_entity_name': True,
     'hidden_by': None,
@@ -246,7 +246,7 @@
     'device_id': <ANY>,
     'disabled_by': None,
     'domain': 'sensor',
-    'entity_category': None,
+    'entity_category': <EntityCategory.DIAGNOSTIC: 'diagnostic'>,
     'entity_id': 'sensor.someone_disk_used_by_photos',
     'has_entity_name': True,
     'hidden_by': None,
@@ -306,7 +306,7 @@
     'device_id': <ANY>,
     'disabled_by': None,
     'domain': 'sensor',
-    'entity_category': None,
+    'entity_category': <EntityCategory.DIAGNOSTIC: 'diagnostic'>,
     'entity_id': 'sensor.someone_disk_used_by_videos',
     'has_entity_name': True,
     'hidden_by': None,
@@ -366,7 +366,7 @@
     'device_id': <ANY>,
     'disabled_by': None,
     'domain': 'sensor',
-    'entity_category': None,
+    'entity_category': <EntityCategory.DIAGNOSTIC: 'diagnostic'>,
     'entity_id': 'sensor.someone_photos_count',
     'has_entity_name': True,
     'hidden_by': None,
@@ -419,7 +419,7 @@
     'device_id': <ANY>,
     'disabled_by': None,
     'domain': 'sensor',
-    'entity_category': None,
+    'entity_category': <EntityCategory.DIAGNOSTIC: 'diagnostic'>,
     'entity_id': 'sensor.someone_videos_count',
     'has_entity_name': True,
     'hidden_by': None,