Home-Assistant/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2026-09-02 19:42:30 +01:00
Code Activity

Complete Subaru config flow error tests to CREATE_ENTRY (#181033)

Browse Source 
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
John Pettitt
2026-09-02 16:12:23 +02:00
committed by GitHub
co-authored by Claude Fable 5
parent c5fae71f70
commit edb7dc8b0d
1 changed files with 102 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/components/subaru/test_config_flow.py
+102 -42
View File
@@ -41,15 +41,6 @@ MOCK_2FA_CONTACTS = {
}
async def test_user_form_init(user_form) -> None:
"""Test the initial user form for first step of the config flow."""
assert user_form["description_placeholders"] is None
assert user_form["errors"] is None
assert user_form["handler"] == DOMAIN
assert user_form["step_id"] == "user"
assert user_form["type"] is FlowResultType.FORM
async def test_user_form_repeat_identifier(hass: HomeAssistant, user_form) -> None:
"""Test we handle repeat identifiers."""
entry = MockConfigEntry(
@@ -86,7 +77,7 @@ async def test_user_form_cannot_connect(hass: HomeAssistant, user_form) -> None:
async def test_user_form_invalid_auth(hass: HomeAssistant, user_form) -> None:
"""Test we handle invalid auth."""
"""Test we handle invalid auth, and that the flow can still be completed afterward."""
with patch(
MOCK_API_CONNECT,
side_effect=InvalidCredentials("invalidAccount"),
@@ -99,6 +90,18 @@ async def test_user_form_invalid_auth(hass: HomeAssistant, user_form) -> None:
assert result["type"] is FlowResultType.FORM
assert result["errors"] == {"base": "invalid_auth"}
with (
patch(MOCK_API_CONNECT, return_value=True),
patch(MOCK_API_DEVICE_REGISTERED, new_callable=PropertyMock, return_value=True),
patch(MOCK_API_IS_PIN_REQUIRED, return_value=False),
patch(ASYNC_SETUP_ENTRY, return_value=True),
):
result = await hass.config_entries.flow.async_configure(
result["flow_id"],
TEST_CREDS,
)
assert result["type"] is FlowResultType.CREATE_ENTRY
async def test_user_form_pin_not_required(
hass: HomeAssistant, two_factor_verify_form
@@ -154,9 +157,21 @@ async def test_registered_pin_required(hass: HomeAssistant, user_form) -> None:
patch(MOCK_API_IS_PIN_REQUIRED, return_value=True),
):
mock_device_registered.return_value = True
await hass.config_entries.flow.async_configure(
result = await hass.config_entries.flow.async_configure(
user_form["flow_id"], user_input=TEST_CREDS
)
assert result["type"] is FlowResultType.FORM
assert result["step_id"] == "pin"
with (
patch(MOCK_API_TEST_PIN, return_value=True),
patch(MOCK_API_UPDATE_SAVED_PIN, return_value=True),
patch(ASYNC_SETUP_ENTRY, return_value=True),
):
result = await hass.config_entries.flow.async_configure(
result["flow_id"], user_input={CONF_PIN: TEST_PIN}
)
assert result["type"] is FlowResultType.CREATE_ENTRY
async def test_registered_no_pin_required(hass: HomeAssistant, user_form) -> None:
@@ -167,11 +182,13 @@ async def test_registered_no_pin_required(hass: HomeAssistant, user_form) -> Non
MOCK_API_DEVICE_REGISTERED, new_callable=PropertyMock
) as mock_device_registered,
patch(MOCK_API_IS_PIN_REQUIRED, return_value=False),
patch(ASYNC_SETUP_ENTRY, return_value=True),
):
mock_device_registered.return_value = True
await hass.config_entries.flow.async_configure(
result = await hass.config_entries.flow.async_configure(
user_form["flow_id"], user_input=TEST_CREDS
)
assert result["type"] is FlowResultType.CREATE_ENTRY
async def test_two_factor_request_success(
@@ -186,11 +203,24 @@ async def test_two_factor_request_success(
patch(MOCK_API_2FA_CONTACTS, new_callable=PropertyMock) as mock_contacts,
):
mock_contacts.return_value = MOCK_2FA_CONTACTS
await hass.config_entries.flow.async_configure(
result = await hass.config_entries.flow.async_configure(
two_factor_start_form["flow_id"],
user_input={config_flow.CONF_CONTACT_METHOD: "email@addr.com"},
)
assert len(mock_two_factor_request.mock_calls) == 1
assert result["type"] is FlowResultType.FORM
assert result["step_id"] == "two_factor_validate"
with (
patch(MOCK_API_2FA_VERIFY, return_value=True),
patch(MOCK_API_IS_PIN_REQUIRED, return_value=False),
patch(ASYNC_SETUP_ENTRY, return_value=True),
):
result = await hass.config_entries.flow.async_configure(
result["flow_id"],
user_input={config_flow.CONF_VALIDATION_CODE: "123456"},
)
assert result["type"] is FlowResultType.CREATE_ENTRY
async def test_two_factor_request_fail(
@@ -225,18 +255,30 @@ async def test_two_factor_verify_success(
) as mock_two_factor_verify,
patch(MOCK_API_IS_PIN_REQUIRED, return_value=True) as mock_is_in_required,
):
await hass.config_entries.flow.async_configure(
result = await hass.config_entries.flow.async_configure(
two_factor_verify_form["flow_id"],
user_input={config_flow.CONF_VALIDATION_CODE: "123456"},
)
assert len(mock_two_factor_verify.mock_calls) == 1
assert len(mock_is_in_required.mock_calls) == 1
assert result["type"] is FlowResultType.FORM
assert result["step_id"] == "pin"
with (
patch(MOCK_API_TEST_PIN, return_value=True),
patch(MOCK_API_UPDATE_SAVED_PIN, return_value=True),
patch(ASYNC_SETUP_ENTRY, return_value=True),
):
result = await hass.config_entries.flow.async_configure(
result["flow_id"], user_input={CONF_PIN: TEST_PIN}
)
assert result["type"] is FlowResultType.CREATE_ENTRY
async def test_two_factor_verify_bad_format(
hass: HomeAssistant, two_factor_verify_form
) -> None:
"""Test two factor verification bad format."""
"""Test two factor verification bad format, and that the flow can still be completed afterward."""
with (
patch(
MOCK_API_2FA_VERIFY,
@@ -252,11 +294,22 @@ async def test_two_factor_verify_bad_format(
assert len(mock_is_pin_required.mock_calls) == 0
assert result["errors"] == {"base": "bad_validation_code_format"}
with (
patch(MOCK_API_2FA_VERIFY, return_value=True),
patch(MOCK_API_IS_PIN_REQUIRED, return_value=False),
patch(ASYNC_SETUP_ENTRY, return_value=True),
):
result = await hass.config_entries.flow.async_configure(
result["flow_id"],
user_input={config_flow.CONF_VALIDATION_CODE: "123456"},
)
assert result["type"] is FlowResultType.CREATE_ENTRY
async def test_two_factor_verify_fail(
hass: HomeAssistant, two_factor_verify_form
) -> None:
"""Test two factor verification failure."""
"""Test two factor verification failure, and that the flow can still be completed afterward."""
with (
patch(
MOCK_API_2FA_VERIFY,
@@ -272,25 +325,20 @@ async def test_two_factor_verify_fail(
assert len(mock_is_pin_required.mock_calls) == 0
assert result["errors"] == {"base": "incorrect_validation_code"}
async def test_pin_form_init(pin_form) -> None:
"""Test the pin entry form for second step of the config flow."""
expected = {
"data_schema": config_flow.PIN_SCHEMA,
"description_placeholders": None,
"errors": None,
"flow_id": mock.ANY,
"handler": DOMAIN,
"step_id": "pin",
"type": "form",
"last_step": None,
"preview": None,
}
assert pin_form == expected
with (
patch(MOCK_API_2FA_VERIFY, return_value=True),
patch(MOCK_API_IS_PIN_REQUIRED, return_value=False),
patch(ASYNC_SETUP_ENTRY, return_value=True),
):
result = await hass.config_entries.flow.async_configure(
result["flow_id"],
user_input={config_flow.CONF_VALIDATION_CODE: "123456"},
)
assert result["type"] is FlowResultType.CREATE_ENTRY
async def test_pin_form_bad_pin_format(hass: HomeAssistant, pin_form) -> None:
"""Test we handle invalid pin."""
"""Test we handle invalid pin, and that the flow can still be completed afterward."""
with (
patch(
MOCK_API_TEST_PIN,
@@ -308,6 +356,16 @@ async def test_pin_form_bad_pin_format(hass: HomeAssistant, pin_form) -> None:
assert result["type"] is FlowResultType.FORM
assert result["errors"] == {"base": "bad_pin_format"}
with (
patch(MOCK_API_TEST_PIN, return_value=True),
patch(MOCK_API_UPDATE_SAVED_PIN, return_value=True),
patch(ASYNC_SETUP_ENTRY, return_value=True),
):
result = await hass.config_entries.flow.async_configure(
result["flow_id"], user_input={CONF_PIN: TEST_PIN}
)
assert result["type"] is FlowResultType.CREATE_ENTRY
async def test_pin_form_success(hass: HomeAssistant, pin_form) -> None:
"""Test successful PIN entry."""
@@ -379,16 +437,11 @@ async def test_pin_form_incorrect_pin(hass: HomeAssistant, pin_form) -> None:
assert result["type"] is FlowResultType.CREATE_ENTRY
async def test_option_flow_form(options_form) -> None:
"""Test config flow options form."""
assert options_form["description_placeholders"] is None
assert options_form["errors"] is None
assert options_form["step_id"] == "init"
assert options_form["type"] is FlowResultType.FORM
async def test_option_flow(hass: HomeAssistant, options_form) -> None:
"""Test config flow options."""
assert options_form["type"] is FlowResultType.FORM
assert options_form["step_id"] == "init"
result = await hass.config_entries.options.async_configure(
options_form["flow_id"],
user_input={
@@ -404,9 +457,13 @@ async def test_option_flow(hass: HomeAssistant, options_form) -> None:
@pytest.fixture
async def user_form(hass: HomeAssistant) -> ConfigFlowResult:
"""Return initial form for Subaru config flow."""
return await hass.config_entries.flow.async_init(
result = await hass.config_entries.flow.async_init(
DOMAIN, context={"source": config_entries.SOURCE_USER}
)
assert result["type"] is FlowResultType.FORM
assert result["step_id"] == "user"
assert result["errors"] is None
return result
@pytest.fixture
@@ -455,10 +512,13 @@ async def pin_form(
),
patch(MOCK_API_IS_PIN_REQUIRED, return_value=True),
):
return await hass.config_entries.flow.async_configure(
result = await hass.config_entries.flow.async_configure(
two_factor_verify_form["flow_id"],
user_input={config_flow.CONF_VALIDATION_CODE: "123456"},
)
assert result["type"] is FlowResultType.FORM
assert result["step_id"] == "pin"
return result
@pytest.fixture