Home-Assistant/supervisor
1
0
Fork 0
mirror of https://github.com/home-assistant/supervisor.git synced 2026-09-12 19:49:50 +01:00
Code Activity

Reduce app config schema warning noise for regular users (#7071)

Browse Source 
* Lower app config advisory log level for non-local store apps

App config deprecation and misconfiguration advisories were logged at
warning level for every app in every store repository on each store
reload. Because store data is validated for all available apps, not just
installed ones, regular users saw "Please report this to the maintainer"
warnings for apps they had never installed and could not fix, which is
confusing and backwards for that audience.

Route these advisories through an injected logging callable so the store
data layer can pick the level that matches who can act on them. Apps from
the local repository (authored by the user) and any app on the dev channel
(a developer testing store apps) still log at warning level; everything
else logs at debug, keeping the messages available for troubleshooting
without spamming regular users' logs. Installed apps re-validated from
apps.json on every boot now also log at debug, since they were already
migrated and their advisories logged when first read from the store.

Reword the messages to state the deprecation or misconfiguration as a fact
instead of asking the reader to report it to the maintainer, since the
remaining warning-level audiences are the ones who can address it directly.
The hard rejection for a dynamic ingress port conflict keeps its existing
wording, as it aborts loading regardless of channel.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Also warn for installed apps from custom repositories

The initial change kept app config advisories at warning level only for
the local repository and the dev channel, silencing them for every store
app on stable/beta. Review feedback pointed out that this also hides the
warning for installed apps whose maintainer has moved on - often thin
wrapper apps in custom repositories where the warning is the user's only
heads-up before the app breaks.

Warn for installed apps from custom (non-built-in) repositories as well.
Apps from the curated built-in stores (Core, Community, ESPHome, Music
Assistant) stay quiet even when installed, since deprecations there are
fixed via PRs and are not actionable for the user. Uninstalled apps
remain quiet everywhere.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Stefan Agner
2026-07-22 10:22:26 +02:00
committed by GitHub
co-authored by Claude Opus 4.8
parent 8ec96209f2
commit 74fa31f886
4 changed files with 308 additions and 143 deletions
Download Patch File Download Diff File Expand all files Collapse all files
supervisor/apps/validate.py
+163 -134
View File
@@ -1,5 +1,6 @@
"""Validate apps options schema."""
from collections.abc import Callable
import logging
import re
import secrets
@@ -187,107 +188,125 @@ RE_MACHINE = re.compile(
RE_SLUG_FIELD = re.compile(r"^" + RE_SLUG + r"$")
def _warn_app_config(config: dict[str, Any]):
"""Warn about miss configs."""
name = config.get(ATTR_NAME)
if not name:
raise vol.Invalid("Invalid app config!")
def _warn_app_config(log: Callable[..., None]):
"""Build a validator that flags questionable app configs.
if ATTR_ADVANCED in config:
# Deprecated since Supervisor 2026.03.0; this field is ignored and the
# warning can be removed once that version is the minimum supported.
_LOGGER.warning(
"App '%s' uses deprecated 'advanced' field in config. "
"This field is ignored by the Supervisor. Please report this to the maintainer.",
name,
)
Deprecation and misconfiguration advisories are emitted through ``log`` so
the caller can pick the level appropriate for the audience (see
SCHEMA_APP_CONFIG vs. SCHEMA_APP_CONFIG_QUIET). The messages are addressed at
whoever can act on them (a local app's author or a developer on the dev
channel), so they intentionally do not ask the reader to contact a
maintainer.
"""
if config.get(ATTR_FULL_ACCESS, False) and (
config.get(ATTR_DEVICES)
or config.get(ATTR_UART)
or config.get(ATTR_USB)
or config.get(ATTR_GPIO)
):
_LOGGER.warning(
"App has full device access, and selective device access in the configuration. Please report this to the maintainer of %s",
name,
)
def _warn(config: dict[str, Any]):
name = config.get(ATTR_NAME)
if not name:
raise vol.Invalid("Invalid app config!")
if config.get(ATTR_BACKUP, AppBackupMode.HOT) == AppBackupMode.COLD and (
config.get(ATTR_BACKUP_POST) or config.get(ATTR_BACKUP_PRE)
):
_LOGGER.warning(
"An app that only supports COLD backups is trying to use pre/post commands. Please report this to the maintainer of %s",
name,
)
if deprecated_arches := [
arch for arch in config.get(ATTR_ARCH, []) if arch in ARCH_DEPRECATED
]:
_LOGGER.warning(
"App config 'arch' uses deprecated values %s. Please report this to the maintainer of %s",
deprecated_arches,
name,
)
if deprecated_machines := [
machine
for machine in config.get(ATTR_MACHINE, [])
if machine.lstrip("!") in MACHINE_DEPRECATED
]:
_LOGGER.warning(
"App config 'machine' uses deprecated values %s. Please report this to the maintainer of %s",
deprecated_machines,
name,
)
if ATTR_CODENOTARY in config:
_LOGGER.warning(
"App '%s' uses deprecated 'codenotary' field in config. This field is no longer used and will be ignored. Please report this to the maintainer.",
name,
)
# Deprecated map types, deprecated as of 2026.07
_LEGACY_MAP_TYPES = {
MappingType.ADDONS: MappingType.LOCAL_APPS,
MappingType.ALL_ADDON_CONFIGS: MappingType.ALL_APP_CONFIGS,
MappingType.ADDON_CONFIG: MappingType.APP_CONFIG,
}
for volume in config[ATTR_MAP]:
if (volume_type := volume[ATTR_TYPE]) in _LEGACY_MAP_TYPES:
_LOGGER.warning(
"App '%s' uses legacy map type '%s'. Please update to '%s'. Please report this to the maintainer.",
if ATTR_ADVANCED in config:
# Deprecated since Supervisor 2026.03.0; this field is ignored and
# the advisory can be removed once that version is the minimum
# supported.
log(
"App '%s' uses the deprecated 'advanced' config field, which is ignored.",
name,
volume_type,
_LEGACY_MAP_TYPES[volume_type],
)
# Dynamic ingress port selection (ingress_port: 0) picks a random port from
# the INGRESS_DYNAMIC_PORT_MIN-INGRESS_DYNAMIC_PORT_MAX range. An app must
# not map a port from that range to the host itself, as the dynamically
# chosen ingress port could then coincide with it, exposing the ingress
# endpoint on the host and bypassing ingress authentication.
if config.get(ATTR_INGRESS) and config.get(ATTR_INGRESS_PORT) == 0:
for container_port in config.get(ATTR_PORTS, {}):
port_number = str(container_port).partition("/")[0]
if (
port_number.isdigit()
and INGRESS_DYNAMIC_PORT_MIN
<= int(port_number)
<= INGRESS_DYNAMIC_PORT_MAX
):
raise vol.Invalid(
f"App '{name}' uses dynamic ingress port selection (ingress_port: 0) "
f"but maps port {port_number} which is reserved for dynamic ingress "
f"ports ({INGRESS_DYNAMIC_PORT_MIN}-{INGRESS_DYNAMIC_PORT_MAX}). "
"Please report this to the maintainer of the app."
if config.get(ATTR_FULL_ACCESS, False) and (
config.get(ATTR_DEVICES)
or config.get(ATTR_UART)
or config.get(ATTR_USB)
or config.get(ATTR_GPIO)
):
log(
"App '%s' has full device access; its selective device access configuration is redundant and ignored.",
name,
)
if config.get(ATTR_BACKUP, AppBackupMode.HOT) == AppBackupMode.COLD and (
config.get(ATTR_BACKUP_POST) or config.get(ATTR_BACKUP_PRE)
):
log(
"App '%s' only supports COLD backups but configures pre/post backup commands, which are ignored.",
name,
)
if deprecated_arches := [
arch for arch in config.get(ATTR_ARCH, []) if arch in ARCH_DEPRECATED
]:
log(
"App '%s' uses deprecated 'arch' values: %s",
name,
deprecated_arches,
)
if deprecated_machines := [
machine
for machine in config.get(ATTR_MACHINE, [])
if machine.lstrip("!") in MACHINE_DEPRECATED
]:
log(
"App '%s' uses deprecated 'machine' values: %s",
name,
deprecated_machines,
)
if ATTR_CODENOTARY in config:
log(
"App '%s' uses the deprecated 'codenotary' config field, which is no longer used and ignored.",
name,
)
# Deprecated map types, deprecated as of 2026.07
_LEGACY_MAP_TYPES = {
MappingType.ADDONS: MappingType.LOCAL_APPS,
MappingType.ALL_ADDON_CONFIGS: MappingType.ALL_APP_CONFIGS,
MappingType.ADDON_CONFIG: MappingType.APP_CONFIG,
}
for volume in config[ATTR_MAP]:
if (volume_type := volume[ATTR_TYPE]) in _LEGACY_MAP_TYPES:
log(
"App '%s' uses legacy map type '%s'; use '%s' instead.",
name,
volume_type,
_LEGACY_MAP_TYPES[volume_type],
)
return config
# Dynamic ingress port selection (ingress_port: 0) picks a random port
# from the INGRESS_DYNAMIC_PORT_MIN-INGRESS_DYNAMIC_PORT_MAX range. An
# app must not map a port from that range to the host itself, as the
# dynamically chosen ingress port could then coincide with it, exposing
# the ingress endpoint on the host and bypassing ingress authentication.
if config.get(ATTR_INGRESS) and config.get(ATTR_INGRESS_PORT) == 0:
for container_port in config.get(ATTR_PORTS, {}):
port_number = str(container_port).partition("/")[0]
if (
port_number.isdigit()
and INGRESS_DYNAMIC_PORT_MIN
<= int(port_number)
<= INGRESS_DYNAMIC_PORT_MAX
):
raise vol.Invalid(
f"App '{name}' uses dynamic ingress port selection (ingress_port: 0) "
f"but maps port {port_number} which is reserved for dynamic ingress "
f"ports ({INGRESS_DYNAMIC_PORT_MIN}-{INGRESS_DYNAMIC_PORT_MAX}). "
"Please report this to the maintainer of the app."
)
return config
return _warn
def _migrate_app_config(protocol=False):
"""Migrate app config."""
def _migrate_app_config(log: Callable[..., None]):
"""Migrate app config.
Deprecated-format advisories are emitted through ``log`` so the caller can
pick the level appropriate for the audience (see SCHEMA_APP_CONFIG vs.
SCHEMA_APP_CONFIG_QUIET). The migration itself always happens regardless of
the level.
"""
def _migrate(config: dict[str, Any]):
if not isinstance(config, dict):
@@ -299,12 +318,11 @@ def _migrate_app_config(protocol=False):
# Startup 2018-03-30
if config.get(ATTR_STARTUP) in ("before", "after"):
value = config[ATTR_STARTUP]
if protocol:
_LOGGER.warning(
"App config 'startup' with '%s' is deprecated. Please report this to the maintainer of %s",
value,
name,
)
log(
"App '%s' uses deprecated 'startup' value '%s'.",
name,
value,
)
if value == "before":
config[ATTR_STARTUP] = AppStartup.SERVICES
elif value == "after":
@@ -312,29 +330,26 @@ def _migrate_app_config(protocol=False):
# UART 2021-01-20
if "auto_uart" in config:
if protocol:
_LOGGER.warning(
"App config 'auto_uart' is deprecated, use 'uart'. Please report this to the maintainer of %s",
name,
)
log(
"App '%s' uses deprecated 'auto_uart'; use 'uart' instead.",
name,
)
config[ATTR_UART] = config.pop("auto_uart")
# Device 2021-01-20
if ATTR_DEVICES in config and any(":" in line for line in config[ATTR_DEVICES]):
if protocol:
_LOGGER.warning(
"App config 'devices' uses a deprecated format instead of a list of paths only. Please report this to the maintainer of %s",
name,
)
log(
"App '%s' uses a deprecated 'devices' format; use a list of paths only.",
name,
)
config[ATTR_DEVICES] = [line.split(":")[0] for line in config[ATTR_DEVICES]]
# TMPFS 2021-02-01
if ATTR_TMPFS in config and not isinstance(config[ATTR_TMPFS], bool):
if protocol:
_LOGGER.warning(
"App config 'tmpfs' uses a deprecated format instead of just a boolean. Please report this to the maintainer of %s",
name,
)
log(
"App '%s' uses a deprecated 'tmpfs' format; use a boolean instead.",
name,
)
config[ATTR_TMPFS] = True
# 2021-06 "snapshot" renamed to "backup"
@@ -347,11 +362,11 @@ def _migrate_app_config(protocol=False):
if entry in config:
new_entry = entry.replace("snapshot", "backup")
config[new_entry] = config.pop(entry)
_LOGGER.warning(
"App config '%s' is deprecated, '%s' should be used instead. Please report this to the maintainer of %s",
log(
"App '%s' uses deprecated config '%s'; use '%s' instead.",
name,
entry,
new_entry,
name,
)
# 2023-11 "map" entries can also be dict to allow path configuration
@@ -360,20 +375,20 @@ def _migrate_app_config(protocol=False):
if isinstance(entry, dict):
# Validate that dict entries have required 'type' field
if ATTR_TYPE not in entry:
_LOGGER.warning(
"App config has invalid map entry missing 'type' field: %s. Skipping invalid entry for %s",
entry,
log(
"App '%s' has an invalid map entry missing the 'type' field, skipping: %s",
name,
entry,
)
continue
volumes.append(entry)
if isinstance(entry, str):
result = RE_VOLUME.match(entry)
if not result:
_LOGGER.warning(
"App config has invalid map entry: %s. Skipping invalid entry for %s",
entry,
log(
"App '%s' has an invalid map entry, skipping: %s",
name,
entry,
)
continue
volumes.append(
@@ -398,20 +413,20 @@ def _migrate_app_config(protocol=False):
}
for volume in volumes
):
_LOGGER.warning(
"App config using incompatible map options, '%s', '%s', and '%s' are ignored if '%s' is included. Please report this to the maintainer of %s",
log(
"App '%s' uses incompatible map options; '%s', '%s', and '%s' are ignored when '%s' is included.",
name,
MappingType.APP_CONFIG,
MappingType.ADDON_CONFIG,
MappingType.HOMEASSISTANT_CONFIG,
MappingType.CONFIG,
name,
)
else:
_LOGGER.debug(
"App config using deprecated map option '%s' instead of '%s'. Please report this to the maintainer of %s",
log(
"App '%s' uses deprecated map option '%s'; use '%s' instead.",
name,
MappingType.CONFIG,
MappingType.HOMEASSISTANT_CONFIG,
name,
)
# 2026-07 addon-based map options replaced by app-based options.
@@ -422,12 +437,12 @@ def _migrate_app_config(protocol=False):
(MappingType.APP_CONFIG, MappingType.ADDON_CONFIG),
):
if {app_mapping_type, legacy_mapping_type} <= volume_types:
_LOGGER.warning(
"App config using incompatible map options, '%s' and '%s'. Legacy option '%s' will be ignored. Please report this to the maintainer of %s",
log(
"App '%s' uses incompatible map options '%s' and '%s'; legacy option '%s' will be ignored.",
name,
app_mapping_type,
legacy_mapping_type,
legacy_mapping_type,
name,
)
return config
@@ -541,9 +556,20 @@ _SCHEMA_APP_CONFIG = vol.Schema(
extra=vol.REMOVE_EXTRA,
)
SCHEMA_APP_CONFIG = vol.All(
_migrate_app_config(True), _warn_app_config, _SCHEMA_APP_CONFIG
)
def _build_app_config_schema(log: Callable[..., None]):
"""Build the store app config schema, routing advisories through log."""
return vol.All(_migrate_app_config(log), _warn_app_config(log), _SCHEMA_APP_CONFIG)
# Store app configs are validated on every store reload for every app in every
# repository, including ones the user has not installed. The advisories they
# raise are only actionable for a local app's author or a developer testing on
# the dev channel, so the store data layer validates with the verbose schema
# only in those cases and uses the quiet (debug-level) schema otherwise, to keep
# them out of regular users' logs.
SCHEMA_APP_CONFIG = _build_app_config_schema(_LOGGER.warning)
SCHEMA_APP_CONFIG_QUIET = _build_app_config_schema(_LOGGER.debug)
# pylint: disable=no-value-for-parameter
@@ -603,7 +629,10 @@ SCHEMA_APP_USER = vol.Schema(
)
SCHEMA_APP_SYSTEM = vol.All(
_migrate_app_config(),
# Installed app config is re-validated from apps.json on every startup. It
# was already migrated (and any advisory logged) when read from the store,
# so keep these at debug level to avoid repeating them on each boot.
_migrate_app_config(_LOGGER.debug),
_SCHEMA_APP_CONFIG.extend(
{
# The source location is owned by the store and resolved at runtime
supervisor/store/data.py
+34 -2
View File
@@ -9,7 +9,11 @@ from typing import Any
import voluptuous as vol
from voluptuous.humanize import humanize_error
from ..apps.validate import SCHEMA_APP_CONFIG, SCHEMA_APP_TRANSLATIONS
from ..apps.validate import (
SCHEMA_APP_CONFIG,
SCHEMA_APP_CONFIG_QUIET,
SCHEMA_APP_TRANSLATIONS,
)
from ..const import (
ATTR_LOCATION,
ATTR_REPOSITORY,
@@ -19,6 +23,7 @@ from ..const import (
FILE_SUFFIX_CONFIGURATION,
REPOSITORY_CORE,
REPOSITORY_LOCAL,
UpdateChannel,
)
from ..coresys import CoreSys, CoreSysAttributes
from ..exceptions import ConfigurationFileError
@@ -184,6 +189,24 @@ class StoreData(CoreSysAttributes):
if not (app_config_list := await self._find_app_configs(path, repository)):
return {}
# App config deprecation/misconfiguration advisories are only actionable
# for someone who can fix the app, so only those cases log at warning
# level; everything else stays at debug so regular users don't see
# warnings for apps they cannot fix. Warn for the local repository
# (authored by the user), on the dev channel (a developer testing store
# apps), and for installed apps from custom repositories - the latter
# are often thin wrappers whose maintainer may have moved on, where the
# warning is the user's only heads-up before it breaks. Uninstalled apps
# and apps from the curated built-in stores (which get fixed via PRs)
# stay quiet.
repository_obj = self.sys_store.repositories.get(repository)
repository_is_builtin = bool(repository_obj and repository_obj.is_builtin)
always_verbose = (
repository == REPOSITORY_LOCAL
or self.sys_updater.channel == UpdateChannel.DEV
)
installed_slugs = {app.slug for app in self.sys_apps.installed}
def _process_apps_config() -> dict[str, dict[str, Any]]:
apps: dict[str, dict[str, Any]] = {}
for app_config in app_config_list:
@@ -195,9 +218,18 @@ class StoreData(CoreSysAttributes):
)
continue
# Pick the advisory log level based on who can act on it (see
# above). The slug is available in the raw config before
# validation.
verbose = always_verbose or (
not repository_is_builtin
and f"{repository}_{app.get(ATTR_SLUG)}" in installed_slugs
)
schema = SCHEMA_APP_CONFIG if verbose else SCHEMA_APP_CONFIG_QUIET
# validate
try:
app = SCHEMA_APP_CONFIG(app)
app = schema(app)
except vol.Invalid as ex:
_LOGGER.warning(
"Can't read %s: %s", app_config, humanize_error(app, ex)
tests/apps/test_config.py
+30 -6
View File
@@ -1,5 +1,7 @@
"""Validate App configs."""
import logging
import pytest
import voluptuous as vol
@@ -255,7 +257,7 @@ def test_warn_legacy_arch_values(caplog: pytest.LogCaptureFixture):
vd.SCHEMA_APP_CONFIG(config)
assert "App config 'arch' uses deprecated values" in caplog.text
assert "uses deprecated 'arch' values" in caplog.text
def test_warn_legacy_machine_values(caplog: pytest.LogCaptureFixture):
@@ -265,7 +267,7 @@ def test_warn_legacy_machine_values(caplog: pytest.LogCaptureFixture):
vd.SCHEMA_APP_CONFIG(config)
assert "App config 'machine' uses deprecated values" in caplog.text
assert "uses deprecated 'machine' values" in caplog.text
def test_warn_advanced_deprecated(caplog: pytest.LogCaptureFixture):
@@ -275,7 +277,7 @@ def test_warn_advanced_deprecated(caplog: pytest.LogCaptureFixture):
vd.SCHEMA_APP_CONFIG(config)
assert "uses deprecated 'advanced' field in config" in caplog.text
assert "uses the deprecated 'advanced' config field" in caplog.text
@pytest.mark.parametrize(
@@ -298,7 +300,29 @@ def test_warn_legacy_map_types(
vd.SCHEMA_APP_CONFIG(config)
assert f"uses legacy map type '{legacy_mapping}'" in caplog.text
assert f"Please update to '{app_mapping}'" in caplog.text
assert f"use '{app_mapping}' instead" in caplog.text
def test_quiet_schema_logs_advisories_at_debug(caplog: pytest.LogCaptureFixture):
"""SCHEMA_APP_CONFIG_QUIET emits the same advisories, but at debug level."""
config = load_json_fixture("basic-app-config.json")
config["advanced"] = True
config["arch"] = ["armv7", "amd64"]
with caplog.at_level(logging.DEBUG, logger="supervisor.apps.validate"):
vd.SCHEMA_APP_CONFIG_QUIET(config)
# The advisories are still emitted, so they remain available in debug logs.
assert "uses the deprecated 'advanced' config field" in caplog.text
assert "uses deprecated 'arch' values" in caplog.text
# But never at warning level, so regular users don't see them.
assert not [
record
for record in caplog.records
if record.name == "supervisor.apps.validate"
and record.levelno >= logging.WARNING
]
@pytest.mark.parametrize(
@@ -320,10 +344,10 @@ def test_warn_incompatible_map_types_legacy_ignored(
vd.SCHEMA_APP_CONFIG(config)
assert "using incompatible map options" in caplog.text
assert "uses incompatible map options" in caplog.text
assert f"'{app_mapping}'" in caplog.text
assert f"'{legacy_mapping}'" in caplog.text
assert f"Legacy option '{legacy_mapping}' will be ignored" in caplog.text
assert f"legacy option '{legacy_mapping}' will be ignored" in caplog.text
async def test_valid_manifest_build():
tests/store/test_reading_apps.py
+81 -1
View File
@@ -1,13 +1,21 @@
"""Test that we are reading app files correctly."""
import errno
import json
import logging
from pathlib import Path
from unittest.mock import patch
from types import SimpleNamespace
from unittest.mock import AsyncMock, PropertyMock, patch
import pytest
from supervisor.const import REPOSITORY_LOCAL, UpdateChannel
from supervisor.coresys import CoreSys
from supervisor.resolution.const import ContextType, IssueType, SuggestionType
from supervisor.resolution.data import Issue, Suggestion
from tests.common import load_json_fixture
# pylint: disable=protected-access
@@ -51,3 +59,75 @@ async def test_reading_app_files_error(coresys: CoreSys):
assert corrupt_repo in coresys.resolution.issues
assert reset_repo not in coresys.resolution.suggestions
assert coresys.core.healthy is False
@pytest.mark.parametrize(
("repository", "channel", "installed", "builtin", "expect_warning"),
[
# A local app's author can act on the advisory.
(REPOSITORY_LOCAL, UpdateChannel.STABLE, False, True, True),
# A developer on the dev channel is testing store apps, so surface it.
("094b3f00", UpdateChannel.DEV, False, False, True),
# An uninstalled store app cannot be acted on by the user; stay quiet.
("094b3f00", UpdateChannel.STABLE, False, False, False),
# An installed app from a custom repo may be unmaintained; warn so the
# user gets a heads-up.
("094b3f00", UpdateChannel.STABLE, True, False, True),
# An installed app from a curated built-in store gets fixed via PRs;
# keep it out of the user's logs even though it is installed.
("094b3f00", UpdateChannel.STABLE, True, True, False),
],
)
async def test_deprecation_advisory_log_level(
coresys: CoreSys,
tmp_path: Path,
caplog: pytest.LogCaptureFixture,
repository: str,
channel: UpdateChannel,
installed: bool,
builtin: bool,
expect_warning: bool,
):
"""Advisories only warn where the message is actionable for the reader."""
config = load_json_fixture("basic-app-config.json")
config["advanced"] = True # Deprecated field, triggers an advisory.
config_file = tmp_path / "config.json"
config_file.write_text(json.dumps(config), encoding="utf-8")
coresys.updater.channel = channel
app_slug = f"{repository}_{config['slug']}"
installed_apps = [SimpleNamespace(slug=app_slug)] if installed else []
with (
patch.object(
coresys.store.data,
"_find_app_configs",
AsyncMock(return_value=[config_file]),
),
patch.object(
type(coresys.apps),
"installed",
new_callable=PropertyMock,
return_value=installed_apps,
),
patch.dict(
coresys.store.repositories,
{repository: SimpleNamespace(is_builtin=builtin)},
),
caplog.at_level(logging.DEBUG, logger="supervisor.apps.validate"),
):
apps = await coresys.store.data._read_apps_folder(tmp_path, repository)
assert apps # Config parsed successfully.
advisories = [
record
for record in caplog.records
if record.name == "supervisor.apps.validate"
and "deprecated 'advanced'" in record.getMessage()
]
assert advisories # The advisory is always emitted at some level.
assert (
any(record.levelno >= logging.WARNING for record in advisories)
is expect_warning
)