mirror of
https://github.com/home-assistant/supervisor.git
synced 2026-08-25 07:32:12 +01:00
74fa31f886
* Lower app config advisory log level for non-local store apps App config deprecation and misconfiguration advisories were logged at warning level for every app in every store repository on each store reload. Because store data is validated for all available apps, not just installed ones, regular users saw "Please report this to the maintainer" warnings for apps they had never installed and could not fix, which is confusing and backwards for that audience. Route these advisories through an injected logging callable so the store data layer can pick the level that matches who can act on them. Apps from the local repository (authored by the user) and any app on the dev channel (a developer testing store apps) still log at warning level; everything else logs at debug, keeping the messages available for troubleshooting without spamming regular users' logs. Installed apps re-validated from apps.json on every boot now also log at debug, since they were already migrated and their advisories logged when first read from the store. Reword the messages to state the deprecation or misconfiguration as a fact instead of asking the reader to report it to the maintainer, since the remaining warning-level audiences are the ones who can address it directly. The hard rejection for a dynamic ingress port conflict keeps its existing wording, as it aborts loading regardless of channel. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * Also warn for installed apps from custom repositories The initial change kept app config advisories at warning level only for the local repository and the dev channel, silencing them for every store app on stable/beta. Review feedback pointed out that this also hides the warning for installed apps whose maintainer has moved on - often thin wrapper apps in custom repositories where the warning is the user's only heads-up before the app breaks. Warn for installed apps from custom (non-built-in) repositories as well. Apps from the curated built-in stores (Core, Community, ESPHome, Music Assistant) stay quiet even when installed, since deprecations there are fixed via PRs and are not actionable for the user. Uninstalled apps remain quiet everywhere. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>