Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2025-12-23 11:49:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

Always log tsserver exit code, even for kill processes (#156378)

Browse Source 
We suspect that some exit code info is being dropped since 1.61. Changing this code to always log, even when the user manually restarts the server
This commit is contained in:
Matt Bierner
2022-07-27 11:54:24 -07:00
committed by GitHub
parent 59afa0a8ee
commit 00bb9bdefc
1 changed files with 5 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
extensions/typescript-language-features/src/typescriptServiceClient.ts
View File

@@ -430,13 +430,7 @@ export default class TypeScriptServiceClient extends Disposable implements IType
}); });
handle.onExit((data: TypeScriptServerExitEvent) => { handle.onExit((data: TypeScriptServerExitEvent) => {
if (this.token !== mytoken) {
// this is coming from an old process
return;
}
const { code, signal } = data; const { code, signal } = data;
if (code === null || typeof code === 'undefined') { if (code === null || typeof code === 'undefined') {
this.info(`TSServer exited. Signal: ${signal}`); this.info(`TSServer exited. Signal: ${signal}`);
} else { } else {
@@ -456,6 +450,11 @@ export default class TypeScriptServiceClient extends Disposable implements IType
this.logTelemetry('tsserver.exitWithCode', { code, signal: signal ?? undefined }); this.logTelemetry('tsserver.exitWithCode', { code, signal: signal ?? undefined });
} }
if (this.token !== mytoken) {
// this is coming from an old process
return;
}
if (handle.tsServerLogFile) { if (handle.tsServerLogFile) {
this.info(`TSServer log file: ${handle.tsServerLogFile}`); this.info(`TSServer log file: ${handle.tsServerLogFile}`);
} }