Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-05-16 05:11:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

Use Set instead of array

Browse Source 
Sets should offer faster checking to see if a property has been seen
This commit is contained in:
Matt Bierner
2020-09-11 14:29:00 -07:00
parent 8a6b38e4ef
commit 02e6fa2ddd
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/vs/base/common/objects.ts
+5 -5
View File
@@ -179,18 +179,18 @@ export function equals(one: any, other: any): boolean {
}
/**
* Calls JSON.Stringify with a replacer to break apart any circular references.
* This prevents JSON.stringify from throwing the exception
* Calls `JSON.Stringify` with a replacer to break apart any circular references.
* This prevents `JSON`.stringify` from throwing the exception
* "Uncaught TypeError: Converting circular structure to JSON"
*/
export function safeStringify(obj: any): string {
const seen: any[] = [];
const seen = new Set<any>();
return JSON.stringify(obj, (key, value) => {
if (isObject(value) || Array.isArray(value)) {
if (seen.indexOf(value) !== -1) {
if (seen.has(value)) {
return '[Circular]';
} else {
seen.push(value);
seen.add(value);
}
}
return value;