Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-02 08:15:56 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #306330 from microsoft/isidorn/gorgeous-bee

Browse Source 
log requestUnsandboxesExecutionReason
This commit is contained in:
Isidor Nikolic
2026-03-30 15:51:11 +02:00
committed by GitHub
parent a2d7b9e13b 3cbe1c0739
commit 0705ebef87
2 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/vs/workbench/contrib/terminalContrib/chatAgentTools/browser/runInTerminalToolTelemetry.ts
View File

@@ -95,6 +95,7 @@ export class RunInTerminalToolTelemetry {
isBackground: boolean;
isNewSession: boolean;
isSandboxWrapped: boolean;
requestUnsandboxedExecutionReason: string | undefined;
shellIntegrationQuality: ShellIntegrationQuality;
outputLineCount: number;
timingConnectMs: number;
@@ -124,6 +125,7 @@ export class RunInTerminalToolTelemetry {
isBackground: 0 | 1;
isNewSession: 0 | 1;
isSandbox: 0 | 1;
requestUnsandboxedExecutionReason: string | undefined;
outputLineCount: number;
nonZeroExitCode: -1 | 0 | 1;
timingConnectMs: number;
@@ -154,6 +156,7 @@ export class RunInTerminalToolTelemetry {
isBackground: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; isMeasurement: true; comment: 'Whether the command is a background command' };
isNewSession: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; isMeasurement: true; comment: 'Whether this was the first execution for the terminal session' };
isSandbox: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; isMeasurement: true; comment: 'Whether the command was run inside the terminal sandbox' };
requestUnsandboxedExecutionReason: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'The reason the model gave for requesting unsandboxed execution, if any' };
outputLineCount: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; isMeasurement: true; comment: 'How many lines of output were produced, this is -1 when isBackground is true or if there\'s an error' };
nonZeroExitCode: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; isMeasurement: true; comment: 'Whether the command exited with a non-zero code (-1=error/unknown, 0=zero exit code, 1=non-zero)' };
timingConnectMs: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; isMeasurement: true; comment: 'How long the terminal took to start up and connect to' };
@@ -181,6 +184,7 @@ export class RunInTerminalToolTelemetry {
isBackground: state.isBackground ? 1 : 0,
isNewSession: state.isNewSession ? 1 : 0,
isSandbox: state.isSandboxWrapped ? 1 : 0,
requestUnsandboxedExecutionReason: state.requestUnsandboxedExecutionReason,
outputLineCount: state.outputLineCount,
nonZeroExitCode: state.exitCode === undefined ? -1 : state.exitCode === 0 ? 0 : 1,
timingConnectMs: state.timingConnectMs,

1
src/vs/workbench/contrib/terminalContrib/chatAgentTools/browser/tools/runInTerminalTool.ts
View File

@@ -1332,6 +1332,7 @@ export class RunInTerminalTool extends Disposable implements IToolImpl {
didToolEditCommand,
isBackground: args.isBackground,
isSandboxWrapped: toolSpecificData.commandLine.isSandboxWrapped === true,
requestUnsandboxedExecutionReason: args.requestUnsandboxedExecutionReason,
shellIntegrationQuality: toolTerminal.shellIntegrationQuality,
error,
isNewSession,