Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-02 00:09:30 +01:00
Code Issues Packages Projects Releases Wiki Activity

Address reviewer comments: aria-label, hover-visible tracking, timer disposal, text-overflow

Browse Source 
Agent-Logs-Url: https://github.com/microsoft/vscode/sessions/3b58dad8-824f-4cdd-bb5d-c21511761b7d

Co-authored-by: eli-w-king <201316543+eli-w-king@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot]
2026-04-01 00:50:10 +00:00
committed by GitHub
parent 9e2dc5105a
commit 0d55cad523
2 changed files with 17 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/vs/workbench/contrib/update/browser/media/updateTitleBarEntry.css
View File

@@ -31,6 +31,7 @@
font-size: var(--vscode-bodyFontSize-small);
position: relative;
overflow: hidden;
text-overflow: ellipsis;
transition: max-width 0.3s ease, opacity 0.2s ease, margin-left 0.3s ease;
}
@@ -41,6 +42,7 @@
opacity: 0;
overflow: hidden;
white-space: nowrap;
text-overflow: ellipsis;
font-size: var(--vscode-bodyFontSize-small);
margin-left: 0;
transition: max-width 0.5s cubic-bezier(0.4, 0, 0.2, 1), opacity 0.3s ease 0.15s, margin-left 0.3s ease;

16
src/vs/workbench/contrib/update/browser/updateTitleBarEntry.ts
View File

@@ -231,6 +231,7 @@ export class UpdateTitleBarEntry extends BaseActionViewItem {
private showTooltipOnRender = false;
private hintTimer: ReturnType<typeof setTimeout> | undefined;
private currentStateType: StateType | undefined;
private hoverVisible = false;
constructor(
action: IAction,
@@ -247,6 +248,12 @@ export class UpdateTitleBarEntry extends BaseActionViewItem {
this.action.run = () => this.runAction();
this._register(this.updateService.onStateChange(state => this.onStateChange(state)));
this._register(toDisposable(() => {
if (this.hintTimer !== undefined) {
clearTimeout(this.hintTimer);
this.hintTimer = undefined;
}
}));
}
public override render(container: HTMLElement) {
@@ -273,6 +280,7 @@ export class UpdateTitleBarEntry extends BaseActionViewItem {
return;
}
this.hoverVisible = true;
this.content.classList.add('hint-visible');
this.hoverService.showInstantHover({
@@ -280,6 +288,7 @@ export class UpdateTitleBarEntry extends BaseActionViewItem {
target: {
targetElements: [this.content],
dispose: () => {
this.hoverVisible = false;
if (!!this.content?.isConnected) {
this.content.classList.remove('hint-visible');
this.onUserDismissedTooltip();
@@ -294,6 +303,8 @@ export class UpdateTitleBarEntry extends BaseActionViewItem {
protected override updateTooltip(): void {
// Tooltip is handled by showTooltip/showInstantHover which track
// hint-visible to keep the button expanded while the tooltip is open.
// Still update aria-label so the element is accessible to screen readers.
this.updateAriaLabel();
}
protected override getHoverContents(): IManagedHoverContent {
@@ -353,7 +364,10 @@ export class UpdateTitleBarEntry extends BaseActionViewItem {
}
dom.clearNode(this.content);
this.content.classList.remove('prominent', 'progress-indefinite', 'progress-percent', 'update-disabled', 'hint-visible');
this.content.classList.remove('prominent', 'progress-indefinite', 'progress-percent', 'update-disabled');
if (!this.hoverVisible) {
this.content.classList.remove('hint-visible');
}
this.content.style.removeProperty('--update-progress');
const label = dom.append(this.content, dom.$('.indicator-label'));