Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-09-25 17:27:26 +01:00
Code Issues Packages Projects Releases Wiki Activity

Remove instanceof check

Browse Source
This commit is contained in:
Alex Dima
2021-05-26 23:40:24 +02:00
parent 641c2b175c
commit 0feee9edef
2 changed files with 13 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/vs/editor/contrib/hover/colorHoverParticipant.ts
+6
View File
@@ -20,6 +20,12 @@ import { IThemeService } from 'vs/platform/theme/common/themeService';
export class ColorHover implements IHoverPart {
/**
* Force the hover to always be rendered at this specific range,
* even in the case of multiple hover parts.
*/
public readonly forceShowAtRange: boolean = true;
constructor(
public readonly owner: IEditorHoverParticipant<ColorHover>,
public readonly range: Range,
src/vs/editor/contrib/hover/modesContentHover.ts
+7 -2
View File
@@ -27,11 +27,16 @@ import { HoverWidget } from 'vs/base/browser/ui/hover/hoverWidget';
import { MarkerHoverParticipant } from 'vs/editor/contrib/hover/markerHoverParticipant';
import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation';
import { MarkdownHoverParticipant } from 'vs/editor/contrib/hover/markdownHoverParticipant';
import { ColorHover, ColorHoverParticipant } from 'vs/editor/contrib/hover/colorHoverParticipant';
import { ColorHoverParticipant } from 'vs/editor/contrib/hover/colorHoverParticipant';
export interface IHoverPart {
readonly owner: IEditorHoverParticipant;
readonly range: Range;
/**
* Force the hover to always be rendered at this specific range,
* even in the case of multiple hover parts.
*/
readonly forceShowAtRange?: boolean;
equals(other: IHoverPart): boolean;
}
@@ -453,7 +458,7 @@ export class ModesContentHoverWidget extends Widget implements IContentWidget, I
renderColumn = Math.min(renderColumn, msg.range.startColumn);
highlightRange = Range.plusRange(highlightRange, msg.range);
if (msg instanceof ColorHover) {
if (msg.forceShowAtRange) {
forceShowAtRange = msg.range;
}