Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-05-19 22:59:48 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix telemetry tests

Browse Source
This commit is contained in:
Logan Ramos
2021-09-22 13:10:20 -04:00
parent b092afa0d0
commit 0ff2fcbf69
1 changed files with 15 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/vs/platform/telemetry/test/browser/telemetryService.test.ts
+15 -2
View File
@@ -9,6 +9,7 @@ import * as Errors from 'vs/base/common/errors';
import { Emitter } from 'vs/base/common/event';
import { TestConfigurationService } from 'vs/platform/configuration/test/common/testConfigurationService';
import ErrorTelemetry from 'vs/platform/telemetry/browser/errorTelemetry';
import { ClassifiedEvent, GDPRClassification, StrictPropertyCheck } from 'vs/platform/telemetry/common/gdprTypings';
import { ITelemetryData, TelemetryConfiguration, TelemetryLevel } from 'vs/platform/telemetry/common/telemetry';
import { ITelemetryServiceConfig, TelemetryService } from 'vs/platform/telemetry/common/telemetryService';
import { ITelemetryAppender, NullAppender } from 'vs/platform/telemetry/common/telemetryUtils';
@@ -232,9 +233,21 @@ suite('TelemetryService', () => {
this.promises.push(p);
return p;
}
override publicLogError(errorEventName: string, data?: ITelemetryData): Promise<void> {
let p = super.publicLogError(errorEventName, data);
// publicLogError is called from the ctor and therefore promises can be undefined
this.promises = this.promises ?? [];
this.promises.push(p);
return p;
}
override publicLogError2<E extends ClassifiedEvent<T> = never, T extends GDPRClassification<T> = never>(eventName: string, data?: StrictPropertyCheck<T, E>): Promise<any> {
return this.publicLogError(eventName, data as ITelemetryData);
}
}
test.skip('Error events', sinonTestFn(async function (this: any) {
test('Error events', sinonTestFn(async function (this: any) {
let origErrorHandler = Errors.errorHandler.getUnexpectedErrorHandler();
Errors.setUnexpectedErrorHandler(() => { });
@@ -296,7 +309,7 @@ suite('TelemetryService', () => {
// }
// }));
test.skip('Handle global errors', sinonTestFn(async function (this: any) {
test('Handle global errors', sinonTestFn(async function (this: any) {
let errorStub = sinon.stub();
window.onerror = errorStub;