Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-02-14 23:18:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #295063 from microsoft/dev/dmitriv/flaky-download-fix

Browse Source 
Add retries for target download logic in sanity tests
This commit is contained in:
Dmitriy Vasyura
2026-02-12 16:56:59 -08:00
committed by GitHub
parent 631230f71b
commit 104123aaee
1 changed files with 30 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

42
test/sanity/src/context.ts
View File

@@ -298,21 +298,39 @@ export class TestContext {
const { url, sha256hash } = await this.fetchMetadata(target);
const filePath = path.join(this.createTempDir(), path.basename(url));
this.log(`Downloading ${url} to ${filePath}`);
const { body } = await this.fetchNoErrors(url);
const maxRetries = 5;
let lastError: Error | undefined;
const stream = fs.createWriteStream(filePath);
await new Promise<void>((resolve, reject) => {
body.on('error', reject);
stream.on('error', reject);
stream.on('finish', resolve);
body.pipe(stream);
});
for (let attempt = 0; attempt < maxRetries; attempt++) {
if (attempt > 0) {
const delay = Math.pow(2, attempt - 1) * 1000;
this.log(`Retrying download (attempt ${attempt + 1}/${maxRetries}) after ${delay}ms`);
await new Promise(resolve => setTimeout(resolve, delay));
}
this.log(`Downloaded ${url} to ${filePath}`);
this.validateSha256Hash(filePath, sha256hash);
try {
this.log(`Downloading ${url} to ${filePath}`);
const { body } = await this.fetchNoErrors(url);
return filePath;
const stream = fs.createWriteStream(filePath);
await new Promise<void>((resolve, reject) => {
body.on('error', reject);
stream.on('error', reject);
stream.on('finish', resolve);
body.pipe(stream);
});
this.log(`Downloaded ${url} to ${filePath}`);
this.validateSha256Hash(filePath, sha256hash);
return filePath;
} catch (error) {
lastError = error instanceof Error ? error : new Error(String(error));
this.log(`Download attempt ${attempt + 1} failed: ${lastError.message}`);
}
}
this.error(`Failed to download ${url} after ${maxRetries} attempts: ${lastError?.message}`);
}
/**