Show message when "auto" is detected

build/lib/util.js

@@ -252,7 +252,9 @@ exports.loadSourcemaps = function () {
 
 exports.rimraf = function(dir) {
 	return function (cb) {
-		rimraf(dir, cb);
+		rimraf(dir, {
+			maxBusyTries: 1
+		}, cb);
 	};
 };
 

src/vs/editor/browser/standalone/standaloneServices.ts

@@ -187,7 +187,7 @@ export function getOrCreateStaticServices(services?: IEditorOverrideServices): I
 	let markerService = services.markerService || new MainProcessMarkerService(threadService);
 	let requestService = services.requestService || new SimpleEditorRequestService(contextService, telemetryService);
 	let modeService = services.modeService || new MainThreadModeServiceImpl(threadService, extensionService, configurationService);
-	let modelService = services.modelService || new ModelServiceImpl(threadService, markerService, modeService, configurationService);
+	let modelService = services.modelService || new ModelServiceImpl(threadService, markerService, modeService, configurationService, messageService);
 	let editorWorkerService = services.editorWorkerService || new EditorWorkerServiceImpl(modelService);
 	let codeEditorService = services.codeEditorService || new CodeEditorServiceImpl();
 

src/vs/editor/common/services/modelServiceImpl.ts

@@ -4,6 +4,7 @@
  *--------------------------------------------------------------------------------------------*/
 'use strict';
 
+import * as nls from 'vs/nls';
 import {onUnexpectedError} from 'vs/base/common/errors';
 import Event, {Emitter} from 'vs/base/common/event';
 import {IEmitterEvent} from 'vs/base/common/eventEmitter';
@@ -26,6 +27,7 @@ import {IResourceService} from 'vs/editor/common/services/resourceService';
 import * as platform from 'vs/base/common/platform';
 import {IConfigurationService, ConfigurationServiceEventTypes, IConfigurationServiceEvent} from 'vs/platform/configuration/common/configuration';
 import {DEFAULT_INDENTATION} from 'vs/editor/common/config/defaultConfig';
+import {IMessageService} from 'vs/platform/message/common/message';
 
 export interface IRawModelData {
 	url:URI;
@@ -188,6 +190,7 @@ export class ModelServiceImpl implements IModelService {
 	private _markerServiceSubscription: IDisposable;
 	private _threadService: IThreadService;
 	private _modeService: IModeService;
+	private _messageService: IMessageService;
 	private _configurationService: IConfigurationService;
 	private _configurationServiceSubscription: IDisposable;
 	private _workerHelper: ModelServiceWorkerHelper;
@@ -198,6 +201,8 @@ export class ModelServiceImpl implements IModelService {
 
 	private _modelCreationOptions: editorCommon.ITextModelCreationOptions;
 
+	private _hasShownMigrationMessage: boolean;
+
 	/**
 	 * All the models known in the system.
 	 */
@@ -207,7 +212,8 @@ export class ModelServiceImpl implements IModelService {
 		threadService: IThreadService,
 		markerService: IMarkerService,
 		modeService: IModeService,
-		configurationService: IConfigurationService
+		configurationService: IConfigurationService,
+		messageService: IMessageService
 	) {
 		this._modelCreationOptions = {
 			tabSize: DEFAULT_INDENTATION.tabSize,
@@ -220,21 +226,27 @@ export class ModelServiceImpl implements IModelService {
 		this._modeService = modeService;
 		this._workerHelper = this._threadService.getRemotable(ModelServiceWorkerHelper);
 		this._configurationService = configurationService;
+		this._messageService = messageService;
+		this._hasShownMigrationMessage = false;
 
 		let readConfig = (config:IRawConfig) => {
 			const eol = config.files && config.files.eol;
 
+			let shouldShowMigrationMessage = false;
+
 			let tabSize = DEFAULT_INDENTATION.tabSize;
 			if (config.editor && typeof config.editor.tabSize !== 'undefined') {
 				let parsedTabSize = parseInt(config.editor.tabSize, 10);
 				if (!isNaN(parsedTabSize)) {
 					tabSize = parsedTabSize;
 				}
+				shouldShowMigrationMessage = shouldShowMigrationMessage || (config.editor.tabSize === 'auto');
 			}
 
 			let insertSpaces = DEFAULT_INDENTATION.insertSpaces;
 			if (config.editor && typeof config.editor.insertSpaces !== 'undefined') {
 				insertSpaces = (config.editor.insertSpaces === 'false' ? false : Boolean(config.editor.insertSpaces));
+				shouldShowMigrationMessage = shouldShowMigrationMessage || (config.editor.insertSpaces === 'auto');
 			}
 
 			let newDefaultEOL = this._modelCreationOptions.defaultEOL;
@@ -256,6 +268,11 @@ export class ModelServiceImpl implements IModelService {
 				defaultEOL: newDefaultEOL
 			});
 
+
+			if (shouldShowMigrationMessage && !this._hasShownMigrationMessage) {
+				this._hasShownMigrationMessage = true;
+				this._messageService.show(Severity.Info, nls.localize('indentAutoMigrate', "Please update your settings: `editor.detectIndentation` replaces `editor.tabSize`: \"auto\" or `editor.insertSpaces`: \"auto\""));
+			}
 		};
 		this._configurationServiceSubscription = this._configurationService.addListener2(ConfigurationServiceEventTypes.UPDATED, (e: IConfigurationServiceEvent) => {
 			readConfig(e.config);

src/vs/editor/test/common/servicesTestUtils.ts

@@ -157,7 +157,7 @@ export function createMockModelService(): IModelService {
 	var threadService = NULL_THREAD_SERVICE;
 	var extensionService = new MockExtensionService();
 	var modeService = new MockModeService(threadService, extensionService);
-	var modelService = new MockModelService(threadService, null, modeService, configurationService);
+	var modelService = new MockModelService(threadService, null, modeService, configurationService, null);
 	var inst = createInstantiationService({
 		threadService: threadService,
 		extensionService: extensionService,

src/vs/languages/typescript.workbench/test/common/projectResolver.test.ts

@@ -62,7 +62,8 @@ function createModelService(): IModelService {
 		onModelAdded: undefined,
 		onModelRemoved: undefined,
 		onModelModeChanged: undefined,
-		destroyModel: undefined
+		destroyModel: undefined,
+		getCreationOptions: undefined
 	}
 }
 

src/vs/workbench/electron-browser/shell.ts

@@ -272,7 +272,7 @@ export class WorkbenchShell {
 		this.keybindingService.setExtensionService(extensionService);
 
 		let modeService = new MainThreadModeServiceImpl(this.threadService, extensionService, configService);
-		let modelService = new ModelServiceImpl(this.threadService, markerService, modeService, configService);
+		let modelService = new ModelServiceImpl(this.threadService, markerService, modeService, configService, this.messageService);
 		let editorWorkerService = new EditorWorkerServiceImpl(modelService);
 
 		let untitledEditorService = new UntitledEditorService();

src/vs/workbench/test/node/api/extHostApiCommands.test.ts

@@ -71,7 +71,8 @@ suite('ExtHostLanguageFeatureCommands', function() {
 			getModels(): any { throw new Error(); },
 			onModelAdded: undefined,
 			onModelModeChanged: undefined,
-			onModelRemoved: undefined
+			onModelRemoved: undefined,
+			getCreationOptions(): any { throw new Error(); }
 		});
 
 		threadService.getRemotable(ExtHostModelService)._acceptModelAdd({