Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-17 23:35:54 +01:00
Code Issues Packages Projects Releases Wiki Activity

sessions - hide 2nd row stuff when session in progress (#305549)

Browse Source 
* sessions - hide 2nd row stuff when session in progress

* Update src/vs/sessions/contrib/sessions/browser/views/sessionsList.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* sessions: clear timeDisposable when hideDetails is true to prevent timer leak

Agent-Logs-Url: https://github.com/microsoft/vscode/sessions/e0e96a2b-6b5b-49b9-bfe7-3161a5d7ed88

Co-authored-by: bpasero <900690+bpasero@users.noreply.github.com>

* Update src/vs/sessions/contrib/sessions/browser/views/sessionsList.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update src/vs/sessions/contrib/sessions/browser/views/sessionsList.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: bpasero <900690+bpasero@users.noreply.github.com>
This commit is contained in:
Benjamin Pasero
2026-03-27 11:48:21 +01:00
committed by GitHub
parent dd52de3c9a
commit 13956d46e5
1 changed files with 28 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

45
src/vs/sessions/contrib/sessions/browser/views/sessionsList.ts
View File

@@ -256,8 +256,14 @@ class SessionItemRenderer implements ITreeRenderer<SessionListItem, FuzzyScore,
const changes = element.changes.read(reader);
const workspace = element.workspace.read(reader);
const description = element.description.read(reader);
const timeDate = this.options.sorting() === SessionsSorting.Updated ? element.updatedAt.read(reader) : element.createdAt;
let timeDate: Date | undefined;
// When the session is InProgress or NeedsInput, hide workspace/diff/time details in this row
const hideDetails = sessionStatus === SessionStatus.InProgress || sessionStatus === SessionStatus.NeedsInput;
if (!hideDetails) {
timeDate = this.options.sorting() === SessionsSorting.Updated ? element.updatedAt.read(reader) : element.createdAt;
}
// Clear and rebuild details row
DOM.clearNode(template.detailsRow);
const parts: HTMLElement[] = [];
@@ -273,7 +279,7 @@ class SessionItemRenderer implements ITreeRenderer<SessionListItem, FuzzyScore,
// Workspace badge — show when not grouped by workspace,
// or when the session is pinned/archived (their section headers
// don't carry the workspace name)
if (workspace && (
if (!hideDetails && workspace && (
this.options.grouping() !== SessionsGrouping.Workspace ||
this.options.isPinned(element) ||
element.isArchived.read(reader)
@@ -287,7 +293,7 @@ class SessionItemRenderer implements ITreeRenderer<SessionListItem, FuzzyScore,
}
// Diff stats
if (changes.length > 0 && sessionStatus !== SessionStatus.InProgress) {
if (!hideDetails && changes.length > 0) {
let insertions = 0;
let deletions = 0;
for (const change of changes) {
@@ -329,21 +335,26 @@ class SessionItemRenderer implements ITreeRenderer<SessionListItem, FuzzyScore,
parts.push(statusEl);
}
// Timestamp — always visible
if (parts.length > 0) {
DOM.append(template.detailsRow, $('span.session-separator.has-separator'));
}
const timeEl = DOM.append(template.detailsRow, $('span.session-time'));
const formatTime = () => {
const seconds = Math.round((Date.now() - timeDate.getTime()) / 1000);
return seconds < 60 ? localize('secondsDuration', "now") : fromNow(timeDate, true);
};
timeEl.textContent = formatTime();
const targetWindow = DOM.getWindow(timeEl);
const interval = targetWindow.setInterval(() => {
// Timestamp — visible when not hiding details
if (!hideDetails && timeDate) {
if (parts.length > 0) {
DOM.append(template.detailsRow, $('span.session-separator.has-separator'));
}
const timeEl = DOM.append(template.detailsRow, $('span.session-time'));
const definiteTimeDate = timeDate;
const formatTime = () => {
const seconds = Math.round((Date.now() - definiteTimeDate.getTime()) / 1000);
return seconds < 60 ? localize('secondsDuration', "now") : fromNow(definiteTimeDate, true);
};
timeEl.textContent = formatTime();
}, 60_000);
timeDisposable.value = toDisposable(() => targetWindow.clearInterval(interval));
const targetWindow = DOM.getWindow(timeEl);
const interval = targetWindow.setInterval(() => {
timeEl.textContent = formatTime();
}, 60_000);
timeDisposable.value = toDisposable(() => targetWindow.clearInterval(interval));
} else {
timeDisposable.clear();
}
}));
// Approval row — reactive