Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-07-13 23:44:09 +01:00
Code Issues Packages Projects Releases Wiki Activity

reduce number of times classes are changed for command decorations

Browse Source
This commit is contained in:
meganrogge
2022-02-23 15:34:04 -06:00
parent 1acc55dcc1
commit 178cc2118b
1 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/vs/workbench/contrib/terminal/browser/xterm/decorationAddon.ts
+7 -4
View File
@@ -61,6 +61,9 @@ export class DecorationAddon extends Disposable implements ITerminalAddon {
if (e.affectsConfiguration(TerminalSettingId.ShellIntegrationDecorationIcon) ||
e.affectsConfiguration(TerminalSettingId.ShellIntegrationDecorationIconSuccess) ||
e.affectsConfiguration(TerminalSettingId.ShellIntegrationDecorationIconError)) {
if (this._placeholderDecoration?.element) {
this._applyStyles(this._placeholderDecoration.element);
}
for (const decoration of this._decorations) {
if (decoration[1].decoration?.element) {
this._applyStyles(decoration[1].decoration.element, decoration[1].exitCode);
@@ -157,7 +160,10 @@ export class DecorationAddon extends Disposable implements ITerminalAddon {
this._decorations.set(decoration.marker.id, { decoration, disposables, exitCode: command.exitCode });
}
}
if (target.clientWidth! > 0) {
if (!target.classList.contains(DecorationSelector.Codicon)) {
// must be inlined to override the inlined styles from xterm
target.style.width = '16px';
target.style.height = '16px';
this._applyStyles(target, command.exitCode);
}
});
@@ -168,9 +174,6 @@ export class DecorationAddon extends Disposable implements ITerminalAddon {
}
private _applyStyles(target: HTMLElement, exitCode?: number): void {
// must be inlined to override the inlined styles from xterm
target.style.width = '16px';
target.style.height = '16px';
for (const classes of target.classList) {
target.classList.remove(classes);
}