Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-05-08 17:19:48 +01:00
Code Issues Packages Projects Releases Wiki Activity

Add todo for joinInstances

Browse Source
This commit is contained in:
Daniel Imms
2021-06-16 05:17:05 -07:00
parent 0c5fbcccd8
commit 1e5991b64b
2 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/vs/workbench/contrib/terminal/browser/terminalInstance.ts
-1
View File
@@ -956,7 +956,6 @@ export class TerminalInstance extends Disposable implements ITerminalInstance {
this._wrapperElement.xterm = undefined;
}
if (this._wrapperElement.parentElement && this._container) {
console.log('dispose');
this._container.removeChild(this._wrapperElement);
}
}
src/vs/workbench/contrib/terminal/browser/terminalService.ts
+1 -1
View File
@@ -788,7 +788,7 @@ export class TerminalService implements ITerminalService {
}
source.target = TerminalTarget.TerminalView;
// TODO: Share code with joinInstances
// TODO: Share code with joinInstances - move into terminal group service
const group = this._instantiationService.createInstance(TerminalGroup, this._terminalContainer, undefined);
group.onPanelOrientationChanged((orientation) => this._onPanelOrientationChanged.fire(orientation));
this._terminalGroups.push(group);