Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-05-08 17:19:48 +01:00
Code Issues Packages Projects Releases Wiki Activity

Delay workspace recommendations as remote extensions installations are ongoing For #124119

Browse Source
This commit is contained in:
Martin Aeschlimann
2021-05-18 20:39:39 +02:00
parent b84a8c4215
commit 25967171f1
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/vs/workbench/contrib/extensions/browser/extensionRecommendationsService.ts
+4 -3
View File
@@ -21,12 +21,15 @@ import { KeymapRecommendations } from 'vs/workbench/contrib/extensions/browser/k
import { ExtensionRecommendation } from 'vs/workbench/contrib/extensions/browser/extensionRecommendations';
import { ConfigBasedRecommendations } from 'vs/workbench/contrib/extensions/browser/configBasedRecommendations';
import { IExtensionRecommendationNotificationService } from 'vs/platform/extensionRecommendations/common/extensionRecommendations';
import { timeout } from 'vs/base/common/async';
type IgnoreRecommendationClassification = {
recommendationReason: { classification: 'SystemMetaData', purpose: 'FeatureInsight', isMeasurement: true };
extensionId: { classification: 'PublicNonPersonalData', purpose: 'FeatureInsight' };
};
const WORKSPACE_RECOMMENDATION_DELAY = 5000;
export class ExtensionRecommendationsService extends Disposable implements IExtensionRecommendationsService {
declare readonly _serviceBrand: undefined;
@@ -238,10 +241,8 @@ export class ExtensionRecommendationsService extends Disposable implements IExte
.filter(extensionId => this.isExtensionAllowedToBeRecommended(extensionId));
if (allowedRecommendations.length) {
await timeout(WORKSPACE_RECOMMENDATION_DELAY); // remote extensions might still being installed #124119
await this.extensionRecommendationNotificationService.promptWorkspaceRecommendations(allowedRecommendations);
}
}
}