Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-05-22 16:19:52 +01:00
Code Issues Packages Projects Releases Wiki Activity

Spawn .bat/.cmd DebugAdapterExecutables with shell=true (#224350)

Browse Source 
Spawn .bat/.cmd DebugAdapterExecutables with shell=true (#224320)

* Spawn .bat DAs with shell=true

* Also escape args

* And .cmd

* escape argument properly

* Don't escape \
This commit is contained in:
Rob Lourens
2024-07-30 16:59:54 -07:00
committed by GitHub
parent 9b08d9909a
commit 3304003478
1 changed files with 14 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/vs/workbench/contrib/debug/node/debugAdapter.ts
+14 -1
View File
@@ -222,13 +222,26 @@ export class ExecutableDebugAdapter extends StreamDebugAdapter {
throw new Error(nls.localize('unableToLaunchDebugAdapterNoArgs', "Unable to launch debug adapter."));
}
} else {
let spawnCommand = command;
let spawnArgs = args;
const spawnOptions: cp.SpawnOptions = {
env: env
};
if (options.cwd) {
spawnOptions.cwd = options.cwd;
}
this.serverProcess = cp.spawn(command, args, spawnOptions);
if (platform.isWindows && (command.endsWith('.bat') || command.endsWith('.cmd'))) {
// https://github.com/microsoft/vscode/issues/224184
spawnOptions.shell = true;
spawnCommand = `"${command}"`;
spawnArgs = args.map(a => {
a = a.replace(/"/g, '\\"'); // Escape existing double quotes with \
// Wrap in double quotes
return `"${a}"`;
});
}
this.serverProcess = cp.spawn(spawnCommand, spawnArgs, spawnOptions);
}
this.serverProcess.on('error', err => {