Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-09-30 06:58:55 +01:00
Code Issues Packages Projects Releases Wiki Activity

chat: cleanup unnecessary isPendingConfirmation triggers (#283651)

Browse Source 
* chat: cleanup unnecessary isPendingConfirmation triggers

* fix tests
This commit is contained in:
Connor Peet
2025-12-15 11:59:37 -08:00
committed by GitHub
parent 3320742642
commit 35cf9bcdb3
2 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/vs/workbench/contrib/chat/common/chatModel.ts
+6 -5
View File
@@ -973,27 +973,28 @@ export class ChatResponseModel extends Disposable implements IChatResponseModel
const signal = observableSignalFromEvent(this, this.onDidChange);
const _pendingInfo = signal.map((_value, r): { detail?: string } | undefined => {
const _pendingInfo = signal.map((_value, r): string | undefined => {
signal.read(r);
for (const part of this._response.value) {
if (part.kind === 'toolInvocation' && part.state.read(r).type === IChatToolInvocation.StateKind.WaitingForConfirmation) {
const title = part.confirmationMessages?.title;
return { detail: title ? (isMarkdownString(title) ? title.value : title) : undefined };
return title ? (isMarkdownString(title) ? title.value : title) : undefined;
}
if (part.kind === 'confirmation' && !part.isUsed) {
return { detail: part.title };
return part.title;
}
if (part.kind === 'elicitation2' && part.state.read(r) === ElicitationState.Pending) {
const title = part.title;
return { detail: isMarkdownString(title) ? title.value : title };
return isMarkdownString(title) ? title.value : title;
}
}
return undefined;
});
const _startedWaitingAt = _pendingInfo.map(p => !!p).map(p => p ? Date.now() : undefined);
this.isPendingConfirmation = _startedWaitingAt.map((waiting, r) => waiting ? { startedWaitingAt: waiting, detail: _pendingInfo.read(r)?.detail } : undefined);
this.isPendingConfirmation = _startedWaitingAt.map((waiting, r) => waiting ? { startedWaitingAt: waiting, detail: _pendingInfo.read(r) } : undefined);
this.isInProgress = signal.map((_value, r) => {
src/vs/workbench/contrib/chat/test/common/chatModel.test.ts
+1
View File
@@ -519,6 +519,7 @@ suite('ChatResponseModel', () => {
const toolInvocation = {
kind: 'toolInvocation',
invocationMessage: 'calling tool',
confirmationMessages: { title: 'Please confirm' },
state: toolState
} as Partial<IChatToolInvocation> as IChatToolInvocation;