Skip suggestwidget telemetry if its already open Fixes #54667

This commit is contained in:
Ramya Achutha Rao
2018-08-23 18:56:28 -07:00
parent 322390ca64
commit 3cbd552f3d
+15 -12
View File
@@ -704,18 +704,21 @@ export class SuggestWidget implements IContentWidget, IVirtualDelegate<ICompleti
this.completionModel = null;
} else {
const { stats } = this.completionModel;
stats['wasAutomaticallyTriggered'] = !!isAuto;
/* __GDPR__
"suggestWidget" : {
"wasAutomaticallyTriggered" : { "classification": "SystemMetaData", "purpose": "FeatureInsight", "isMeasurement": true },
"${include}": [
"${ICompletionStats}",
"${EditorTelemetryData}"
]
}
*/
this.telemetryService.publicLog('suggestWidget', { ...stats, ...this.editor.getTelemetryData() });
if (this.state !== State.Open) {
const { stats } = this.completionModel;
stats['wasAutomaticallyTriggered'] = !!isAuto;
/* __GDPR__
"suggestWidget" : {
"wasAutomaticallyTriggered" : { "classification": "SystemMetaData", "purpose": "FeatureInsight", "isMeasurement": true },
"${include}": [
"${ICompletionStats}",
"${EditorTelemetryData}"
]
}
*/
this.telemetryService.publicLog('suggestWidget', { ...stats, ...this.editor.getTelemetryData() });
}
this.list.splice(0, this.list.length, this.completionModel.items);