Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-05-08 17:19:48 +01:00
Code Issues Packages Projects Releases Wiki Activity

window - mitigate macOS fullscreen issue with custom title (#203986)

Browse Source
This commit is contained in:
Benjamin Pasero
2024-02-01 17:35:00 +01:00
committed by GitHub
parent 3513974b53
commit 44fd438df5
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/vs/platform/windows/electron-main/windowImpl.ts
+8 -1
View File
@@ -408,7 +408,14 @@ export abstract class BaseWindow extends Disposable implements IBaseWindow {
this.transientIsNativeFullScreen = undefined;
this.joinNativeFullScreenTransition = undefined;
if (!transitioned && fullscreen && fromRestore) {
// There is one interesting gotcha on macOS: when you are opening a new
// window from a fullscreen window, that new window will immediately
// open fullscreen and emit the `enter-full-screen` event even before we
// reach this method. In that case, we actually will timeout after 10s
// for detecting the transition and as such it is important that we only
// signal to leave fullscreen if the window reports as not being in fullscreen.
if (!transitioned && fullscreen && fromRestore && this.win && !this.win.isFullScreen()) {
// We have seen requests for fullscreen failing eventually after some
// time, for example when an OS update was performed and windows restore.