Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-09-12 11:39:57 +01:00
Code Issues Packages Projects Releases Wiki Activity

Allow non word only imports from node library (#2787)

Browse Source
This commit is contained in:
Benjamin Christopher Simmonds
2026-01-12 09:46:33 +00:00
committed by GitHub
parent 7f939d82d3
commit 46c19ea98e
1 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
extensions/copilot/src/extension/inlineEdits/vscode-node/features/diagnosticsBasedCompletions/importDiagnosticsCompletionProvider.ts
+10 -2
View File
@@ -374,7 +374,7 @@ class JavascriptImportHandler implements ILanguageImportHandler {
private static CodeActionTitlePrefixes = ['Add import from', 'Update import from'];
private static ImportsToIgnore = new Set<string>(['type', 'namespace', 'module', 'declare', 'abstract', 'from', 'of', 'require', 'async']);
private static ModulesToIgnore = new Set<string>(['node']);
private static ModulesToIgnore = new Set<string>([]);
isImportDiagnostic(diagnostic: Diagnostic): boolean {
return diagnostic.message.includes('Cannot find name');
@@ -393,6 +393,10 @@ class JavascriptImportHandler implements ILanguageImportHandler {
return true; // Ignore imports that are from node_modules and point to a subpath
}
if (importCodeAction.importSource === ImportSource.external && importCodeAction.importName === importCodeAction.importName.toLowerCase()) {
return true; // Ignore imports which consits of a single word as they are likely variable names. All lowercase is an over approximation for this
}
if (JavascriptImportHandler.ImportsToIgnore.has(importCodeAction.importName)) {
return true;
}
@@ -440,7 +444,11 @@ class JavascriptImportHandler implements ILanguageImportHandler {
}
}
const potentialNodeModules = [importPath, importPath.split('/')[0], importPath.split(':')[0]];
if (importPath.includes(':')) {
return ImportSource.external;
}
const potentialNodeModules = [importPath, importPath.split('/')[0]];
if (potentialNodeModules.some(importPath => workspaceInfo.nodeModules.has(importPath))) {
return ImportSource.external;
}